Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting Payment August 27th] [$500] Chat - UX covers message #44388

Closed
1 of 6 tasks
lanitochka17 opened this issue Jun 25, 2024 · 78 comments
Closed
1 of 6 tasks

[Awaiting Payment August 27th] [$500] Chat - UX covers message #44388

lanitochka17 opened this issue Jun 25, 2024 · 78 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-17
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): betlihemasfaw14@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to Admin > plus sign
  2. Add title and Assignee
  3. Go to Quick Action and assign task
  4. Add title and confirm

Expected Result:

UX should not cover the message

Actual Result:

UX covers the message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6520381_1718963271383.Screen_Recording_2024-06-21_at_2.39.45_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01eec125fcb90e14fe
  • Upwork Job ID: 1805999145742342542
  • Last Price Increase: 2024-09-05
Issue OwnerCurrent Issue Owner: @
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 25, 2024
Copy link

melvin-bot bot commented Jun 25, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

e think that this bug might be related to #vip-vsp

@kevinksullivan
Copy link
Contributor

Huh... Definitely unideal. This should go in #wave-collect because it's tied to a workspace/admins room though.

@kevinksullivan kevinksullivan added the External Added to denote the issue can be worked on by a contributor label Jun 26, 2024
@melvin-bot melvin-bot bot changed the title Chat - UX covers message [$250] Chat - UX covers message Jun 26, 2024
Copy link

melvin-bot bot commented Jun 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01eec125fcb90e14fe

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 26, 2024
Copy link

melvin-bot bot commented Jun 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

@kevinksullivan kevinksullivan removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jun 26, 2024
@kevinksullivan
Copy link
Contributor

@lanitochka17 I am unable to reproduce this actually. Are there more specific steps I need to follow than those you added in the post?

image

@iCodePrograms
Copy link

@lanitochka17 I am unable to reproduce this actually. Are there more specific steps I need to follow than those you added in the post?

image

Again coming in from Upwork, I believe we would require to add another task to reproduce the issue and a specific mode of display which is causing the issue

Copy link

melvin-bot bot commented Jun 26, 2024

📣 @iCodePrograms! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@iCodePrograms
Copy link

Contributor details
Your Expensify account email: shamabegum88@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01f8324b203ccf973f

Copy link

melvin-bot bot commented Jun 26, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@kevinksullivan
Copy link
Contributor

Again coming in from Upwork, I believe we would require to add another task to reproduce the issue and a specific mode of display which is causing the issue

@iCodePrograms can you elaborate? I took the Help wanted label off here and am trying to reproduce.

@iCodePrograms
Copy link

Hi @kevinksullivan, to be able to reproduce the error
Click New Workspace ->
Back button (left arrow) ->
Click on #admins channel ->
Click on the + button beside the chat box ->
Assign Task ->
Enter any title ->
Select Assignee ->
Create Task->
Click on the + button in the menu to find Quick Action Assign Task ->
Enter title ->
Create Task
You should see the error
something like this
image
I'm using Windows OS by the way I can reproduce it too, we might need to extend the scope of occurrence in details of the issue.

Copy link

melvin-bot bot commented Jul 1, 2024

@kevinksullivan, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@allgandalf
Copy link
Contributor

Chill Melvin, this is waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Jul 2, 2024
Copy link

melvin-bot bot commented Jul 5, 2024

@kevinksullivan, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2024
@allgandalf
Copy link
Contributor

Same as ^

@melvin-bot melvin-bot bot removed the Overdue label Jul 5, 2024
@allgandalf
Copy link
Contributor

  • The PR that introduced the bug has been identified. Link to the PR: Fix/39049 shortcut self dm task #39215

  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix/39049 shortcut self dm task #39215 (comment)

  • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

  • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

  1. Create a new workspace.
  2. Go to the Admins room.
  3. Create or assign a task to another user by using the + button located on the left side of the composer.
  4. Click on the FAB and select the quick action to assign task.

Verify that there are no UX glitches and that the UI appears normal.

Do we agree 👍 or 👎

@allgandalf
Copy link
Contributor

@kevinksullivan , this is ready for payment, can you pay it out please 🙇

@trjExpensify trjExpensify changed the title [$500] Chat - UX covers message [Awaiting Payment August 27th] [$500] Chat - UX covers message Sep 3, 2024
@trjExpensify trjExpensify added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor and removed Monthly KSv2 Weekly KSv2 Reviewing Has a PR in review labels Sep 3, 2024
@melvin-bot melvin-bot bot changed the title [Awaiting Payment August 27th] [$500] Chat - UX covers message [Awaiting Payment August 27th] [$250] Chat - UX covers message Sep 3, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 3, 2024
Copy link

melvin-bot bot commented Sep 3, 2024

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

@trjExpensify trjExpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 3, 2024
@trjExpensify
Copy link
Contributor

Updated labels for you, Kev. Payments due.

@allgandalf
Copy link
Contributor

Whoa why melvin 😭 , This is a $500 dollar issue, not fair, can you please update the price here @trjExpensify @kevinksullivan

@trjExpensify trjExpensify changed the title [Awaiting Payment August 27th] [$250] Chat - UX covers message [Awaiting Payment August 27th] [$500] Chat - UX covers message Sep 5, 2024
Copy link

melvin-bot bot commented Sep 5, 2024

Upwork job price has been updated to $500

@trjExpensify
Copy link
Contributor

Done!

@kevinksullivan
Copy link
Contributor

New job

https://www.upwork.com/ab/applicants/1831797736299827437/job-details

Offer sent to @allgandalf . @tsa321 mind linking your upwork profile or applying directly? Thanks

@kevinksullivan
Copy link
Contributor

paid @allgandalf

@kevinksullivan
Copy link
Contributor

offer sent @tsa321 . Let me know when you accept!

@tsa321
Copy link
Contributor

tsa321 commented Sep 6, 2024

@kevinksullivan I have accepted the offer, thanks

@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@allgandalf
Copy link
Contributor

Not overdue melvin, waiting for contributor payment

@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2024
@Julesssss
Copy link
Contributor

@kevinksullivan I assume payment is complete, but please verify before closing. Thanks

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Sep 10, 2024
@kevinksullivan
Copy link
Contributor

yup all set here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

10 participants