[HOLD https://github.com/Expensify/react-native-live-markdown/pull/394][Live Markdown] Support inline code background style

[thienlnam]

https://expensify.slack.com/archives/C049HHMV9SM/p1712094742944359

Now that live markdown preview is out on production - let's add support for the background style for inline code

It should use the same font and background style, but currently doesn't.

[melvin-bot]

Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[thienlnam]

Added to the main tracking issue as part of HIGH: #36071

[lschurr]

Anything needed from BZ on this one @thienlnam?

[thienlnam]

Not at this time, we'll probably need payment to the C+ that reviews in the future but that's further away

[tomekzaw]

We're working on it.

iOS

I've asked @maksg from SWM to implement the iOS part. Here's the draft PR to Live Markdown:

• Implement code and pre blocks support on iOS react-native-live-markdown#306

Android

@maksg from SWM is also working on the Android part.

Web

@Skalakid had a working PoC some time ago, I will ask him to submit a PR for web.

[lschurr]

Any update @thienlnam @tomekzaw?

[Skalakid]

Hi @lschurr, @BartoszGrajdek is working on it

[BartoszGrajdek]

Hi @lschurr so here's a quick update on what's happening:

There are 2 different blocks to handle here contrary to what the issue title/description may say namely: inline code & pre blocks (single / triple backticks).

Like we agreed here there will be some changes to ExpensiMark to limit the number of cases where the pre styling is applied - I have it roughly done, but we will likely need some additional refactors.

Currently, I'm working on implementing the pre block styles for web. That's a tricky case because of the limitations that the Live Markdown puts on us, but I'm trying to overcome it.

I'll keep you updated! 😄

[tomekzaw]

As for the Android part, @maksg is working on it.

[quinthar]

Hi, what's the next step and ETA on this?

[tomekzaw]

Here's the Android PR from @maksg:

• Implement code and pre blocks support on Android react-native-live-markdown#338

Currently waiting for @BartoszGrajdek's PR for web

Next step: Complete PR for web

ETA: ~2 weeks

[lschurr]

Any update @BartoszGrajdek @tomekzaw?

[thienlnam]

Held PR still in the works

[BartoszGrajdek]

Hi! Adding an update here, since a few things have happened. 👀

As you know we already have the changes for Android/iOS prepared. At the beginning of this week, I finished a web implementation that I had been working on for the past ~2 weeks and it works really well in our refactored web component structure. That means everything's ready waiting for the refactor in question to get merged.

We're launching (hopefully) the last round of testing for the live markdown refactor PR and our current focus is to get it done ASAP. After that, if no regressions arise we'll work on merging all PRs inline-code / codefence related.

I'm OOO together with @Skalakid till 12.08, so I'll update you once we're back and know the test results. 🙌

[lschurr]

Anything new @BartoszGrajdek or are we still on hold?

[dangrous]

shush melvin

[tomekzaw]

We're working on it in react-native-live-markdown:

• Implement code and pre blocks support on web react-native-live-markdown#456
• Implement code and pre blocks support on Android react-native-live-markdown#338
• Implement code and pre blocks support on iOS react-native-live-markdown#306

[lschurr]

This looks like it's still on hold

[BartoszGrajdek]

@lschurr The web PR is no longer on hold. We're currently working on some remaining bugs together with @Skalakid, and we'll push it to E/App once it's bug-free.

I'll keep you updated! 🤞🏻

[twisterdotcom]

Relabelling as Lauren is OOO now.

[melvin-bot]

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[zanyrenney]

This issue is on HOLD.