-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement code and pre blocks support on iOS #306
base: main
Are you sure you want to change the base?
Conversation
Still discussing the expected behavior for codeblocks here |
It looks like It's okay for the initial implementation but ultimately we'd like I don't think it's possible to achieve padding for inline code on iOS (Slack for iOS also does not support it). However, I think it should be possible to implement padding for codeblocks. As for horizontal padding, I've copied this code from blockquotes and it seems to work: react-native-live-markdown/ios/RCTMarkdownUtils.mm Lines 119 to 122 in cd42c45
As for vertical padding, ChatGPT says that the only option is to set We can implement that in a follow-up PR. |
There seems to be some problem with codeblocks containing only one character: Screen.Recording.2024-04-17.at.01.52.15.mov |
09f4caf
to
76bed9d
Compare
76bed9d
to
dfc3362
Compare
dfc3362
to
a5d038c
Compare
a5d038c
to
589feb1
Compare
Details
Adds support for displaying and customising code and pre blocks on iOS.