[HOLD for payment 2024-05-02] [Mentions v2] Update auto-complete widget to perform online search when needed

[rlinoz]

HOLD #39532
HOLD #39505

When mentioning a room and the auto-complete widget has less than 5 results we will perform a request to search for reports that we might not have locally, this request will call the command SearchForRoomsToMention which will take a "query" and a policyID as parameters. The result of the call will be merge into onyx with the other reports and will automatically update the auto-complete widget with the new results.

While performing the search the auto-complete widget must show a loading indicator, as its shown here

Details can be found here in the Mentions V2 design doc.

[war-in]

Hi, I'm Marcin from SoftwareMansion and I would like to work on this one :) could you please assign me? 🙏

[rlinoz]

@war-in keep in mind that we still need this PR https://github.com/Expensify/Auth/pull/10483 to get merged to unblock this.

[war-in]

@rlinoz Yes I know :) I'm just starting to investigate it and would like to be assigned to avoid duplication

[melvin-bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[robertKozik]

@war-in keep in mind that we still need this PR https://github.com/Expensify/Auth/pull/10483 to get merged to unblock this.

Wondering what's the ETA for this?

[rlinoz]

It is in review, I think it will get merged today, but deployed only on monday.

Although, the SearchForRoomsToMention command is live, it just doesn't return the chatType and policyID with the report, so you can add the api call and ensure that it is being called correctly.

[rlinoz]

https://github.com/Expensify/Auth/pull/10483 is merged, waiting for deploy now.

[jliexpensify]

No payment needed right?

[rlinoz]

@jliexpensify I think we will have a C+ reviewing the PR later, so we will need payment at some point

[war-in]

@rlinoz @puneetlath We just noticed that there is a bug when trying to click on a single mention suggestion on iOS. After some investigation, it turned out that the issue is connected to FlashList usage in the SuggestionMention. It is somehow affected by the FlatList which is used to display messages. The workaround would be to replace FlashList with FlatList (it works correctly, but haven't tested it too much).

Bug exists on main branch too so it is not connected to changes from my branch

Example:

Screen.Recording.2024-04-16.at.10.54.46.mov

[rlinoz]

Last backend PR is deployed to prod.

[rlinoz]

@war-in is that happening only on iOS?

[rlinoz]

Anyway, it looks like there is a lot going on with FlashList right now, I think it would be better to fix this bug in another issue if it still exists after all the PR's in that issue are merged.

cc: @puneetlath @war-in

[war-in]

is that happening only on iOS?

Yeah, checked on other devices and they are fine.

[puneetlath]

Sorry for being dense, I couldn't tell from the video what the bug was. Mind explaining?

[rlinoz]

If the auto complete has only one item it is not possible to select it, if I understood correctly

[puneetlath]

Ohhh I see. Hm, yeah, that's not ideal. But I also agree about handling it separately if that's an existing bug.

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[shawnborton]

Let me know if anything is needed from Design here.

[rlinoz]

Oh I tagged you on the PR #40232 (comment) sorry

[shawnborton]

Sounds good, see ya over there!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Mentions v2] Update auto-complete widget to perform online search when needed #40232

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @war-in does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@war-in] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[rlinoz]

@parasharrajat reviewed the PR.

[jliexpensify]

Ok cool, so this should be the Payment Summary right?

• C+: @parasharrajat $250 (New.Dot request)

@parasharrajat - anything needed for the checklist?

[war-in]

@jliexpensify should I create a regression test? There is a comment from malvin-bot but I haven't seen this before so I need to ask 😅

[jliexpensify]

Hi @war-in - sure, if you think one is needed, feel free to propose the steps and I can send this over to QA.

[puneetlath]

@rlinoz we should actually probably put together a set of regression tests for room mentions in general.

[rlinoz]

Oh interesting, I agree. I will create some steps and share them in slack to get comments.

[jliexpensify]

Payment Summary for Jason Mills (for Rajat)

[jliexpensify]

@rlinoz there's nothing for me to do in terms of payments, but let me know if you come up with a Regression Test and I can create the GH. Otherwise, feel free to close this GH!

[rlinoz]

Started a slack thread here for regression tests of the entire feature, I will try to open the GH to add the tests by tomorrow.

We can close this one.

[parasharrajat]

As per this thread https://expensify.slack.com/archives/C02NK2DQWUX/p1715272276516799?thread_ts=1715190852.677769&cid=C02NK2DQWUX, the price should be 500.

Could you please update the summary @jliexpensify ?

[jliexpensify]

NEW PAYMENT SUMMARY

• C+: @parasharrajat $500 (New.Dot payment)

[parasharrajat]

Payment requested as per #39534 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat