Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pay 18/04] Payment issue for E/App PR#37733 #39632

Closed
melvin-bot bot opened this issue Apr 4, 2024 · 14 comments
Closed

[Pay 18/04] Payment issue for E/App PR#37733 #39632

melvin-bot bot opened this issue Apr 4, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Apr 4, 2024

Issue created to compensate the Contributor+ member for their work on #37733
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/351581.
Contributor+ member who reviewed the PR - @hoangzinh.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dba37651a9452207
  • Upwork Job ID: 1775938144672985088
  • Last Price Increase: 2024-04-04
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Apr 4, 2024
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Apr 4, 2024
Copy link
Author

melvin-bot bot commented Apr 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01dba37651a9452207

Copy link
Author

melvin-bot bot commented Apr 4, 2024

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

Copy link
Author

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 4, 2024
@bfitzexpensify
Copy link
Contributor

#37733 is merged, not yet deployed to prod

@bfitzexpensify
Copy link
Contributor

Deployed to staging yesterday, though it seemed to cause a whole bunch of regressions

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Apr 10, 2024
@bfitzexpensify
Copy link
Contributor

This hit prod yesterday, title updated.

@bfitzexpensify bfitzexpensify changed the title Payment issue for E/App PR#37733 [Pay 18/04] Payment issue for E/App PR#37733 Apr 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
Copy link
Author

melvin-bot bot commented Apr 16, 2024

@hoangzinh, @bfitzexpensify Eep! 4 days overdue now. Issues have feelings too...

@bfitzexpensify
Copy link
Contributor

Payment due Thursday

@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2024
Copy link
Author

melvin-bot bot commented Apr 18, 2024

@hoangzinh @bfitzexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@bfitzexpensify
Copy link
Contributor

Payment today - offer sent!

@hoangzinh
Copy link
Contributor

Hi @bfitzexpensify the PR #37733 has been reviewed over 1 month ago #37733 (comment). I recall we still have initial rate as 500$ at that time

@bfitzexpensify
Copy link
Contributor

Thanks for pointing that out @hoangzinh - you're correct. New offer sent.

@hoangzinh
Copy link
Contributor

Accepted. Thanks @bfitzexpensify

@bfitzexpensify
Copy link
Contributor

Thanks! Payment complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

2 participants