You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigate to the onboarding flow by manually navigating to '/onboarding' or overwriting a button.
Input a name and a surname in the input fields, press continue button.
Click on any of the displayed options and press continue.
Verify that a video modal pops up with the app explaination video, if you're on desktop you should also get auto-navigated to the concierge report.
Verify that you've received the correct message in the concierge report (it depends on the purpose you've chosen).
Verify that no errors appear in the JS console
Offline tests
Navigate to the onboarding flow by manually navigating to '/onboarding' or overwriting a button.
Input a name and a surname in the input fields, press continue button.
Click on any of the displayed options and press continue.
Instead of a video, the modal should display a lottie animation when in offline mode. The rest of the flow should stay the same.
QA Steps
Account creation -> Name + surname screen
Go to staging.new.expensify.com
Log in and navigate through Profile > About > Troubleshoot and press the 'Navigate' button next to Onboarding flow label
Verify the onboarding modal shows up
Verify you land on the Name + surname portion of the onboarding modal
Verify there's no 'X' to close the modal
Verify modal cannot be dismissed by clicking outside of it or by any other method
Verify refreshing the page does not dismiss the modal
Verify any input typed in the name and surname fields is kept between page refreshes
Verify clicking on Continue presents an error if either name or surname is empty
Verify " " (space) is a valid character to put in the name or surname field and it is treated as a valid name/surname (see top-level doc for explanation)
Verify clicking Continue takes you to the What do you want to do today? screen if Name + surname fields are correctly filled
Account creation -> Name + surname screen -> What do you want to do today? screen
Go to staging.new.expensify.com
Log in and navigate through Profile > About > Troubleshoot and press the 'Navigate' button next to Onboarding flow label
Fill in name and surname and hit Continue
Land on What do you want to do today? screen
Verify there's no 'X' to close the modal
Verify modal cannot be dismissed by clicking outside of it or by any other method
Verify refreshing the page does not dismiss the modal
Verify refreshing the page brings you back to the What do you want to do today? screen, as opposed to bringing you back to the Name + surname screen
Hitting Continue when no option is selected shows an error
Verify only a single option can be selected from multiple options presented
Verify chosen option is persisted between page refreshes
Verify pressing Back button navigates back to the Name + surname screen, and restores previously input name and surname
Log in and navigate through Profile > About > Troubleshoot and press the 'Navigate' button next to Onboarding flow label
Fill in name and surname and hit Continue
Select any option in the What do you want to do today? Screen and hit Continue
Onboarding modal closes and two things happen almost simultaneously:
Concierge message comes in
Verify a concierge message is received and the content of this message matches purpose selected in the onboarding modal (see high level for purpose⇔concierge mapping)
[Web only] Verify newest message from concierge is opened in the central panel
[Mobile only] Verify user lands on the chats screen, but the newest message is not automatically opened
Video modal shows up
Verify after a small delay video modal is shown
Verify video modal can be dismissed at any time by clicking on the grayed out area or by clicking on the Let's go button
Verify video autostarts
Verify video shows no controls except for the volume slider
Verify video shows progress bar in the bottom
Verify video can be paused/resumed by clicking anywhere on the video
Verify video plays in a loop
Verify on page refresh the onboarding video disappears, even if user did not close it explicitly
Verify when going offline video keeps playing if it already buffered enough data
Log in and navigate through Profile > About > Troubleshoot and press the 'Navigate' button next to Onboarding flow label
Fill in name and surname and hit Continue
Select any option in the What do you want to do today? Screen and hit Continue
Onboarding modal closes
Verify after a small delay video modal is shown
Verify instead of the video, a lottie animation is shown
Verify dismissing the onboarding video modal works like in online mode
Verify switching from offline to online hides the lottie animation and shows the video. The video starts loading immediately and autoplays. From this point test the video like in online mode.
PR Author Checklist
I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
I added steps for local testing in the Tests section
I added steps for the expected offline behavior in the Offline steps section
I added steps for Staging and/or Production testing in the QA steps section
I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
I verified that comments were added to code that is not self explanatory
I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
A similar style doesn't already exist
The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
* Implement progress bar
* Render progressBar with precedence of header
* Story for progressBar
* Missing semicolons
* Drop shouldShowProgressBar
* Fix double header rendered
* Wrap around useMemo
---------
Co-authored-by: Mateusz Rajski <mateusz.rajski@swmansion.com>
The reason will be displayed to describe this comment to others. Learn more.
We should had passed one more property numberOfLinesTitle here and set it to 0, this way we would have avoided the truncation of sentence in the onboarding modal, this caused #43804, but i also know that this was a large enough PR and the bug would not have been easily noticed
Coming from #45619, there were some console errors we missed handling when showing the welcome video during the onboarding flow. Details is here #45619 (comment)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
In order to invoke the Onboarding Flow, replace a button of your choice in the app:
Or a direct invoke using URL:
https://dev.new.expensify.com:8082/onboarding
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/351581
PROPOSAL:
Tests
Offline tests
QA Steps
Account creation -> Name + surname screen
Account creation -> Name + surname screen -> What do you want to do today? screen
Account creation -> Onboarding modal completed -> Chats
Account creation -> Onboarding modal completed -> [Offline mode] Onboarding video
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screenshots/Videos
Android: Native
ANDROID-NATIVE.mov
Android: mWeb Chrome
ANDROID-CHROME.mov
iOS: Native
IOS-NATIVE.mov
iOS: mWeb Safari
IOS-SAFARI.mov
MacOS: Chrome / Safari
CHROME.mov
MacOS: Desktop
DESKTOP.mov