[HOLD for payment 2024-04-25] [HOLD for payment 2024-04-17] [Guided Setup] [$250] Sign up - Welcome modal window on Abracadabra page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2616817
Issue reported by: Applause - Internal Team

Action Performed:

1. Open https://staging.new.expensify.com/
2. Enter new email
3. Copy magic link from received email
4. Change link to stage
5. Open link in a new tab
6. Navigate to original tab

Expected Result:

The abracadabra page is displayed
On original tab Concierge chat opens. The 'Welcome to Expensify' modal window appears

Actual Result:

The abracadabra page is displayed. The 'Welcome to Expensify' modal window appears on abracadabra page.
On original tab the skeleton loader displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442285_1712582015558.bandicam_2024-04-08_16-05-31-752.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017ea247a272b092bf
• Upwork Job ID: 1777419039357227008
• Last Price Increase: 2024-04-08
• Automatic offers:
• hoangzinh | Contributor | 0

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@cead22 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[cead22]

I think it's a regression from #37733

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017ea247a272b092bf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[cead22]

Coming from @mountiny on slack

Could we make the issue external and see if any proposals come in? Given this PR is an important piece for wave-collect Release 1 I think we would prefer not to revert and ideally CP a fix (if we confirm the revert fixes the blocker, we can CP it once we are close to the deploy - that wont happen until tomorrow)

[cead22]

cc @MaciejSWM @eVoloshchak

[filip-solecki]

Hi @mountiny @cead22 , I've checked it quickly looks like some changes in Welcome.ts file causes this behavior, not sure what exactly

[mountiny]

I will try to help manage this in my morning if this wont be resolved by then.

[hoangzinh]

Confirmed that revert #37733 would fix this issue. Checking root cause

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sign up - Welcome modal window on Abracadabra page

What is the root cause of that problem?

I think it is because of this change

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 330 to 334 in 38ced97

	} else {
	// If there is no matching central pane, we want to add the default one.
	metainfo.isCentralPaneAndBottomTabMandatory = false;
	routes.push(createCentralPaneNavigator({name: SCREENS.REPORT}));
	}

=> It takes this condition is false when in the validate page => leads to show current onboarding modal in validate page in the next line

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 47 to 49 in 38ced97

	if (Boolean(currentRoute && currentRoute.name !== NAVIGATORS.BOTTOM_TAB_NAVIGATOR && currentRoute.name !== NAVIGATORS.CENTRAL_PANE_NAVIGATOR) || Session.isAnonymousUser()) {
	return;
	}

This is the log of currentRoute before above condition

Before	After #37733

What changes do you think we should make in order to solve the problem?

We probably revert this change

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 330 to 334 in 38ced97

	} else {
	// If there is no matching central pane, we want to add the default one.
	metainfo.isCentralPaneAndBottomTabMandatory = false;
	routes.push(createCentralPaneNavigator({name: SCREENS.REPORT}));
	}

[mananjadhav]

This change looks promising, but @hoangzinh @mountiny @adamgrzybowski do we know what would break if this block is reverted?

[adamgrzybowski]

@mananjadhav Okay I did some investigation and I think the solution is somehow similar but not exactly the same.

The problem is that if should only handle pages that deeplinks to a bottom tab page.

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 315 to 340 in 38ced97

	if (bottomTabNavigator) {
	// Routes
	// - found bottom tab
	// - matching central pane on desktop layout
	if (isNarrowLayout) {
	return {
	adaptedState: state,
	metainfo,
	};
	}
	const routes = [...state.routes];
	const matchingCentralPaneRoute = getMatchingCentralPaneRouteForState(state);
	if (matchingCentralPaneRoute) {
	routes.push(createCentralPaneNavigator(matchingCentralPaneRoute));
	} else {
	// If there is no matching central pane, we want to add the default one.
	metainfo.isCentralPaneAndBottomTabMandatory = false;
	routes.push(createCentralPaneNavigator({name: SCREENS.REPORT}));
	}
	return {
	adaptedState: getRoutesWithIndex(routes),
	metainfo,
	};
	}

Instead of reverting the lines mentioned above we need to modify the if if(bottomTabNavigator) to the if(bottomTabNavigator && bottomTabNavigator.state)

Additionally it would be great to add a comment before if, maybe something like

// We need to make sure that this if only handles states where we deeplink to the bottom tab directly
if(bottomTabNavigator && bottomTabNavigator.state) {

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mananjadhav]

I think your solution would solve for both @adamgrzybowski. But I haven't tested the solution yet.

[hoangzinh]

@adamgrzybowski could you explain a little bit about why do you think adjusting the condition above is better than reverting the changes? I'm worried that it potentially cause other regression bugs

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix - Welcome modal is displayed on Abracadabra page after sign in #39938

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @hoangzinh requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav / @hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav / @hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav / @hoangzinh] Determine if we should create a regression test for this bug.
• [@mananjadhav / @hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[JmillsExpensify]

Whoops, removed that comment and holding off until the checklist is done and the payment date comes due.

[hoangzinh]

It's a DB issue so probably we don't have a BugZero Checklist

[mananjadhav]

@JmillsExpensify This was deployed on production and the original payout date was 2024-04-17. PR that caused the regression is #37733. It was already explained during the initial findings. We don't need a regression test here.

This is ready for payout.

[melvin-bot]

@cead22, @mananjadhav, @hoangzinh, @miljakljajic, @mountiny Huh... This is 4 days overdue. Who can take care of this?

[miljakljajic]

@hoangzinh please accept the payment offer

@mananjadhav payment summary: owed 250 USD

[hoangzinh]

Accepted. Thanks @miljakljajic

[JmillsExpensify]

$250 approved for @mananjadhav

[melvin-bot]

@cead22, @mananjadhav, @hoangzinh, @miljakljajic, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mananjadhav]

I think we're good to close this one. @miljakljajic @mountiny

[hoangzinh]

yup process payment then we're good to close this issue.

[cead22]

Which payment is missing?

[miljakljajic]

paid!

[hoangzinh]

Hi @miljakljajic I'm just checking Upwork and it appears that my payment for this issue hasn't been completed yet. Can you check again? Thank you.

[miljakljajic]

resolved