[HOLD for payment 2024-05-22] [$250] Onboarding- By pulling vertically, user is able to dismiss iOS Onboarding

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Access New Expensify iOS app
2. Sign into a valid account
3. Go to Settings > Troubleshoot > Onboarding flow to open the modal
4. Pull down vertically (Right under the status bar)

Expected Result:

User expects two thing:

1. If the user SHOULD be able to dismiss this modal, they should be able to do so via swiping horizontally as in all other parts of the app (Not vertically)

2. According to the PR, this modal should NOT be able to be closed at all , therefore pulling or swiping horizontally or vertically should not toggle any action

Actual Result:

The modal can be dismissed by pulling down vertically, while the modal on screen slides off the screen horizontally. To be able to dismiss the modal, user should pull down directly under the status bar on the top of the device screen.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6454396_1713490515322.Pulling_vertically_dismisses_the_modal_on_iOS_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c66b77d9e4afbb5b
• Upwork Job ID: 1785060015292096512
• Last Price Increase: 2024-05-07

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kavimuru]

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[mountiny]

@cdOut @filip-solecki can you please comment here so I can assign you, you have been looking into this one before

[melvin-bot]

@MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[cdOut]

Hi, I’m Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I’d like to work on this task.

[MitchExpensify]

How is the PR coming along @cdOut ?

[cdOut]

I was testing my solutions on native devices and web today, I should have the PR up early next week and push it fast through the review process.

[melvin-bot]

@mountiny, @MitchExpensify, @cdOut Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Checking in on the PR @cdOut 🙇

[cdOut]

I had to reprioritize due to Filip and Jakub both being OOO and I had to overtake some more important tasks from the Xero flow, I will try to work on this one tomorrow.

[mountiny]

Lets make this external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c66b77d9e4afbb5b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[cdOut]

@mountiny agreed, I won't be able to work on this before being out of office due to the xero and travel tasks. Thank you!

[parasharrajat]

Great. Please tag this issue so that I am assigned as reviewer.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rezkiy37]

Just opened a draft PR. I am opening for review soon 🙂

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix dismissing Onboarding on iOS #41765

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Reminder set to pay, thoughts on BZ steps @parasharrajats?

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Onboarding fixes #40688
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40688/files#r1605498299
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@parasharrajat] Determine if we should create a regression test for this bug. yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

IOS | Android

1. Login with a new user to see the Onboarding flow modal.
2. Pull down vertically (right under the status bar) or horizontally.
3. Verify that you cannot close the flow|Modal by the gesture.
   4, Verify that on the further screens (business name and names) you can use the gesture to return to the first one.

Do you agree 👍 or 👎 ?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $250 via NewDot

BugZero Checklist (@MitchExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1785060015292096512/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[MitchExpensify]

https://github.com/Expensify/Expensify/issues/399532

Thanks, @parasharrajat

[parasharrajat]

Payment requested as per #40555 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat