[HOLD for payment 2024-04-25] [Guided Setup] [$250] Android - Onboarding video can be scrubbed through on iOS app, but not on Android app

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37733
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com/onboarding.
2. Enter name > Next.
3. Select an option > Next.
4. When the video plays, scrub through the video.

Expected Result:

The onboarding video can be scrubbed through on Android app, as it is possible to do so on iOS app.

Actual Result:

The onboarding video cannot be scrubbed through on Android app.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442538_1712594533264.Android.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010886f419f3cf3d95
• Upwork Job ID: 1777809491124957184
• Last Price Increase: 2024-04-09

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

Gonna take over as this is related to the onboarding project where I am helping. Francois is ooo.

@filip-solecki @cdOut can one of you comment here so we can assign you to follow up

[mountiny]

Demoting as this is still not active for the users, they need to enter a deeplink flow with specific path to see this

[filip-solecki]

Hi! I am Filip from SWM an expert agency and I'll like to work on this issue!

[Skalakid]

Hi, I'm Michał from SWM an expert agency and I prepared a fix for the this issue. We are using a gesture handler inside the video progress bar and on Android it have problems with detecting gestures inside modals . Actually the problem is well known and to fix it we have to wrap the Onboarding Page with GestureHandlerRootView

[Skalakid]

@mountiny @filip-solecki Here is a PR with the fix

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010886f419f3cf3d95

[melvin-bot]

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

[trjExpensify]

Deployed to staging 5 days ago.

[mountiny]

We will need to pay $250 to @allroundexperts for their review and testing

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix onboarding video progress bar #39964

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @Skalakid does not require payment (Contractor)
• @filip-solecki does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

@allroundexperts $250 for their testing and a review.

I think the tests will be handled at the end of the onboarding projects

[muttmuure]

@allroundexperts sounds like you just need to submit your request through New Expensify

[allroundexperts]

All done. Feel free to close.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot
• Contributor: @Skalakid is from an agency-contributor and not due payment
• Contributor: @filip-solecki is from an agency-contributor and not due payment

BugZero Checklist (@muttmuure)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1777809491124957184/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

$250 approved for @allroundexperts