[$250] DEV: Investigate the console errors that show up after signing in

[youssef-lr]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Sign in to NewDot locally

Expected Result:

Ideally, no error should be shown in the console.

Actual Result:

Many console errors show up and they are distracting, it's hard to know which one of them is causing a UI issue.

As of now here are the errors I'm seeing:

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b447136e274124b6
• Upwork Job ID: 1813619813398356556
• Last Price Increase: 2024-07-31
• Automatic offers:
• hoangzinh | Reviewer | 103403426

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b447136e274124b6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mosesbabu]

Please re-state the problem that we are trying to solve in this issue.
Investigate the console errors that show up after signing in

What is the root cause of that problem?
1.the View components may have plain text is directly inside them will check Wrap all text with Text components.
2.some libraries are using deprecated methods like findDOMNode will check and update them
What changes do you think we should make in order to solve the problem?

1. will check Wrap all text with Text components.
2. will check libraries using depreciated methods such as findDOMNode and update them

[hoangzinh]

Hi @mosesbabu can you format your proposal same as PROPOSAL_TEMPLATE here? Besides that, the root cause needs to be more details and clearly point out which is causing the issue. Thank you.

[mosesbabu]

ok noted doing so right now. was asking if the issue is not yet assigned as well thank you

[hoangzinh]

yep, it is still open for proposals

[mosesbabu]

Proposal

i recreated the error locally there are more errors as well on the console apart from these can check them as well

Please re-state the problem that we are trying to solve in this issue.

Investigate the console errors that show up after signing in

What is the root cause of that problem?

The RCA was not how react handled the routes but this is fixed

• Fixed

• In progress
  
  caused by findDomNode being depreciated in StrictMode

What changes do you think we should make in order to solve the problem?

Verify that objects from which are reading properties are not undefined.
Add null or undefined checks before accessing properties

Ensure findDOMNode is not used directly.
Update any libraries that rely on findDOMNode to their latest versions

What alternative solutions did you explore? (Optional)

there are so many other errors i can clear them all if hired

[hoangzinh]

It looks better @mosesbabu, but next time, you don't need to post a new proposal, just update the existing one.

This error occurs when trying to access the routes property of an undefined object.

Can you elaborate more on it in your RCA? Which line of code caused this error? How can it happen? In RCA, we have to describe the root cause in detail as much as possible.

[melvin-bot]

@puneetlath, @hoangzinh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hoangzinh]

@mosesbabu is your proposal ready for the next review? If yes, please post a new comment according to step 7 of the guidelines https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#propose-a-solution-for-the-job

[mosesbabu]

Yes it's ready for review apologies this is my first time with expensify am I supposed to first fix the error or wait to be hired first

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[hoangzinh]

No worry @mosesbabu.

caused by findDomNode being depreciated in StrictMode

Your RCA is still not clear to me. Can you point out exactly which line of codes in Expensify/App repo or libraries that cause this error? Thank you.

[mosesbabu]

@hoangzinh The findDOMNode being depreciated error arises from this specific library is react-native-gesture-handler library in react not anywhere in the code as app is running on strictMode shows that its depreciated to fix is by using refs in componetts raising the error example component is :src/components/Pressable/GenericPressable/BaseGenericPressable.tsx however a depreciated warning doesnt keep app from running

[hoangzinh]

to fix is by using refs in componetts raising the error example component is :src/components/Pressable/GenericPressable/BaseGenericPressable.tsx

Cool. Can you share more details on how you would fix it in the BaseGenericPressable component?

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A few console error.

What is the root cause of that problem?

If we look at the video play() error stacktrace image, we can see that it's coming from the onboarding video. If you open /onboarding/welcome-video, then you will all the errors + other errors that doesn't show in the OP, except the routes error (the routes error only show when loggin in). Here is the explanation of each error:

1. Warning: findDOMNode is deprecated in StrictMode
   This error comes from react-native-gesture-handler and needs to be fixed on the upstream repo.

2. Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code
   This error comes from react-native-animatable and needs to be fixed on the upstream repo.

3. TypeError: Cannot read properties of undefined (reading 'routes')
   The getState() in resetHomeRouteParams is undefined.
   

   App/src/libs/actions/Session/index.ts

   Lines 678 to 680 in d8d7f78

   	function resetHomeRouteParams() {
   	Navigation.isNavigationReady().then(() => {
   	const routes = navigationRef.current?.getState().routes;

We previously have this kind of issue too in #37194.

4. Unexpected text node.
   This means there is a text rendered without a <Text> component. This erro comesfrom FeatureTrainingModal where we conditionally render a component based on a string value, but if it's empty, then '' is rendered.
   

   App/src/components/FeatureTrainingModal.tsx

   Lines 218 to 225 in 6fcca3c

   	{helpText && (
   	<Button
   	large
   	style={[styles.mb3]}
   	onPress={onHelp}
   	text={helpText}
   	/>
   	)}

5. validateDOMNesting(...): cannot appear as a descendant of .
   This means there is a nested button. This comes from BaseVideoPlayer where Pressable is inside another Pressable.
   

   App/src/components/VideoPlayer/BaseVideoPlayer.tsx

   Lines 297 to 314 in 6fcca3c

   	{/* We need to wrap the video component in a component that will catch unhandled pointer events. Otherwise, these
   	events will bubble up the tree, and it will cause unexpected press behavior. */}
   	<PressableWithoutFeedback
   	accessibilityRole="button"
   	accessible={false}
   	style={[styles.cursorDefault, style]}
   	>
   	<Hoverable shouldFreezeCapture={isPopoverVisible}>
   	{(isHovered) => (
   	<View style={[styles.w100, styles.h100]}>
   	<PressableWithoutFeedback
   	accessibilityRole="button"
   	accessible={false}
   	onPress={() => {
   	if (isFullScreenRef.current) {
   	return;
   	}
   	togglePlayCurrentVideo();

The code above is to fix #36906.

6. play() failed because the user didn't interact with the document first.
   The onboardoing video is auto-played, but the browser doesn't allow that without the user interacting first, except if the video is muted (read more here.

We mute the volume here initially, but not immediately.

App/src/components/VideoPlayerContexts/VolumeContext.tsx

Lines 11 to 32 in 6fcca3c

	const volume = useSharedValue(0);
	const updateVolume = useCallback(
	(newVolume: number) => {
	if (!currentVideoPlayerRef.current) {
	return;
	}
	currentVideoPlayerRef.current.setStatusAsync({volume: newVolume, isMuted: newVolume === 0});
	// eslint-disable-next-line react-compiler/react-compiler
	volume.value = newVolume;
	},
	[currentVideoPlayerRef, volume],
	);
	// We want to update the volume when currently playing video changes.
	// When originalParent changed we're sure that currentVideoPlayerRef is updated. So we can apply the new volume.
	useEffect(() => {
	if (!originalParent) {
	return;
	}
	updateVolume(volume.value);
	}, [originalParent, updateVolume, volume.value]);

7. The play() request was interrupted by a call to pause().
   This is explained in https://developer.chrome.com/blog/play-request-was-interrupted. play() is async and if a pause is called before the play() is resolved, the error is thrown. In our case, the currentReportID is changed from an empty string to the topmost reportID that triggers resetVideoPlayerData() which calls stopVideo().

App/src/components/VideoPlayerContexts/PlaybackContext.tsx

Lines 85 to 90 in 00d2c42

	useEffect(() => {
	if (!currentReportID) {
	return;
	}
	resetVideoPlayerData();
	}, [currentReportID, resetVideoPlayerData]);

App/src/components/VideoPlayerContexts/PlaybackContext.tsx

Lines 75 to 77 in 00d2c42

	const resetVideoPlayerData = useCallback(() => {
	videoResumeTryNumberRef.current = 0;
	stopVideo();

8. The play() request was interrupted because the media was removed from the document
   Can't reproduce it anymore.

What changes do you think we should make in order to solve the problem?

3. Add null safety when accessing the state

const routes = navigationRef.current?.getState()?.routes;

4. Use !! to check the text.

{!!title && !!description && <.../>}
...
{!!helpText && <.../>}

5. Remove the accessibilityRole so it's rendered as a div
   

   App/src/components/VideoPlayer/BaseVideoPlayer.tsx

   Lines 299 to 300 in 6fcca3c

   	<PressableWithoutFeedback
   	accessibilityRole="button"

6. Immediately mute the video when mounted in BaseVideoPlayer

useEffect(() => {
    videoPlayerRef.current?.setStatusAsync({volume: 0});
}, []);

7. Two ways to solve this.
   First, only stop the video if the video is playing.

checkVideoPlaying((isPlaying) => {
    videoResumeTryNumberRef.current = 0;
    if (isPlaying) {
        stopVideo();
    }
    setCurrentlyPlayingURL(null);
    ... // rest
});

Or, store the previous currentReportID

const prevCurrentReportID = usePrevious(currentReportID);

and don't call resetVideoPlayerData if the prevCurrentReportID is empty. This way, if the currentReportID is set for the first time, we won't call resetVideoPlayerData and it will only be called if the currentReportID is really changed (instead of being triggered from empty string to the topmost report ID).

if (!currentReportID || !prevCurrentReportID) {
    return;
}
resetVideoPlayerData();

[puneetlath]

Thoughts @hoangzinh?

[melvin-bot]

@puneetlath, @hoangzinh Huh... This is 4 days overdue. Who can take care of this?

[hoangzinh]

Hi @puneetlath, the first 2 warnings in RCA of @bernhardoj's proposal #45619 (comment) they're only in strict mode and need to be fixed in upstream repos (Warning: findDOMNode and Warning: Using UNSAFE_componentWillReceiveProps). Do you think we should fix it or can leave it there?

[bernhardoj]

I tried to apply your suggestion but it didn't work. Can you share exactly the component/where we should set mute for the player?

You can put the code in BaseVideoPlayer. I have added this info to my proposal.

I couldn't reproduce this error. Are you still able to reproduce it?

After retesting, the app is lagging before the video shows and I can't reproduce it. But after muting the video immediately, the app runs smoother and I can reproduce the issue again.

[hoangzinh]

Oh, you're right. Let's wait for @puneetlath thoughts on #45619 (comment)

[puneetlath]

Let's focus on fixing the ones that can be handled on our side for now in this issue.

[hoangzinh]

Thanks @puneetlath. @bernhardoj proposal looks good to me.

Link to proposal #45619 (comment)

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @hoangzinh

[melvin-bot]

This issue has not been updated in over 15 days. @puneetlath, @hoangzinh, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[puneetlath]

I think we're good to pay this one out. @hoangzinh can you complete the checklist?

[hoangzinh]

Sure, I will complete the checklist today

[hoangzinh]

BugZero Checklist:

Console error 3rd: TypeError: Cannot read properties of undefined (reading 'routes')
Console error 4th: Unexpected text node
Console error 5th: validateDOMNesting(...): cannot appear as a descendant of
Console error 6th: play() failed because the user didn't interact with the document first
Console error 7th: The play() request was interrupted by a call to pause()

• The PR that introduced the bug has been identified. Link to the PR:
• Console error 3rd
• Console error 4th
• Console error 5th
• Console error 6th & 7th
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• Comment on PR of console error 3rd
• Comment on the PR of console error 4th
• Comment on the PR of console error 5th
• Comment on the PR of console error 6&7th
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: 🚫 No it's just fix console error issue.

[hoangzinh]

I think we're good to pay this one out. @hoangzinh can you complete the checklist?

BZ checklist is complete , @puneetlath

[puneetlath]

Payment summary:

• C - $250 - @bernhardoj - to be paid via NewDot
• C+ - 250 - @hoangzinh - paid via Upwork

Thanks everyone!

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj