Feature: Track expense training modal #40675

tienifr · 2024-04-22T07:25:26Z

Details

This PR creates a training interstitial when you click Track expense.

Fixed Issues

$ #40156
PROPOSAL: #40156 (comment)

Tests

Press FAB >> Track expense
Verify the training interstitial shows
Press Learn more
Verify user is navigated to HelpDot for Track
Press Got it
Verify user is navigated to Track expense page
Press Back button
Verify Track expense RHP dismisses
Press FAB >> Track expense
Verify the training interstitial shows again
Toggle Don't show me this again >> Press Got it
Verify SetNameValuePair API is called
Verify user is navigated to Track expense page
Dismiss Track expense page
Press FAB >> Track expense
Verify the training interstitial does not show, user is navigated directly to Track expense page instead

Verify that no errors appear in the JS console

Offline tests

Precondition: User has not togggled the Don't show me this again option.

Toggle offline mode
Press FAB >> Track expense
Verify the training interstitial does not show, user is navigated directly to Track expense page instead

QA Steps

Press FAB >> Track expense
Verify the training interstitial shows
Press Learn more
Verify user is navigated to HelpDot for Track
Press Got it
Verify user is navigated to Track expense page
Press Back button
Verify Track expense RHP dismisses
Press FAB >> Track expense
Verify the training interstitial shows again
Toggle Don't show me this again >> Press Got it
Verify user is navigated to Track expense page
Dismiss Track expense page
Press FAB >> Track expense
Verify the training interstitial does not show, user is navigated directly to Track expense page instead

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-04-22.at.15.57.07-compressed.mov

iOS: Native

Screen.Recording.2024-04-22.at.16.13.12-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-04-22.at.15.51.21-compressed.mov

MacOS: Chrome / Safari

Untitled.mov

Screen.Recording.2024-04-22.at.14.57.22-compressed.mov

MacOS: Desktop

Screen.Recording.2024-04-22.at.14.59.07-compressed.mov

srikarparsi · 2024-04-22T07:31:50Z

Hey @rushatgabhane, if you could take a look at this as soon as possible that would be great. We're looking to get this merged by Tuesday.

rushatgabhane · 2024-04-22T07:59:34Z

yes, this is # 1 priority

melvin-bot · 2024-04-22T08:58:37Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-04-22T09:19:19Z

Basically I just reused the onboarding welcome video component.

dubielzyk-expensify · 2024-04-22T09:20:07Z

Adding @Expensify/design here for review as well. We'll swap out the video once that's ready. As for the other parts of the UI, this looks good!

Basically I just reused the onboarding welcome video component.

Great move! I think we'd want the same behavior so that works for me. Keen to hear what @Expensify/design team thinks. Especially the centered modal on desktop.

shawnborton · 2024-04-22T12:59:48Z

For this screenshot here:

It seems like the padding and button spacing is off. I think there should only be 20px of inner padding in the content area, and I think the button stack might be too close together? It also feels like a lot of space above the checkbox.

@dubielzyk-expensify perhaps you can provide the exact desktop mock for this so we have the right guide here?

dannymcclain · 2024-04-22T13:17:55Z

Agree with Shawn, generally looking good but that button stack is pretty tight.

srikarparsi · 2024-04-22T21:57:38Z

Hi @tienifr, here is the URL for the Learn more button: https://use.expensify.com/track-expenses

dubielzyk-expensify · 2024-04-23T00:17:52Z

Here's the mobile and desktop mocks:

There should be 12px padding between the stacked buttons. Here's more detailed specs:

Also can we update the edge padding of the modal to be 20px

rushatgabhane · 2024-04-23T06:11:42Z

@tienifr could you please resolve merge conflicts

rushatgabhane

Looks good! Just a few minor comments

src/CONST.ts

src/components/FeatureTrainingModal.tsx

tienifr · 2024-04-23T07:39:11Z

@dubielzyk-expensify

Also can we update the edge padding of the modal to be 20px

Currently the horizontal padding for onboarding welcome video is 32px on desktop and 20px on mobile. Do you mean we need to make it consistently 20px? Or do we just apply 20px padding to this training interstitial only?

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>

….com/tienifr/App into feature/track-expense-training-modal

tienifr · 2024-04-24T08:57:09Z

Redundant padding removed:

tienifr · 2024-04-24T08:57:40Z

Awating last design decision:

Yes we only shows video time progress and volume control. Do you want to allow all controls?

rushatgabhane · 2024-04-24T08:58:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-24.at.15.07.24.mov

Android: mWeb Chrome

Screen.Recording.2024-04-24.at.15.13.28.mov

iOS: Native

Screen.Recording.2024-04-24.at.15.15.07.mov

Screen.Recording.2024-04-24.at.15.14.44.mov

iOS: mWeb Safari

Screen.Recording.2024-04-24.at.15.16.18.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-24.at.14.54.43.mov

Screen.Recording.2024-04-24.at.14.54.28.mov

MacOS: Desktop

Screen.Recording.2024-04-24.at.15.18.43.mov

rushatgabhane

LGTM!

shawnborton · 2024-04-24T11:42:36Z

I see a slight jump when the video first loads on desktop. You can see in this frame the video size is a bit different before it fully loads:

Then full size:

Can we fix that please?

shawnborton · 2024-04-24T11:43:08Z

The same thing is happening on iOS too:

dannymcclain · 2024-04-24T13:52:03Z

Yes we only shows video time progress and volume control. Do you want to allow all controls?

I'm curious for @Expensify/design's thoughts—but I don't see why we wouldn't allow all controls? Personally I'd rather them all be available, but I don't want to uproot a strategic decision if it was done for a specific purpose.

shawnborton · 2024-04-24T13:54:45Z

Same thoughts here, I would think all of those controls would be available to the user.

tienifr · 2024-04-24T19:53:31Z

I see a slight jump when the video first loads on desktop. You can see in this frame the video size is a bit different before it fully loads

#40675 (comment) @dubielzyk-expensify I wondered if we could make this track traning video and the onboarding video here consistent in aspect ratio (I just thought there should be consistency, shouldn't it??). They're 1560*1280 and 1280*960 respectively. Otherwise, I would need to manually change the code to specify the ratios. Also, I couldn't here the sound of the track training video? Is that expected?

tienifr · 2024-04-24T19:56:03Z

Same thoughts here, I would think all of those controls would be available to the user.

Added full controls to the video:

dubielzyk-expensify · 2024-04-25T01:33:07Z

So this Track video was created mostly for a different use case which is why the aspect ratio is different. I'd ideally want the dialog to load and scale to the video size. If not, I can look into resizing them, but might wanna do that in a follow-up PR cause that means me changing 4 other videos we've made as well.

tienifr · 2024-04-25T11:00:04Z

@dubielzyk-expensify Okay so I guess I should fix it now in this PR.

I see a slight jump when the video first loads on desktop. You can see in this frame the video size is a bit different before it fully loads

This is fixed now.

tienifr · 2024-04-25T11:00:22Z

@srikarparsi We're ready for your review.

srikarparsi · 2024-04-25T19:06:39Z

@tienifr lint looks to be failing. Can you run npm run lint and commit the changes?

tienifr · 2024-04-25T19:10:18Z

@srikarparsi Updated!

srikarparsi

lgtm thanks @tienifr and @rushatgabhane!

OSBotify · 2024-04-26T23:21:26Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.67-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-29T23:13:13Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-30T00:40:42Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hoangzinh · 2024-09-02T09:32:18Z

src/components/FeatureTrainingModal.tsx

+ onInputChange={toggleWillShowAgain}
+ />
+ )}
+ {helpText && (


Coming from #45619 (comment), we need to ensure that the left part of a conditional rendering a React component is a boolean and NOT a string

tienifr added 3 commits April 22, 2024 13:30

feature: track expense training modal

ade7fae

Merge branch 'main' into feature/track-expense-training-modal

d155d17

set hasseentracktraining

a395fdc

show tutorial video

a159bdd

tienifr marked this pull request as ready for review April 22, 2024 08:58

tienifr requested a review from a team as a code owner April 22, 2024 08:58

melvin-bot bot removed the request for review from a team April 22, 2024 08:58

melvin-bot bot requested a review from rushatgabhane April 22, 2024 08:58

tienifr mentioned this pull request Apr 22, 2024

[HOLD for payment 2024-05-06] CRITICAL: [Marketing] [$500] Create training interstitial when you click Track expense #40156

Closed

fix lint

848a475

dubielzyk-expensify requested a review from a team April 22, 2024 09:17

rushatgabhane suggested changes Apr 23, 2024

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

src/components/FeatureTrainingModal.tsx Show resolved Hide resolved

src/components/FeatureTrainingModal.tsx Outdated Show resolved Hide resolved

src/components/FeatureTrainingModal.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into feature/track-expense-training-modal

98e7f2f

tienifr and others added 6 commits April 23, 2024 15:07

toggle modal on top of track page

e3399e3

update modal padding

46029d0

Modify comment

d73ddb3

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>

update help link

065926b

Merge branch 'feature/track-expense-training-modal' of https://github…

c20cd51

….com/tienifr/App into feature/track-expense-training-modal

update copy

d827d7b

modify padding

06ba57b

rushatgabhane approved these changes Apr 24, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi April 24, 2024 09:50

Merge branch 'main' into feature/track-expense-training-modal

d2ddcab

fix video flickering on load

faa2239

fix lint

bbb3289

srikarparsi approved these changes Apr 25, 2024

View reviewed changes

srikarparsi merged commit 1276b1d into Expensify:main Apr 25, 2024
15 checks passed

github-actions bot mentioned this pull request Apr 26, 2024

Deploy Checklist: New Expensify 2024-04-26 #41122

Closed

63 tasks

m-natarajan mentioned this pull request Apr 27, 2024

[$250] Track expense- Unable to close Track expense RHP with ESC key after dismissing education modal #41134

Closed

6 tasks

thienlnam mentioned this pull request Apr 28, 2024

[HOLD for payment 2024-05-08] [HOLD for payment 2024-05-06] [$250] Track expense - Education video is displayed in public room when viewed anonymously #41148

Closed

6 tasks

hoangzinh reviewed Sep 2, 2024

View reviewed changes

hoangzinh mentioned this pull request Sep 2, 2024

[$250] DEV: Investigate the console errors that show up after signing in #45619

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Track expense training modal #40675

Feature: Track expense training modal #40675

tienifr commented Apr 22, 2024 •

edited

Loading

srikarparsi commented Apr 22, 2024

rushatgabhane commented Apr 22, 2024

melvin-bot bot commented Apr 22, 2024

tienifr commented Apr 22, 2024

dubielzyk-expensify commented Apr 22, 2024 •

edited

Loading

shawnborton commented Apr 22, 2024

dannymcclain commented Apr 22, 2024

srikarparsi commented Apr 22, 2024

dubielzyk-expensify commented Apr 23, 2024

rushatgabhane commented Apr 23, 2024

rushatgabhane left a comment

tienifr commented Apr 23, 2024 •

edited

Loading

tienifr commented Apr 24, 2024

tienifr commented Apr 24, 2024

rushatgabhane commented Apr 24, 2024 •

edited

Loading

rushatgabhane left a comment

shawnborton commented Apr 24, 2024

shawnborton commented Apr 24, 2024

dannymcclain commented Apr 24, 2024

shawnborton commented Apr 24, 2024

tienifr commented Apr 24, 2024 •

edited

Loading

tienifr commented Apr 24, 2024 •

edited

Loading

dubielzyk-expensify commented Apr 25, 2024

tienifr commented Apr 25, 2024 •

edited

Loading

tienifr commented Apr 25, 2024

srikarparsi commented Apr 25, 2024

tienifr commented Apr 25, 2024

srikarparsi left a comment

OSBotify commented Apr 26, 2024

OSBotify commented Apr 29, 2024

OSBotify commented Apr 30, 2024

hoangzinh Sep 2, 2024

Feature: Track expense training modal #40675

Feature: Track expense training modal #40675

Conversation

tienifr commented Apr 22, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

srikarparsi commented Apr 22, 2024

rushatgabhane commented Apr 22, 2024

melvin-bot bot commented Apr 22, 2024

tienifr commented Apr 22, 2024

dubielzyk-expensify commented Apr 22, 2024 • edited Loading

shawnborton commented Apr 22, 2024

dannymcclain commented Apr 22, 2024

srikarparsi commented Apr 22, 2024

dubielzyk-expensify commented Apr 23, 2024

rushatgabhane commented Apr 23, 2024

rushatgabhane left a comment

Choose a reason for hiding this comment

tienifr commented Apr 23, 2024 • edited Loading

tienifr commented Apr 24, 2024

tienifr commented Apr 24, 2024

rushatgabhane commented Apr 24, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

shawnborton commented Apr 24, 2024

shawnborton commented Apr 24, 2024

dannymcclain commented Apr 24, 2024

shawnborton commented Apr 24, 2024

tienifr commented Apr 24, 2024 • edited Loading

tienifr commented Apr 24, 2024 • edited Loading

dubielzyk-expensify commented Apr 25, 2024

tienifr commented Apr 25, 2024 • edited Loading

tienifr commented Apr 25, 2024

srikarparsi commented Apr 25, 2024

tienifr commented Apr 25, 2024

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 26, 2024

OSBotify commented Apr 29, 2024

OSBotify commented Apr 30, 2024

hoangzinh Sep 2, 2024

Choose a reason for hiding this comment

tienifr commented Apr 22, 2024 •

edited

Loading

dubielzyk-expensify commented Apr 22, 2024 •

edited

Loading

tienifr commented Apr 23, 2024 •

edited

Loading

rushatgabhane commented Apr 24, 2024 •

edited

Loading

tienifr commented Apr 24, 2024 •

edited

Loading

tienifr commented Apr 24, 2024 •

edited

Loading

tienifr commented Apr 25, 2024 •

edited

Loading