-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-06] CRITICAL: [Marketing] [$500] Create training interstitial when you click Track expense
#40156
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01978ee6c0535caae9 |
Track expense
Track expense
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Create training interstitial when you click Track expense What is the root cause of that problem?This is a new feature. What changes do you think we should make in order to solve the problem?I can work on this feature following description in OP. What alternative solutions did you explore? (Optional)NA |
ProposalPlease re-state the problem that we are trying to solve in this issue.Create training interstitial when you click What is the root cause of that problem?This is a new feature What changes do you think we should make in order to solve the problem?
This reusable component can be used whenever we want to educate the user about a new feature in the future, we can just pass the correct 4 params to What alternative solutions did you explore? (Optional)NA |
🎀 👀 🎀 Let's assign @tienifr to implement this feature |
Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@yuwenmemon is OOO until 16th, so I've asked someone else to assign themselves to this urgent issue https://expensify.slack.com/archives/C02NK2DQWUX/p1712996505924539 |
Taking this over @yuwenmemon |
@tienifr's proposal looks good to me as well. Assigning |
📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Track expense
Track expense
cc @Expensify/design Please send me the tutorial animation/video for this screen. Thanks! |
Hey @tienifr, for this point in your proposal:
I created an NVP called HAS_SEEN_TRACK_TRAINING = "hasSeenTrackTraining" in the backend that you can set using SET_NAME_VALUE_PAIR in the frontend. Similar to how it is done here. We also want to set this NVP whenever |
@srikarparsi Got it! @shawnborton Could you kindly check #40156 (comment)? |
cc @dubielzyk-expensify since I believe you were working on the video. |
I'll add myself here so I can help with PRs and I'll upload the video when it's done. It's posted to TCW here |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-06. 🎊 For reference, here are some details about the assignees on this issue:
|
Hi @rushatgabhane and @tienifr, this PR introduced this bug which we fixed with a 300ms timeout. I'm still not sure if this is the best way to do this so I wanted to ask if you guys had any other ideas. |
@srikarparsi please attach payment summary for this issue 🙇 |
Triggered auto assignment to @muttmuure ( |
Hey @rushatgabhane! Since this was a pretty big PR and it only caused one small regression, we can pay $250 for you and @tienifr each without the deduction. It would be great though if you could take a look at this comment and check if there’s a better approach for fixing this regression. More information about the fix is here and we’re essentially looking for a good way to queue the next animation once the previous animation is complete. |
Waiting for BZ checklist to be complete before approving payment, based on @srikarparsi's comment above. |
This is a new feature, so I'll propose regression steps only
|
@srikarparsi no, i don't know a better way yet. I spent time on this yesterday, but couldn't find much |
Ok sounds good, @tienifr did you have a chance to look? The current solution is okay for me since we do the same thing in other places but just want to check. If not, I believe we can proceed with payment @muttmuure since the regression steps look good to me. |
Hi @srikarparsi I tried to find a solution for the last 2 days but still had no better idea. Also given that it has been used in other places, I think it should be fine. If we want to find a more general approach to solve all these cases, we should open a separate issue for that. |
Cool sounds good! I think this solution should work fine as well then. @muttmuure do you think you could help with payment or is there anything else that needs to be done? The regression steps here look good to me. |
Still waiting for a payment summary so I can approve. |
Any updates here? |
I flagged with Matt Moore via DM but he's OOO until Monday |
@muttmuure @JmillsExpensify According to this announcement, this issue is marked as Thanks!
|
I don't see the |
In any case, @muttmuure I need a summary on this issue when you're back from OOO. |
@JmillsExpensify I think the label was just missed out, like it was missed out and later applied here and here. In #40208 (comment) an issue with |
Going to give the benefit of the doubt that this is at least a HIGH issue, since it has CRITICAL status in the project @rushatgabhane - C+ $500 |
Track expense
Track expense
Upwork job price has been updated to $500 |
$500 approved for @rushatgabhane |
Problem:
We are about to promote
Track expense
to 10MM+ existing users, most of whom have never used NewDot. If we are lucky, they will see our marketing message and click through to check it out. It's unlikely they have an actual expense to track at that moment, so it's more likely they are going to just sorta click around to see what's available. Some unknown number of users will intuitively figure out our UI. However, some number of users won't find it intuitive by itself, and will abandon the product.Note: We are working on Stage 2 onboarding. However, it doesn't exist today. Additionally, even if it did, it only targets new signups -- not historical signups. Furthermore, it only educates a single use case.
Solution:
Show "inline/on-demand training" the first time you use the
Track expense
, to:It would work like this:
The components are:
dismissedTrackTraining=1
in Onyx locally)Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: