[HOLD for payment 2024-05-08] [HOLD for payment 2024-05-06] [$250] Track expense - Education video is displayed in public room when viewed anonymously

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Log out if logged in.
3. Navigate to public room anonymously (https://staging.new.expensify.com/r/2376199970894587).
4. Go to FAB.
5. Click Track expense.
6. Click Got it.

Expected Result:

The RHP should not be distorted

Actual Result:

After dismissing the modal, the RHP is distorted

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6463788_1714232319574.20240427_233506.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01737d06f4b632dcb2
• Upwork Job ID: 1785022453427478528
• Last Price Increase: 2024-04-29

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #vip-vsb

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

1. Track expense education modal is displayed for anonymous users visiting the public room.
2. After dismissing the modal, the RHP is distorted.

What is the root cause of that problem?

We do not check for anonymous user before opening educational modal:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Lines 325 to 327 in 05fd715

	if (!hasSeenTrackTraining && !isOffline) {
	Navigation.navigate(ROUTES.TRACK_TRAINING_MODAL);
	}

What changes do you think we should make in order to solve the problem?

Put the educational modal navigation inside interceptAnonymousUser's callback above.

Fixing 1 will fix 2.

What alternative solutions did you explore? (Optional)

NA

[thienlnam]

I don't think the issue is with showing the educational video, but why is the RHP distorted after dismissing the video. Could we address that issue?

[thienlnam]

This also was added in #40675
cc @tienifr @rushatgabhane @srikarparsi

[francoisl]

@tienifr any idea on this one?
Using the other options in the LHN like "Start Chat" or "Submit Expense" opens the sign-in RHP correctly, so I feel like it's really the modal with the video that makes it look distorted.

[srikarparsi]

cc @rushatgabhane as well

[srikarparsi]

Adding the external label since @rushatgabhane @tienifr seem to be offline.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01737d06f4b632dcb2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[allgandalf]

Loll, I thought this was going to be external for us to work on😆

[srikarparsi]

Yeahh, I made it external to see if there's a better way to check once the animation is done instead of the setTimeout. I just deployed this fix right now since the deploy blocker is time sensitive but I still think we could explore a better way to do it since sometimes rendering the animation will take longer. I might keep this issue for @rushatgabhane and @tienifr to chime in as well since they were the original authors but I'll circle back on that.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Add 300ms timeout between RHP and Training Video #41244

If no regressions arise, payment will be issued on 2024-05-06. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@srikarparsi] The PR that introduced the bug has been identified. Link to the PR:
• [@srikarparsi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@srikarparsi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@srikarparsi] Determine if we should create a regression test for this bug.
• [@srikarparsi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[srikarparsi]

Adding @allroundexperts for reviewing the PR

[srikarparsi]

@tienifr and @rushatgabhane, we merged this fix here but not sure if this is the best way to go about it. Do you guys have any other ideas that are more dependent on render/animation time rather than a constant timeout?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Add 300ms timeout between RHP and Training Video #41244

If no regressions arise, payment will be issued on 2024-05-08. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot

BugZero Checklist (@kevinksullivan)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1785022453427478528/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[kevinksullivan]

Payment summary all set for @allroundexperts . Can you finish out the steps above and then I'll close this? Thanks!

[kevinksullivan]

Waiting on @allroundexperts for the steps above

[srikarparsi]

^ (Trying to remove the overdue label)

[allroundexperts]

I don't think if a checklist is needed here. This was a bug with no definite root cause and as such, we just used a timeout to solve it. A regression test would be an overkill here as well.

[kevinksullivan]

Payment summary:

• C+: @allroundexperts $250

[JmillsExpensify]

$250 approved for @allroundexperts