[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Dupe Detection] Merge Duplicates - Review Fields Page

[pecanoro]

Part of the project

Main issue: https://github.com/Expensify/Expensify/issues/307591
Doc section: Surfacing Potential Duplicates
Project: [Wave: Collect Approvers] Dupe Detection

Part of a series of issues:

• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [Dupe Detection] Merge Duplicates - Review Page #39756
• [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Dupe Detection] Merge Duplicates - Review Fields Page #39808
• [Hold for payment 2024-07-31] [Dupe Detection] Merge Duplicates - Confirm Page #39810

Feature Description

Context for ReviewDuplicates

• Review page - /r/:threadReportID/duplicates/review
• Merchant - /r/:threadReportID/duplicates/review/merchant
• Category - /r/:threadReportID/duplicates/review/category
• Tag - /r/:threadReportID/duplicates/review/tag
• Description - /r/:threadReportID/duplicates/review/description
• Confirm page - /r/:threadReportID/duplicates/confirm

All of these screens will exist in their own navigator so they can be pushed (and later popped off once complete) as a group.

All of this will use an Onyx form key of ONYXKEYS.FORMS.REVIEW_DUPLICATES_FORM so we can store the data selected by the user so far when resolving the duplicates. It also lets us keep track of which transaction to keep and which ones are duplicates when the user clicks on Keep this one.

This key will follow a structure like this:

{
  "review_duplicates_form_<transactionID>": [
    {
        "duplicates": {
<transactionID>: <transactionID>,
	...
  },
        "merchant": "...",
        "tag": ...",
	  "description": ...",
			…
    }
  ]
}

Review Fields Page

It will make use of the new InteractiveStepSubHeader to show the progress in which step we are currently in. As a reminder this component:

• Receive an array of navigation names, the position will match where it should go when the current step is completed
• Completed steps will be counted based on the length of the navigation names array

For each of the pages to resolve category, merchant, etc, will have a Title element and a SelectionList element to display the different options.

• To display the options, we stored the duplicates in ONYXKEYS.FORMS.REVIEW_DUPLICATES_FORM at the beginning of the flow so we can search for the transaction data to display the corresponding fields.
• onSelectRow we store the selected field in the Onyx key and move to the next field until we have gone through all of them.

Manual Test Steps

TODO

Automated Tests

TODO

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[pecanoro]

Callstack will be taking this series of tasks

[kubabutkiewicz]

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

[kubabutkiewicz]

Hi, just wanted to inform that I will be OOO from 29.04 to 05.05.

[pecanoro]

In progress!

[pecanoro]

In progress!

[pecanoro]

WIP!

[parasharrajat]

Yes, It didn't. Thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat/Dupe detection review fields #42503

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @kubabutkiewicz does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat/Dupe detection review fields #42503

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @kubabutkiewicz does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $250 via NewDot
• Contributor: @kubabutkiewicz is from an agency-contributor and not due payment

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[bfitzexpensify]

Payment summary is correct:

@parasharrajat owed $250 via manual request

[pecanoro]

@bfitzexpensify When do we close the issue when it's via manual request?

[bfitzexpensify]

Once BZ checklist is complete - or, if we don't need that, then this is ready to close now

[parasharrajat]

Regression Test Steps

The following steps require you to be in the dupeDetection beta or use a expensifail email.

1. Create some expanses which are duplicates
2. Go to one of expenses which are duplicates and click Review duplicates button
3. Next click on one of the Keep this one button
4. Now if there are some discrepancies between expenses you should be navigated to screen to review those discrepancies
5. When there are no discrepancies you wont be navigated further.

Do you agree 👍 or 👎 ?

[bfitzexpensify]

Sounds good to me - proposed those steps be added via https://github.com/Expensify/Expensify/issues/414629.

[parasharrajat]

Payment requested as per #39808 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat