[HOLD for payment 2024-04-25] Attachment - Wrong PDF is opened

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to any report
2. Send two pdf files
3. Open the last one

Expected Result:

The last pdf file should be opened

Actual Result:

The first pdf file is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442231_1712580406073.Screen_Recording_2024-04-08_at_3.44.37_in_the_afternoon.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@amyevans FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[amyevans]

I verified by reverting #39578 locally that it's the source of the regression cc @abzokhattab @hungvu193 @flodnv.

Since the package bump PR is tied to a rather non-urgent bug fix I think it makes the most sense to just revert the bump PR, but speak up soon if you disagree.

[amyevans]

PR has been merged but waiting on CP: https://expensify.slack.com/archives/C07J32337/p1712628550724549

[hungvu193]

Hey @amyevans I can reproduce even when I downgrade react-fast-pdf to 1.0.6

[hungvu193]

Screen.Recording.2024-04-09.at.09.14.09.mov

[amyevans]

Can you verify the version is "version": "1.0.6", within /node_modules/react-fast-pdf/package.json? You'd likely need to delete your node_modules folder and run npm ci to get it to "downgrade" to 1.0.6

[abzokhattab]

For your information, there is an open issue related to the problem where the wrong file is viewed, which can be found at #23546 This may be related to the current issue.

[hungvu193]

Can you verify the version is "version": "1.0.6", within /node_modules/react-fast-pdf/package.json? You'd likely need to delete your node_modules folder and run npm ci to get it to "downgrade" to 1.0.6

@amyevans I see, seems like caching. Confirmed it's fixed with 1.0.6. My bad 🤦

[amyevans]

No worries!

[kidroca]

I confirm this seems to be related to #23546 and the version bump can be a coincidence
The wrong attachment bug manifests with all attachment types, you just need to scroll a bit to the past in the conversation in order to pre-fill the local database with comments with attachments

[hungvu193]

I confirm this seems to be related to #23546 and the version bump can be a coincidence The wrong attachment bug manifests with all attachment types, you just need to scroll a bit to the past in the conversation in order to pre-fill the local database with comments with attachments

@kidroca I saw you were assigned on that issue, do you have any WIP? So I can test if it solved this issue as well 😄

[kidroca]

@kidroca I saw you were assigned on that issue, do you have any WIP? So I can test if it solved this issue as well 😄

@hungvu193 here's my WIP:

• Enhance Carousel Scrolling and Interaction in AttachmentCarousel #39930

[hungvu193]

@kidroca I saw you were assigned on that issue, do you have any WIP? So I can test if it solved this issue as well 😄

@hungvu193 here's my WIP:

• Enhance Carousel Scrolling and Interaction in AttachmentCarousel #39930

Awesome! I'll give it a try. Thank you 🙏

[amyevans]

Testing on:

This branch + react-fast-pdf 1.0.8:

pr-39930-and-1-0-8.mov

The behavior is inconsistent, but it usually seems to do what's in the recording: briefly flashes the wrong attachment before loading the correct (most recent) one.

main + react-fast-pdf 1.0.6:

main-and-1-0-6.mov

Bug is not reproducible.

main + react-fast-pdf 1.0.7:

main-and-1-0-7.mov

Bug is reproducible.

While perhaps the root cause might be similar to what's being worked on in #39930, I don't think it is coincidental that the bug manifests on 1.0.7 but not on 1.0.6, so I still think proceeding with the revert is the right course of action. Do you all agree or disagree? Cc @Julesssss as well as deployer this week

[amyevans]

Alright I retested on staging following the CP: #39869 (comment). I think we can close this one out, thanks for the discussion!

[kidroca]

Should we open and track an issue for react-fast-pdf or maybe have a note that the library shouldn't be updated since a bug manifests in more recent versions?

[amyevans]

Yes, I believe they're working on a patch in the original issue but I left a note (#34816 (comment)) to clarify expectations.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Bump react-fast-pdf" #39869

If no regressions arise, payment will be issued on 2024-04-25. 🎊