[hold for payment 2024-05-29][$250] Request money - Request Money Preview Displayed in IOU Notification Thread When Offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): abebemiherat@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Open FAB and select "Request money"
2. Enter amount, select "Split with," add merchant, and confirm request
3. Navigate to IOU and change the date to trigger a notification
4. Go offline and attempt to reply to the notification. Notice that the preview of the request money is displayed in the IOU notification thread.

Expected Result:

The preview of the request money should not be shown in the IOU notification thread when accessing it offline

Actual Result:

The preview of the request money is displayed in the IOU notification thread when accessed offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442221_1712579952073.IOU_threads.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa16c917d47610e5
• Upwork Job ID: 1778076134347853824
• Last Price Increase: 2024-04-17
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is a report preview in a thread. This also happens when for a normal message that you sent and no need to go offline.

What is the root cause of that problem?

For a thread, we show all parent report actions with the "Thread" divider line.

App/src/pages/home/report/ReportActionItemParentAction.tsx

Line 70 in b0c4178

setAllAncestors(ReportUtils.getAllAncestorReportActions(report));

If we click on a report preview, it opens an expense/IOU report and if we send a message and create a thread from it, that means the parent report action of that thread is the thread message and the report preview.

chat report - report preview (parent action)
-> expense report - message (parent action)
---> thread (we are here)

This doesn't happen if you create a thread from a transaction thread.

chat report - report preview (parent action)
-> expense report - message (parent action)
---> transaction thread (parent action)
-----> thread (we are here)

Because if it's a transaction thread, we stop taking the parent actions.

App/src/libs/ReportUtils.ts

Lines 5560 to 5562 in b0c4178

	if (!parentReportAction || ReportActionsUtils.isTransactionThread(parentReportAction) || !parentReport) {
	break;
	}

But we don't do that for report preview.

What changes do you think we should make in order to solve the problem?

Don't include report preview action by checking it in here.

App/src/libs/ReportUtils.ts

Lines 5560 to 5562 in b0c4178

	if (!parentReportAction || ReportActionsUtils.isTransactionThread(parentReportAction) || !parentReport) {
	break;
	}

App/src/libs/ReportUtils.ts

Lines 5599 to 5601 in b0c4178

	if (!parentReportAction || (!includeTransactionThread && ReportActionsUtils.isTransactionThread(parentReportAction)) || !parentReport) {
	break;
	}

ReportActionsUtils.isTransactionThread(parentReportAction) || ReportActionsUtils.isReportPreviewAction(parentReportAction)

[joekaufmanexpensify]

Going to triage tomorrow morning

[joekaufmanexpensify]

Yeah, this def seems like a bug to me. Agreed it happens while online too. If I do this, I also can't access the expense after I try and create a thread on the date change request comment. I just see the skeleton UI in place of the expense.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aa16c917d47610e5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[abdulrahuman5196]

Checking now.

[abdulrahuman5196]

@joekaufmanexpensify Apart from the issues mentioned in OP, there are other issues here.

1. Request money preview is displayed
2. Another dummy thread parent is shown
3. After creating a thread from the date notification, I am unable to go its thread again.

@bernhardoj 's proposal solves the first one, which is also the OP mentioned issue. What should we do for other issues, should we take that separately? Or as part of this?

Screen.Recording.2024-04-13.at.12.22.23.AM.mov

[bernhardoj]

The other issues are being handled separately here: #39861

[joekaufmanexpensify]

Cool cool. @abdulrahuman5196 do you agree the other parts will be handled in that other issue?

[joekaufmanexpensify]

Pending further update

[joekaufmanexpensify]

bump @abdulrahuman5196 for when you have a sec

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[joekaufmanexpensify]

@abdulrahuman5196 could you please take a look at this?

[joekaufmanexpensify]

Bumped in Slack

[abdulrahuman5196]

Checking now

[abdulrahuman5196]

The other issues are being handled separately here: #39861

Agree on this. Seems other issues are handled separately.

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[joekaufmanexpensify]

waiting for sign off on proposal

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[joekaufmanexpensify]

@bernhardoj is there an ETA for PR here?

[bernhardoj]

PR is ready

cc: @abdulrahuman5196

[joekaufmanexpensify]

amazing. TY!

[joekaufmanexpensify]

@abdulrahuman5196 are you able to prioritize this review?

[abdulrahuman5196]

Working on review

[joekaufmanexpensify]

Still pending review from @abdulrahuman5196

[joekaufmanexpensify]

PR on staging

[joekaufmanexpensify]

Automation not working here. Payment is due tomorrow

[joekaufmanexpensify]

We need to pay:

• @bernhardoj $250 for PR via Upwork.
• @abdulrahuman5196 $250 for C+ via upwork.

[joekaufmanexpensify]

All set to issue payment tomorrow!

[joekaufmanexpensify]

@bernhardoj $250 sent and contract ended!

[joekaufmanexpensify]

@abdulrahuman5196 $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set, thanks everyone!