-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Desktop - App redirection when logged in with different accounts causes desktop logout #39851
Comments
Triggered auto assignment to @marcaaron ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Issue is not reproducible in production Bug6442506_1712593188805.PROD_-_NOT_REPRO_-__v1.4.60-13.mp4 |
It might be related to the onyx bump, I have seen issues like this related to onyx changes in the past. I do think however that this does not have to be a blocker since its very rare flow of having web and desktop and 3 accounts. I suggest removing the DB label and marking this as External to get contirbutors look into this. @marcaaron @Julesssss thoughts? |
Since this is related to signing in with multiple accounts (edge case for most people) going to remove the blocker label. |
Job added to Upwork: https://www.upwork.com/jobs/~01f7298781dc451347 |
Triggered auto assignment to @mallenexpensify ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 ( |
@marcaaron Testers have also encountered issues with signing in via Google and Apple in the Desktop app. Directly.redirection.mov |
That looks related to the deep-link redirection. Is this only happening for users on multiple accounts/clients? Because if so I think that also doesn't need to be a blocker. |
Upwork job price has been updated to $500 |
Bumping the price to 500 to get more eyes in, the google sign in does not look good |
Still looking for proposals 👀 |
Thanks vit. Unable to reproduce when navigating from staging.new.expensify.com in Chrome to Staging desktop. Adding |
@hungvu193 @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Still holding on retest and... there's another web>desktop issue, think it's the one below |
Issue not reproducible during KI retests. (First week) |
Also wasn't able to reproduce so I'm closing. If you try/test and are able to @hungvu193 , please comment and I'll reopen. (it did forever-load though, which isn't ideal. Not seeing errors in the console, network tab screenshot below) |
Yeah I can't seem to reproduce this one as well |
Can we close it then? |
Yeah, I think we can close. Comment/reopen if you disagree or if you're able to reliably reproduce. |
Issue is still reproducible on the latest build 1.4.77-0 desktop.logout.mp4 |
I still can't reproduce. Screen.Recording.2024-05-30.at.09.27.16.movAlso there was some issues with desktop login, that was fixed (I think that's why this issue was reproduced). |
ooooof. I have a hunch this has to do with a bug that got fixed yesterday where users were getting signed out. Gonna leave retest-weekly on here to see if this persists next week (cuz the PR was 🍒 picked yesterday) |
Issue not reproducible during KI retests. (Second week) |
Closing since it's not reproducible. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4481895
Issue reported by: Applause - Internal Team
Action Performed:
Prerequisites: The user is logged out in the browser and clears the cache before starting the steps.
Desktop app: Logged out
Expected Result:
User profile page for account A is displayed in the desktop app
Actual Result:
App redirection when logged in with different accounts causes desktop logout.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6442506_1712592956862.Desktop_app_gets_logged_out.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: