[HOLD for payment 2024-05-06] [$250][Search v1] Add ReportScreen to RHP

[luacmartins]

Section from design doc

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017622f24b31111163
• Upwork Job ID: 1780987474836803584
• Last Price Increase: 2024-04-18

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[WojtekBoman]

Hi! I'm going to work on that :)

[melvin-bot]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017622f24b31111163

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[WojtekBoman]

@luacmartins
I'd like to confirm that this is the expected behaviour when we open a thread from ReportScreen in RHP:

Screen.Recording.2024-04-19.at.12.29.36.mov

[luacmartins]

I'd love @Expensify/design opinion on whether other links clicked in the RHP ReportScreen should also open in the RHP, but I'd say let's ship the MVP the way you have it and polish this later, since this is probably not trivial and would require a decent amount of work to be implemented.

[shawnborton]

I'd say we should bring this discussion to Slack, but I love the idea of us opening up search results in the RHP. I could see us later adding in some way to like "expand" the view into the main pane (which would just take you to the Inbox/Chats page).

[luacmartins]

@shawnborton clicking on a search result row will open the result in the RHP as described in the HL design doc for Search. Now the question is if we wanna keep any navigation that happens in the RHP contained in the RHP, e.g. should clicking on a link to a task open the task in the RHP or main pane?

[shawnborton]

Ah, got it. Hmm, good question... I kind of think you'd be able to keep using the app within the RHP itself. Like let's say you open a report from Search in the RHP. Maybe you then want to open up one of the expenses, and then even edit one of the expenses. So part of me thinks we'd just let you stay in the RHP as long as you'd like?

Curious for what @Expensify/design @trjExpensify @JmillsExpensify thinks though.

[dannymcclain]

Yeah I agree with Shawn—I think we should keep it in the RHP. To me, the reason why is basically about maintaining your context on the search page. Say I'm going down a list of reports/expenses I need to deal with, I find one that I want to go into to make a couple changes or leave a few comments, but when I'm done with that one I want to continue going down my list the search page.

We're also talking about including some way to "expand" or "navigate to the original" for all these items that are opened in the RHP. So if we had that for every chat/report/task/etc that was opened in the RHP, you'd always have an easy way to go to the "full" version of the thing you're looking at.

[luacmartins]

@WojtekBoman I suspect that keeping every link in the RHP context will involve quite a few changes to the navigation logic, so I suggest we break this down into a separate issue and tackle it once the basic search page is in place.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Search v1] Add ReportScreen to RHP #40570

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)
• @WojtekBoman does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[adelekennedy]

@hoangzinh sorry for the delay! I sent you an offer on Upwork!

[adelekennedy]

Payouts due:

• Contributor: $250 @hoangzinh

Upwork job is here.

[hoangzinh]

Accepted. Thanks @adelekennedy

[adelekennedy]

Done!