[Search v1] Add ReportScreen to RHP #40570

WojtekBoman · 2024-04-19T13:53:59Z

Details

This PR adds a possibility to open ReportScreen in RHP. It's a new functionality available in the new search tab. Currently it's available only from via link in format: /search/:query/view/:reportID.

Fixed Issues

$ #39883
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Log in to New Expensify
Open any report.
Modify link in your browser: /r/:id => search/all/view/:id (to test this page on mobile platforms, copy the modified link and paste it in any report, then click on the link).
Verify that ReportScreen displayed in RHP works fine.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-04-23.at.18.26.15.mov

MacOS: Desktop

Screen.Recording.2024-04-23.at.18.42.00.mov

Kicu

Looks good 👍 it's actually less code than I expected.

I tested locally but clicking through 2-3 chat reports and money reports and it seems to work well.
I left you some rename comments which I think will help to make the code more clear

Kicu · 2024-04-23T07:12:27Z

src/styles/index.ts

 ({
- horizontal: 18 + variables.sideBarWidth,
+ horizontal: shouldUseNarrowLayout ? windowWidth - (variables.sideBarWidth - 18) : 18 + variables.sideBarWidth,


do you mind extracting windowWidth - (variables.sideBarWidth - 18) to a separate variable to give it a meaningful name? To me it's not obvious why this is counted differently for shouldUseNarrowLayout

Kicu · 2024-04-23T07:25:16Z

src/components/MoneyReportHeader.tsx

@@ -185,7 +197,7 @@ function MoneyReportHeader({session, policy, chatReport, nextStep, report: money
 shouldShowPinButton={false}
 report={moneyRequestReport}
 policy={policy}
- shouldShowBackButton={isSmallScreenWidth}
+ shouldShowBackButton={shouldUseNarrowLayout || isSmallScreenWidth}


I understand that in general the name shouldUseNarrowLayout is fitting, but I wanted to suggest a change.

When I look at this line it's clear to me that isNarrowLayout would be a better name.
In here, right next to each other we have shouldXXX || isYYY but both refer to the context of the screen/container and its sizing.
So I think if we're passing down layout related flags the names with isXXX are better and simpler.

Kicu · 2024-04-23T07:36:17Z

src/pages/home/HeaderView.tsx

@@ -334,8 +348,10 @@ function HeaderView({report, personalDetails, parentReport, parentReportAction,
 )}
 </PressableWithoutFeedback>
 <View style={[styles.reportOptions, styles.flexRow, styles.alignItemsCenter]}>
- {isTaskReport && !isSmallScreenWidth && ReportUtils.isOpenTaskReport(report, parentReportAction) && <TaskHeaderActionButton report={report} />}
- {canJoin && !isSmallScreenWidth && joinButton}
+ {isTaskReport && !(isSmallScreenWidth || shouldUseNarrowLayout) && ReportUtils.isOpenTaskReport(report, parentReportAction) && (


these inline checks are so long and so convoluted. Please extract to separate variable before the return, so that JSX stays cleaner

Kicu

Hey lookes even better now, good job 👍
I left some small comments but Im approving as I don't see anything blocking.
You can fix those later

Kicu · 2024-04-23T10:54:40Z

src/hooks/useIsNarrowLayout.ts

+import useWindowDimensions from './useWindowDimensions';
+
+// This hook checks whether narrow layout styles should be applied to the screen.
+// SCREENS.SEARCH.REPORT is the screen displaying the chat in RHP, this page should be styled like a page displayed on a small screen.


super nitpicky but this style of comment is nicer for long comments 😅

/** ......... */

Kicu · 2024-04-23T10:55:34Z

src/pages/home/ReportScreen.tsx

@@ -159,6 +160,10 @@ function ReportScreen({
 const flatListRef = useRef<FlatList>(null);
 const reactionListRef = useRef<ReactionListRef>(null);
 const {isOffline} = useNetwork();
+ const activeRoute = useNavigationState(getTopmostRouteName);
+ const isReportOpenedInRHP = activeRoute === SCREENS.SEARCH.REPORT;
+ const isNarrowLayout = isSmallScreenWidth || isReportOpenedInRHP;


shouldn't this use the hook?

Here I decided to extract the logic from the hook, because one condition below relies on isReportOpenedInRHP variable

adamgrzybowski · 2024-04-23T11:49:13Z

src/SCREENS.ts

@@ -25,6 +25,7 @@ const SCREENS = {
 WORKSPACES_CENTRAL_PANE: 'WorkspacesCentralPane',
 SEARCH: {
 CENTRAL_PANE: 'Search_Central_Pane',
+ REPORT: 'Search_Report',


'Search_Report' value is used two times here

adamgrzybowski · 2024-04-23T12:51:52Z

src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

@@ -195,6 +195,10 @@ function getAdaptedState(state: PartialState<NavigationState<RootStackParamList>
 if (matchingRootRoute?.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) {
 routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES}));
 }
+ if (matchingRootRoute?.state?.routes[0]?.name === SCREENS.SEARCH.CENTRAL_PANE) {
+ const centralPaneRoute = matchingRootRoute?.state?.routes[0];


Maybe the logic responsible for excluding params for this screen should be in the getMatchingCentralPaneRouteForState? Instead of removing params we would simply not include them in the first place

melvin-bot · 2024-04-23T16:42:45Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

Looking good overall. Noticed a few bugs while testing, since this is not used in App yet, we don't need to block on them, but it's something we'll need to address once we implement the navigation to this screen

Bug 1: Navigation is not contained in the RHP

bug1.mov

bug4.mov

Bug 2: Back button on not found screen doesn't navigate back

bug2.mov

Bug 3: Back navigation returns to RHP report. Backing up twice leads to an incorrect route

bug3.mov

@WojtekBoman let me know if you wanna address those as part of this PR or in a follow up.

github-actions · 2024-04-23T19:07:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40570/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40570/NewExpensify.dmg	https://40570.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

WojtekBoman · 2024-04-24T15:46:35Z

Looking good overall. Noticed a few bugs while testing, since this is not used in App yet, we don't need to block on them, but it's something we'll need to address once we implement the navigation to this screen

Bug 1: Navigation is not contained in the RHP

bug1.mov
bug4.mov
Bug 2: Back button on not found screen doesn't navigate back

bug2.mov
Bug 3: Back navigation returns to RHP report. Backing up twice leads to an incorrect route

bug3.mov
@WojtekBoman let me know if you wanna address those as part of this PR or in a follow up.

I believe bugs related to navigating back can be addressed as follow-ups. However we'd like to discuss the problem of nested navigation in ReportScreen displayed in RHP (bug no.1).

Please note that currently there is a multitude of things that can be accessed and clicked from within Report Screen. You can click a mention, room, any link, IOUs, images etc.

If we now want to make all this navigation behavior to also works from inside RHP then this is a bigger task. It will require making sure every navigation action makes sense to stay within the RHP and test all the edge cases. This could take much more time, since there might be things we didn't think through.

So for now we suggest to stick to displaying only first ReportScreen in RHP in v1 and for future research if we are 100% sure that moving all the navigation to RHP is the way to go.

I've consulted it with Mateusz and Adam :)

luacmartins · 2024-04-24T15:56:51Z

Yea, I agree we can address the RHP navigation as a separate issue

luacmartins

LGTM. These bugs are still present and will need to be addressed in a follow up, but I think we should focus on the core functionality now given the tight deadline.

hoangzinh

NAB:

hoangzinh · 2024-04-24T16:04:27Z

src/libs/Navigation/Navigation.ts

@@ -60,6 +61,8 @@ const dismissModal = (reportID?: string, ref = navigationRef) => {
 const report = getReport(reportID);
 originalDismissModalWithReport({reportID, ...report}, ref);
 };
+// Re-exporting the closeRHPFlow here to fill in default value for navigationRef. The dismissModal isn't defined in this file to avoid cyclic dependencies.


Suggested change

// Re-exporting the closeRHPFlow here to fill in default value for navigationRef. The dismissModal isn't defined in this file to avoid cyclic dependencies.

// Re-exporting the closeRHPFlow here to fill in default value for navigationRef.

hoangzinh · 2024-04-24T16:17:44Z

src/libs/Navigation/closeRHPFlow.ts

+import type {RootStackParamList} from './types';
+
+/**
+ * Closes the last RHP flow, if there is only one, it closes the entire navigator.


it closes the entire navigator

I feel this is not correct. It should be something like "if there is only one route in the last RHP stack, it closes that entire stack" not the entire navigator. But I may not understand thoroughly your mean here.

hoangzinh · 2024-04-24T16:18:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

hoangzinh · 2024-04-24T16:32:35Z

@WojtekBoman I found a weird bug that I couldn't reproduce in neither the latest main branch nor staging but our PR. I haven't found the root cause yet so just post here first

Bug 5: Composer's menu is displayed on the right
Step to reproduce:

Go to any chat
Tap on "+" button of composer
Tap on "Assign Task"
Refresh the page
Close the RHP
Repeat 2->3
The composer's menu is displayed on the right

Screen.Recording.2024-04-24.at.23.27.43.mov

luacmartins · 2024-04-25T01:12:19Z

@WojtekBoman @hoangzinh if fixing this this bug proves to be time consuming, maybe we can tackle it as a follow up.

hoangzinh · 2024-04-25T02:06:38Z

@luacmartins It will affect current users if they use a direct link to create a task or any other direct links that open RHP so I'm unsure if we can leave it in a follow-up PR. But it's totally up to you @luacmartins.

Screen.Recording.2024-04-25.at.09.04.11.mov

WojtekBoman · 2024-04-25T08:34:02Z

@hoangzinh I've fixed issues that you mentioned above, could you recheck it? :)

hoangzinh · 2024-04-25T10:57:58Z

It works 🚀 @WojtekBoman

luacmartins · 2024-04-25T13:08:21Z

Nice! I'll review this again in a couple of hours. We're getting close!

hoangzinh

LGTM. I have a problem when build IOS native local so I can't screenshot on IOS native but I think we're good.

OSBotify · 2024-04-25T19:04:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-26T23:21:20Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.67-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-29T23:13:07Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-30T00:40:36Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rojiphil · 2024-06-07T13:43:14Z

src/components/MoneyRequestHeader.tsx

@@ -209,7 +221,7 @@ function MoneyRequestHeader({session, parentReport, report, parentReportAction,
 cancelText={translate('common.cancel')}
 danger
 />
- {isSmallScreenWidth && shouldShowHoldMenu && (
+ {shouldUseNarrowLayout && shouldShowHoldMenu && (


The ProcessMoneyRequestHoldMenu is to be shown for small screen devices. However, since shouldUseNarrowLayout is used here, this will also get shown when the held report is opened in RHP thereby resulting in issue #42007

jayeshmangwani · 2024-07-31T20:54:37Z

src/components/MoneyReportHeader.tsx

@@ -269,7 +281,7 @@ function MoneyReportHeader({session, policy, chatReport, nextStep, report: money
 nonHeldAmount={!ReportUtils.hasOnlyHeldExpenses(moneyRequestReport.reportID) ? nonHeldAmount : undefined}
 requestType={requestType}
 fullAmount={fullAmount}
- isSmallScreenWidth={isSmallScreenWidth}
+ isSmallScreenWidth={shouldUseNarrowLayout}


Passing the shouldUseNarrowLayout value as isSmallScreenWidth will stretch the confirmation modal in the web. We should not have changed the isSmallScreenWidth value, as this change caused the issue #45002

WojtekBoman added 4 commits April 19, 2024 12:20

Add ReportScreen to RHP

796379f

Add shouldUseNarrowLayout prop to report header components

997e19e

Adjust position of PopoverMenu in ReportScreen displayed in RHP

2243bb5

Merge branch 'main' into search-v1/rhp-report

8993263

Kicu suggested changes Apr 23, 2024

View reviewed changes

WojtekBoman added 7 commits April 23, 2024 10:19

Add useIsNarrowLayout hook

8650c30

Fix perf tests

d5af8be

Merge branch 'main' into search-v1/rhp-report

0e07013

Fix navigating back from RHP screens

b29a5a7

Run prettier

32208d6

Handle deleting reportID param from search central pane page

5469522

Refactor AttachmentPickerWithMenuItems

8c89050

Kicu approved these changes Apr 23, 2024

View reviewed changes

adamgrzybowski reviewed Apr 23, 2024

View reviewed changes

WojtekBoman added 5 commits April 23, 2024 16:33

Refactor useIsNarrowLayout, add adjustments to ReportScreen in RHP

a97e10b

Add checking shouldUseNarrowLayout

eb3add3

Run prettier

a0c302b

Refactor getAdaptedStateFromPath, fix perf tests

4a07096

Fix lint

4fcb07c

WojtekBoman marked this pull request as ready for review April 23, 2024 16:42

WojtekBoman requested review from a team as code owners April 23, 2024 16:42

melvin-bot bot removed the request for review from a team April 23, 2024 16:42

melvin-bot bot requested a review from hoangzinh April 23, 2024 16:42

luacmartins self-requested a review April 23, 2024 16:50

luacmartins reviewed Apr 23, 2024

View reviewed changes

shawnborton added the Ready To Build label Apr 23, 2024

Refactor closeRHPFlow

a45ae4f

luacmartins previously approved these changes Apr 24, 2024

View reviewed changes

hoangzinh reviewed Apr 24, 2024

View reviewed changes

Add useIsReportOpenInRHP

f5fbd15

WojtekBoman dismissed luacmartins’s stale review via f5fbd15 April 25, 2024 08:27

Fix perf tests

5575b53

hoangzinh approved these changes Apr 25, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins April 25, 2024 17:08

luacmartins approved these changes Apr 25, 2024

View reviewed changes

luacmartins merged commit 6060e6f into Expensify:main Apr 25, 2024
16 checks passed

luacmartins mentioned this pull request Apr 25, 2024

[HOLD] [$250] [Search v1] Refactor RHP flow to contain navigation within itself #41020

Closed

github-actions bot mentioned this pull request Apr 26, 2024

Deploy Checklist: New Expensify 2024-04-26 #41122

Closed

63 tasks

melvin-bot bot mentioned this pull request Apr 29, 2024

[HOLD for payment 2024-05-06] [$250][Search v1] Add ReportScreen to RHP #39883

Closed

rojiphil reviewed Jun 7, 2024

View reviewed changes

rojiphil mentioned this pull request Jun 7, 2024

[HOLD for payment 2024-06-06] [$250] Web - New search - Hold request education modal opens on the top left #42007

Closed

6 tasks

jayeshmangwani reviewed Jul 31, 2024

View reviewed changes

jayeshmangwani mentioned this pull request Jul 31, 2024

[HOLD for payment 2024-08-01] [$250] Search - Payment confirmation modal appears stretched when paying held expenses from RHP #45002

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Search v1] Add ReportScreen to RHP #40570

[Search v1] Add ReportScreen to RHP #40570

WojtekBoman commented Apr 19, 2024 •

edited

Loading

Kicu left a comment

Kicu Apr 23, 2024

Kicu Apr 23, 2024

Kicu Apr 23, 2024

Kicu left a comment

Kicu Apr 23, 2024

Kicu Apr 23, 2024

WojtekBoman Apr 23, 2024

adamgrzybowski Apr 23, 2024

adamgrzybowski Apr 23, 2024

melvin-bot bot commented Apr 23, 2024

luacmartins left a comment

github-actions bot commented Apr 23, 2024

WojtekBoman commented Apr 24, 2024

luacmartins commented Apr 24, 2024

luacmartins left a comment

hoangzinh left a comment

hoangzinh Apr 24, 2024

hoangzinh Apr 24, 2024

hoangzinh commented Apr 24, 2024 •

edited by luacmartins

Loading

hoangzinh commented Apr 24, 2024 •

edited

Loading

luacmartins commented Apr 25, 2024

hoangzinh commented Apr 25, 2024

WojtekBoman commented Apr 25, 2024

hoangzinh commented Apr 25, 2024

luacmartins commented Apr 25, 2024

hoangzinh left a comment

OSBotify commented Apr 25, 2024

OSBotify commented Apr 26, 2024

OSBotify commented Apr 29, 2024

OSBotify commented Apr 30, 2024

rojiphil Jun 7, 2024

jayeshmangwani Jul 31, 2024

	// Re-exporting the closeRHPFlow here to fill in default value for navigationRef. The dismissModal isn't defined in this file to avoid cyclic dependencies.
	// Re-exporting the closeRHPFlow here to fill in default value for navigationRef.

[Search v1] Add ReportScreen to RHP #40570

[Search v1] Add ReportScreen to RHP #40570

Conversation

WojtekBoman commented Apr 19, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Kicu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kicu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Apr 23, 2024

luacmartins left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 23, 2024

WojtekBoman commented Apr 24, 2024

luacmartins commented Apr 24, 2024

luacmartins left a comment

Choose a reason for hiding this comment

hoangzinh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoangzinh commented Apr 24, 2024 • edited by luacmartins Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh commented Apr 24, 2024 • edited Loading

luacmartins commented Apr 25, 2024

hoangzinh commented Apr 25, 2024

WojtekBoman commented Apr 25, 2024

hoangzinh commented Apr 25, 2024

luacmartins commented Apr 25, 2024

hoangzinh left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 25, 2024

OSBotify commented Apr 26, 2024

OSBotify commented Apr 29, 2024

OSBotify commented Apr 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WojtekBoman commented Apr 19, 2024 •

edited

Loading

hoangzinh commented Apr 24, 2024 •

edited by luacmartins

Loading

hoangzinh commented Apr 24, 2024 •

edited

Loading