[HOLD for payment 2024-06-06] [$250] Web - New search - Hold request education modal opens on the top left #42007

m-natarajan · 2024-05-10T21:17:58Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.72-1
Reproducible in staging?: y
Reproducible in production?: (this is happening in "test preferences")
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

User has not held a request (so that Hold request education modal will appear after holding request).

Go to staging.new.expensify.com
Submit two expenses to a user.
Go to one of the transaction threads.
Click 3-dot menu > Hold request.
Enter reason and save it.
Do not click "Got it" on the education RHP. Instead, click on the back button.
Go to Account settings > Troubleshoot.
Click Navigate next to "New Search Page".
Search for the held transaction in Step 4.
Click View.

Expected Result:

Hold request education modal will show up as RHP.

Actual Result:

Hold request education modal opens on the top left.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6477322_1715374043829.20240511_044053.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c80194fe29f72a2f
Upwork Job ID: 1790398130763456512
Last Price Increase: 2024-05-14
Automatic offers:

rojiphil | Reviewer | 0
ShridharGoel | Contributor | 0

Issue Owner

Current Issue Owner: @joekaufmanexpensify

melvin-bot · 2024-05-10T21:18:09Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

m-natarajan · 2024-05-10T21:19:36Z

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

nkdengineer · 2024-05-13T09:09:19Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold request education modal opens on the top left.

What is the root cause of that problem?

We use Popover component here to show ProcessMoneyRequestHoldMenu so it doesn't show in RHP

App/src/components/ProcessMoneyRequestHoldMenu.tsx

Lines 30 to 36 in 59e74e9

    
           function ProcessMoneyRequestHoldMenu({isVisible, onClose, onConfirm, anchorPosition, anchorAlignment}: ProcessMoneyRequestHoldMenuProps) { 
        
               const {translate} = useLocalize(); 
        
               const styles = useThemeStyles(); 
        
               const popoverRef = useRef(null); 
        
               return ( 
        
                   <Popover

What changes do you think we should make in order to solve the problem?

We should use Modal component instead of Popover

<Modal
    type={CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED}
    isVisible={isVisible}
    onClose={onClose}
    onModalHide={onClose}
    hideModalContentWhileAnimating
    useNativeDriver
    shouldUseModalPaddingStyle={false}
>

What alternative solutions did you explore? (Optional)

NA

ShridharGoel · 2024-05-13T10:12:47Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

On web, when using new search - Hold request education modal opens on the top left.

What is the root cause of that problem?

shouldUseNarrowLayout becomes true when isReportOpenInRHP is true.

App/src/pages/home/ReportScreen.tsx

Line 165 in f443efa

const shouldUseNarrowLayout = isSmallScreenWidth || isReportOpenInRHP;

This leads to ProcessMoneyRequestHoldMenu being used in MoneyRequestHeader when the report is opened in RHP, while we should be navigating to PROCESS_MONEY_REQUEST_HOLD on web like it is being done when the report is normally opened.

App/src/components/MoneyRequestHeader.tsx

Lines 249 to 256 in f443efa

    
               {shouldUseNarrowLayout && shouldShowHoldMenu && ( 
        
                   <ProcessMoneyRequestHoldMenu 
        
                       onClose={handleHoldRequestClose} 
        
                       onConfirm={handleHoldRequestClose} 
        
                       isVisible={shouldShowHoldMenu} 
        
                   /> 
        
               )} 
        
           </>

The ProcessMoneyRequestHoldMenu is designed for small screen devices, it shouldn't be used on web.

What changes do you think we should make in order to solve the problem?

Use isSmallScreenWidth instead of shouldUseNarrowLayout.

{(isSmallScreenWidth) && shouldShowHoldMenu && (
    <ProcessMoneyRequestHoldMenu
        onClose={handleHoldRequestClose}
        onConfirm={handleHoldRequestClose}
        isVisible={shouldShowHoldMenu}
    />
)}

We also need to update the useEffect to check isSmallScreenWidth and navigate based on that.

useEffect(() => {
    if (!shouldShowHoldMenu) {
        return;
    }

    if (isSmallScreenWidth) {
        if (Navigation.getActiveRoute().slice(1) === ROUTES.PROCESS_MONEY_REQUEST_HOLD) {
            Navigation.goBack();
        }
    } else {
        Navigation.navigate(ROUTES.PROCESS_MONEY_REQUEST_HOLD);
    }
}, [isSmallScreenWidth, shouldShowHoldMenu]);

This fixes the issue on web + makes sure that the hold education UI doesn't change on mobile.

joekaufmanexpensify · 2024-05-13T14:02:48Z

Will triage today

dragnoir · 2024-05-13T17:40:45Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold request education modal opens on the top left

What is the root cause of that problem?

Let's make sure about something first, we are here talking about two components:

1- ProcessMoneyRequestHoldMenu

This component is designed to be displayed only on small screens, it replace the Right Hand Panel educational window on scmall screens.

2- ProcessMoneyRequestHoldPage

This is the Right Hand Panel educational component. it's displayed only on large screens.

The issue

On the "New Search Page" when we open a report with a hold from Right Hand Panel.
On ReportScreen, the value shouldUseNarrowLayout is true

https://github.com/Expensify/App/blob/97097ff13b086c3d44d26d44335921323b211669/src/pages/home/ReportScreen.tsx#L167C11-L167C33

because isSmallScreenWidth is false but isReportOpenInRHP is true, so shouldUseNarrowLayout is true.

This value shouldUseNarrowLayout is true will be used here

App/src/components/MoneyRequestHeader.tsx

Lines 250 to 254 in 97097ff

    
           <ProcessMoneyRequestHoldMenu 
        
               onClose={handleHoldRequestClose} 
        
               onConfirm={handleHoldRequestClose} 
        
               isVisible={shouldShowHoldMenu} 
        
           />

where it should be opened only on small screens, it's now open when the report is on Right Hand Panel because the condition isSmallScreenWidth || isReportOpenInRHP

What changes do you think we should make in order to solve the problem?

1- Fix ProcessMoneyRequestHoldMenu

We should not allow ProcessMoneyRequestHoldMenu to be displayed on Right Hand Panel and fix the value here

App/src/components/MoneyRequestHeader.tsx

Lines 249 to 255 in 97097ff

    
           {shouldUseNarrowLayout && shouldShowHoldMenu && ( 
        
               <ProcessMoneyRequestHoldMenu 
        
                   onClose={handleHoldRequestClose} 
        
                   onConfirm={handleHoldRequestClose} 
        
                   isVisible={shouldShowHoldMenu} 
        
               /> 
        
           )}

We can use isSmallScreenWidth instead of shouldUseNarrowLayout

2- Fix ProcessMoneyRequestHoldPage

We need to allow ProcessMoneyRequestHoldPage to be displayed on Right Hand Panel

We can use isSmallScreenWidth instead of shouldUseNarrowLayout here

App/src/components/MoneyRequestHeader.tsx

Lines 162 to 169 in 97097ff

    
               if (shouldUseNarrowLayout) { 
        
                   if (Navigation.getActiveRoute().slice(1) === ROUTES.PROCESS_MONEY_REQUEST_HOLD) { 
        
                       Navigation.goBack(); 
        
                   } 
        
               } else { 
        
                   Navigation.navigate(ROUTES.PROCESS_MONEY_REQUEST_HOLD); 
        
               } 
        
           }, [shouldUseNarrowLayout, shouldShowHoldMenu]);

POC video:

20240513_184436.mp4

melvin-bot · 2024-05-14T15:05:56Z

Job added to Upwork: https://www.upwork.com/jobs/~01c80194fe29f72a2f

melvin-bot · 2024-05-14T15:06:01Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

joekaufmanexpensify · 2024-05-15T14:28:05Z

waiting for review of proposals

rojiphil · 2024-05-15T15:30:34Z

@dragnoir How is your proposal different from this one here?

dragnoir · 2024-05-15T15:44:04Z

@dragnoir How is your proposal different from this one here?

it's the same, I didn't notice 😅

rojiphil · 2024-05-15T15:48:43Z

Thanks all for your proposals.
@ShridharGoel proposal LGTM as that was the first one to have the correct RCA and solution.
🎀👀🎀 C+ reviewed

melvin-bot · 2024-05-15T15:48:55Z

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2024-05-15T17:57:02Z

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-05-15T17:57:10Z

📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

joekaufmanexpensify · 2024-05-16T15:03:41Z

@ShridharGoel is there an ETA for PR here?

ShridharGoel · 2024-05-18T07:38:14Z

Will open PR today

joekaufmanexpensify · 2024-05-20T14:19:21Z

Great. TY!

joekaufmanexpensify · 2024-05-28T14:19:59Z

PR in review

melvin-bot · 2024-05-30T21:24:40Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-05-30T21:24:44Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Hold request education details should show suitably for new search on web #42364

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

@rojiphil requires payment automatic offer (Reviewer)
@ShridharGoel requires payment automatic offer (Contributor)

melvin-bot · 2024-05-30T21:24:45Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rojiphil] The PR that introduced the bug has been identified. Link to the PR: [Search v1] Add ReportScreen to RHP #40570
[@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40570/files#r1631231021
[@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist is good enough to capture such issues.
[@rojiphil] Determine if we should create a regression test for this bug.
[@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

joekaufmanexpensify · 2024-06-03T13:56:24Z

@rojiphil could you handle BZ so we can issue payment this week?

joekaufmanexpensify · 2024-06-06T20:03:30Z

bump @rojiphil , we're all set to issue payment here as soon as checklist is done

rojiphil · 2024-06-07T13:51:56Z

[@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
[@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
[@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist is good enough to capture such issues.
[@rojiphil] Determine if we should create a regression test for this bug. : Not a change prone area or high usage area as this occurs only when the held report is in RHP on large screen devices. We can skip adding a regression test for this.
[@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

rojiphil · 2024-06-07T13:52:35Z

@joekaufmanexpensify Accepted offer and completed BZ. Thanks

joekaufmanexpensify · 2024-06-07T14:36:08Z

TY!

joekaufmanexpensify · 2024-06-07T14:36:34Z

All set to issue payment. We need to pay:

@ShridharGoel $250 for PR via Upwork.
@rojiphil $250 for C+ via Upwork.

joekaufmanexpensify · 2024-06-07T14:37:42Z

@rojiphil $250 sent and contract ended!

joekaufmanexpensify · 2024-06-07T14:37:50Z

@ShridharGoel please accept upwork offer so we can pay you

joekaufmanexpensify · 2024-06-10T13:22:41Z

@ShridharGoel $250 sent and contract ended!

joekaufmanexpensify · 2024-06-10T13:22:49Z

All set. Thanks everyone!

m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 10, 2024

melvin-bot bot assigned joekaufmanexpensify May 10, 2024

melvin-bot bot added the Overdue label May 13, 2024

melvin-bot bot removed the Overdue label May 13, 2024

joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label May 14, 2024

melvin-bot bot changed the title ~~Web - New search - Hold request education modal opens on the top left~~ [$250] Web - New search - Hold request education modal opens on the top left May 14, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 14, 2024

melvin-bot bot assigned rojiphil May 14, 2024

melvin-bot bot assigned aldo-expensify May 15, 2024

aldo-expensify assigned ShridharGoel May 15, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 15, 2024

melvin-bot bot added the Overdue label May 18, 2024

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels May 18, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 30, 2024

melvin-bot bot changed the title ~~[$250] Web - New search - Hold request education modal opens on the top left~~ [HOLD for payment 2024-06-06] [$250] Web - New search - Hold request education modal opens on the top left May 30, 2024

melvin-bot bot removed the Reviewing Has a PR in review label May 30, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 6, 2024

rojiphil mentioned this issue Jun 7, 2024

[Search v1] Add ReportScreen to RHP #40570

Merged

50 tasks

melvin-bot bot added the Overdue label Jun 10, 2024

melvin-bot bot removed the Overdue label Jun 10, 2024

joekaufmanexpensify closed this as completed Jun 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-06-06] [$250] Web - New search - Hold request education modal opens on the top left #42007

[HOLD for payment 2024-06-06] [$250] Web - New search - Hold request education modal opens on the top left #42007

m-natarajan commented May 10, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented May 10, 2024

m-natarajan commented May 10, 2024

nkdengineer commented May 13, 2024 •

edited

Loading

ShridharGoel commented May 13, 2024

joekaufmanexpensify commented May 13, 2024

dragnoir commented May 13, 2024 •

edited

Loading

melvin-bot bot commented May 14, 2024

melvin-bot bot commented May 14, 2024

joekaufmanexpensify commented May 15, 2024

rojiphil commented May 15, 2024

dragnoir commented May 15, 2024

rojiphil commented May 15, 2024

melvin-bot bot commented May 15, 2024

melvin-bot bot commented May 15, 2024

melvin-bot bot commented May 15, 2024

joekaufmanexpensify commented May 16, 2024

ShridharGoel commented May 18, 2024

joekaufmanexpensify commented May 20, 2024

joekaufmanexpensify commented May 28, 2024

melvin-bot bot commented May 30, 2024

melvin-bot bot commented May 30, 2024

melvin-bot bot commented May 30, 2024 •

edited by joekaufmanexpensify

Loading

joekaufmanexpensify commented Jun 3, 2024

joekaufmanexpensify commented Jun 6, 2024

rojiphil commented Jun 7, 2024

rojiphil commented Jun 7, 2024

joekaufmanexpensify commented Jun 7, 2024

joekaufmanexpensify commented Jun 7, 2024

joekaufmanexpensify commented Jun 7, 2024

joekaufmanexpensify commented Jun 7, 2024

joekaufmanexpensify commented Jun 10, 2024

joekaufmanexpensify commented Jun 10, 2024

[HOLD for payment 2024-06-06] [$250] Web - New search - Hold request education modal opens on the top left #42007

[HOLD for payment 2024-06-06] [$250] Web - New search - Hold request education modal opens on the top left #42007

Comments

m-natarajan commented May 10, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented May 10, 2024

m-natarajan commented May 10, 2024

nkdengineer commented May 13, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ShridharGoel commented May 13, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

joekaufmanexpensify commented May 13, 2024

dragnoir commented May 13, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

1- ProcessMoneyRequestHoldMenu

2- ProcessMoneyRequestHoldPage

The issue

What changes do you think we should make in order to solve the problem?

1- Fix ProcessMoneyRequestHoldMenu

2- Fix ProcessMoneyRequestHoldPage

POC video:

melvin-bot bot commented May 14, 2024

melvin-bot bot commented May 14, 2024

joekaufmanexpensify commented May 15, 2024

rojiphil commented May 15, 2024

dragnoir commented May 15, 2024

rojiphil commented May 15, 2024

melvin-bot bot commented May 15, 2024

melvin-bot bot commented May 15, 2024

melvin-bot bot commented May 15, 2024

joekaufmanexpensify commented May 16, 2024

ShridharGoel commented May 18, 2024

joekaufmanexpensify commented May 20, 2024

joekaufmanexpensify commented May 28, 2024

melvin-bot bot commented May 30, 2024

melvin-bot bot commented May 30, 2024

melvin-bot bot commented May 30, 2024 • edited by joekaufmanexpensify Loading

joekaufmanexpensify commented Jun 3, 2024

joekaufmanexpensify commented Jun 6, 2024

rojiphil commented Jun 7, 2024

rojiphil commented Jun 7, 2024

joekaufmanexpensify commented Jun 7, 2024

joekaufmanexpensify commented Jun 7, 2024

joekaufmanexpensify commented Jun 7, 2024

joekaufmanexpensify commented Jun 7, 2024

joekaufmanexpensify commented Jun 10, 2024

joekaufmanexpensify commented Jun 10, 2024

m-natarajan commented May 10, 2024 •

edited by melvin-bot bot

Loading

nkdengineer commented May 13, 2024 •

edited

Loading

dragnoir commented May 13, 2024 •

edited

Loading

melvin-bot bot commented May 30, 2024 •

edited by joekaufmanexpensify

Loading