[HOLD for payment 2024-08-07][$250] [Search v1] Implement action buttons

[luacmartins]

Implement this section of the design doc - https://docs.google.com/document/d/1ldZ85fyQO4662hLZRNFfm0_IxaP7-PWvaqc8Z33jsLQ/edit#bookmark=id.kt71e0n7yfsm

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f3a821ed6381f7c6
• Upwork Job ID: 1821233586009483173
• Last Price Increase: 2024-08-07

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

On hold

[Kicu]

hey, I would like to work on this task today

[Kicu]

@luacmartins some questions regarding design doc:

1.

Which set of actions should we support? according to the list in design doc: https://docs.google.com/document/d/1ldZ85fyQO4662hLZRNFfm0_IxaP7-PWvaqc8Z33jsLQ/edit#bookmark=id.kt71e0n7yfsm
we have: done | paid | review | pay | approve | hold | submit
but in the pseudocode below there is also delete should I include it?

2.

Is the action type and translation view or review because right now api returns view?

3.

I can see that we already have API commands for some of these functions, example:

App/src/libs/API/types.ts

Line 384 in bb8ad52

[WRITE_COMMANDS.PAY_MONEY_REQUEST]: Parameters.PayMoneyRequestParams;

and they have their payloads defined. So I'm assuming that I should be using those existing commands.
If yes - then where should I take the required params from? For example Pay (https://github.com/Expensify/App/blob/a86501a237cdecd54356cb47b64c629086e6a30f/src/libs/API/parameters/PayMoneyRequestParams.ts) we need: iouReportID, chatReportID, reportActionID, paymentMethodType Should I assume they will be available inside the TransactionItem data?

[luacmartins]

Which set of actions should we support?

I added the missing ones to the doc, but the full list is: done | paid | review | pay | approve | hold | submit | view. Delete is only possible either on the bulk action dropdown or via the transaction thread three dot menu

Is the action type and translation view or review because right now api returns view?

We have both, view just navigates the user to the transaction thread reportID in the RHP. Review will do the same, but will be shown when hasErrors is true, indicating that the admin should review the request (and potentially make edits) instead of just view it.

I can see that we already have API commands for some of these functions, example:

No, we'll need to create new commands since the existing ones update "live" Onyx data and work offline. The API requests from Search will not work like that because the users might not have "live" data for those transactions, reports, policies, etc. So those commands need to rely only on the Search data in snapshot.data. These commands will only work online with the limited information available in the snapshot key.

[luacmartins]

@Kicu also noting that this issue will be put on hold until we migrate some existing code in the backend. So I'd recommend picking another one for now.

[Kicu]

Alright I'm stopping work on this one for now 👍 thanks for the answers they will be useful when I return to this.

I created a draft just so that I won't loose my work, its unfinished (~50% work done I think) so don't review.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f3a821ed6381f7c6

[melvin-bot]

Current assignees @ishpaul777 and @eh2077 are eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @Kicu is from an agency-contributor and not due payment
• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)
• ROLE: @eh2077 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@greg-schroeder)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1821233586009483173/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[greg-schroeder]

Processing - are there other payments I need to make here? This issue is a bit difficult to follow 😅

[ishpaul777]

I reviewed this Pr #45712, linked to this issue. The payment issue #45728 was closed without payment

[greg-schroeder]

Okay, got it, thank you

[eh2077]

My case is similar - I helped to review this PR #41725 and there's no automation to track the payment.

[luacmartins]

Processing - are there other payments I need to make here? This issue is a bit difficult to follow 😅

I think only the payments to @ishpaul777 and @eh2077 as mentioned in the summary here

[greg-schroeder]

Okay got it, processing, sorry for delay

[greg-schroeder]

Offers sent to @eh2077 and @ishpaul777

[greg-schroeder]

I'll pay these ASAP as soon as you accept 👍

[eh2077]

@greg-schroeder Offer accepted, thank you!

[ishpaul777]

Seems like my offer is withdrawn

[greg-schroeder]

? That's... weird. I definitely didn't withdraw it, lol

[greg-schroeder]

Upwork is a very good program. I will try again

[greg-schroeder]

Re-sent

[ishpaul777]

Thanks, Accpted offer!