[HOLD for payment 2024-04-25] Expense - GBR appears briefly in LHN when Schedule submit is enabled and admin requests money

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #38675
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new Collect workspace.
3. Go to Profile > Workspaces > Collect workspace.
4. Go to More features > Enable workflows.
5. Go to Workflows.
6. Enable Add approvals.
7. Also please ensure that "Delay submissions" is enabled.
8. Return to workspace chat.
9. Create a manual request.

Expected Result:

Since "Schedule submit" is enabled in Step 7, there should be no GBR in LHN when admin requests money from the workspace chat.

Actual Result:

When admin requests money from the workspace chat, GBR appears for a while, then disappears.
This issue only happens when admin requests money from the workspace chat, not when employee requests money from the workspace chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6443232_1712653228404.20240409_165306.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@CortneyOfstad I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[paultsimura]

Looks like a regression from my PR, checking now 👀

[paultsimura]

@mountiny could you please help me clarify the requirements a bit? These GBR branches are a bit complicated, and we've gone through a couple of them with you on the original PR.

Am I correct to assume the following?

1. For paid group policies, if harvesting is enabled, no GBR should appear neither on admin's nor on member's side
2. For free group policies, if I'm requesting money from my own workspace, I should see the GBR

[mountiny]

For paid group policies, if harvesting is enabled, no GBR should appear neither on admin's nor on member's side

correct, the report will submit automatically so no GBR as nobody is expected to take action

For free group policies, if I'm requesting money from my own workspace, I should see the GBR

For free, there is no concept of Draft reports, so they are always in Submitted state when created. In that case the admin would see GBR as they need to pay

[mountiny]

@arosiclair happy to take this over as I have reviewed the PR

[mountiny]

@paultsimura will you be able to address this in a PR quickly? thank you

[paultsimura]

Yes, I'm on it

[paultsimura]

The PR's ready: #39941
cc: @mountiny @akinwale

[mountiny]

Actually as I was writing the request to cherry pick I think this does not have to be CPed its a minor bug that wont really influence users so we can leave this go with the normal process

[mountiny]

I have created an issue here to internally handle that clean up as I think we need to make this logic slightly more robust and it will be easier if internal person handles it #39953

[mountiny]

I believe we can close this now

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Incorrect handling of GBR for Admin #39941

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@paultsimura] The PR that introduced the bug has been identified. Link to the PR:
• [@paultsimura] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@paultsimura] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@paultsimura] Determine if we should create a regression test for this bug.
• [@paultsimura] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: