-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Incorrect handling of GBR for Admin #39941
Conversation
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@akinwale might handle the review as it's a regression fix. |
const shouldBeManuallySubmitted = PolicyUtils.isPaidGroupPolicy(policy) && !policy?.harvesting?.enabled; | ||
if (shouldBeManuallySubmitted || PolicyUtils.isPolicyAdmin(policy)) { | ||
const isOwnFreePolicy = PolicyUtils.isFreeGroupPolicy(policy) && PolicyUtils.isPolicyAdmin(policy); | ||
if (shouldBeManuallySubmitted || isOwnFreePolicy) { | ||
return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will need to update this logic further with the other cases/ based on the delayed submission settings rather than type of policy and members role.
This is good for the deploy blocker fix though
Reviewer Checklist
Screenshots/VideosSimple logic change: Screen.Recording.2024-04-09.at.16.29.43.mp4Android: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.62-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.62-0 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.62-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀
|
Details
This PR fixes the way GBR is calculated for workspace admins
Fixed Issues
$ #39923
PROPOSAL: N/A
Tests
Same as QA
Offline tests
Same as QA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android17.13.mp4
Android: mWeb Chrome
chrome17.13.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-09.at.17.11.1317.11.mp4
iOS: mWeb Safari
Untitled17.11.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-04-09.at.16.37.5116.38.mp4
MacOS: Desktop
Screen.Recording.2024-04-09.at.16.43.3716.43.mp4