[HOLD PR #42892][$250] Text pasted from Slack won't send or disappears in NewDot.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712695994757859

Action Performed:

Scenario 1:

1. Copy text from from Slack
2. Paste text in compose box
3. Tap return

Scenario 2:

1. Copy text from from Slack
2. Type > in compose box
3. Paste text after > (and a space after)
4. Tap return

Expected Result:

Message is sent

Actual Result:

Scenario 1: Message stays in compose box and won't send. Cursor stays at the beginning of the message
Scenario 2: Only the > part of the message sends.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2959.mp4

2024-04-09_10-53-38.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01892e3b8e5931a268
• Upwork Job ID: 1778891800225918976
• Last Price Increase: 2024-04-12
• Automatic offers:
• jayeshmangwani | Reviewer | 0
• kpadmanabhan | Contributor | 0

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

@roryabraham been discussing here with @thienlnam that this is specific for Slack it seems so we should not have to hold deploy for this bug

[brkdavis]

@m-natarajan can you pls paste the unformatted content of the slack message? initial suspicion is > symbol is treated with a special character when you copy to clipboard.

[melvin-bot]

📣 @brkdavis! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Julesssss]

As discussed here in Slack, we will not mark #39971 as a blocker. It's only reproducable when triple clicking before copy/pasting and is part of a new feature.

[mallenexpensify]

Also happens when trying to copy/paste from https://github.com/Expensify/App/blob/main/contributingGuides/HOW_TO_BECOME_A_CONTRIBUTOR_PLUS.md

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01892e3b8e5931a268

[roryabraham]

making this external

[BartoszGrajdek]

Hi, I’m Bartosz from SWM react-native-live-markdown team. We’ve recently decided that it would be best to actively participate in all of the issues related to the library we’re working on. That means reviewing proposals together with the Expensify team and supporting external contributors to ensure quality solutions that won’t introduce any additional regressions. 🙌🏻

I’m currently going through all of the issues that could require any changes to the library. Feel free to tag me if you need anything, later I’ll be diving into the issues more in-depth, but there’s quite a few of them so it can take a while for me to catch up. Oh and feel free to tag me in any live-markdown related issues in the future! 😄

[mallenexpensify]

Moved to Live Markdown project
@kpadmanabhan once #42892 hit production, please hold on proceeding til we have feedback from @BartoszGrajdek . Thx

[melvin-bot]

This issue has not been updated in over 15 days. @slafortune, @jayeshmangwani, @roryabraham, @kpadmanabhan eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[kpadmanabhan]

@MelvinBot this is blocked because of the PR that is on hold.

@jayeshmangwani / @roryabraham : how should we proceed here?
@mallenexpensify : do we have any update on this?

[jayeshmangwani]

how should we proceed here?

@kpadmanabhan We are still waiting for the other contributor to update their PR and get it ready for merging. Until then, we are blocked.
How should we proceed from here? I am quite confused.
@mallenexpensify might be the savior here

[kpadmanabhan]

We are still waiting for the other contributor to update their PR and get it ready for merging. Until then, we are blocked.

Exactly. But it has been quite a long wait is my worry.
@mallenexpensify : what do you suggest?

[mallenexpensify]

@jayeshmangwani @kpadmanabhan , sorry, I'm confused. I've checked links but I'm unsure where we're at. Is it....

• @kpadmanabhan was hired here
• We put it on hold pending Web - Composer - Cursor positioned at the start if pasting text which contains a new line #42892
• Web - Composer - Cursor positioned at the start if pasting text which contains a new line #42892 never got completed/fixed via the PR, it was fixed elsewhere
• Now we have this open issue, with no action needed. We need to figure out potential compensation.

Is that right?

[kpadmanabhan]

@mallenexpensify in a sense that's correct.

[jayeshmangwani]

Is that right?

Yes, that's correct! I had opened the discussion a few days ago for this issue here https://expensify.slack.com/archives/C02NK2DQWUX/p1719300668647629

[mallenexpensify]

OK.. since @kpadmanabhan was hired and invested a non-immaterial amount of work, compensation should be do.
My gut says either 50 or 100%. What do you think @jayeshmangwani and @roryabraham ?

[jayeshmangwani]

@mallenexpensify Generally, we should have given 100% as the PR was almost in a mergeable state, but since the raised PR had one regression found during testing, I would say 50% compensation should be given.

[mallenexpensify]

Thanks @jayeshmangwani . Does that sound good n' fair to you @kpadmanabhan ?

[kpadmanabhan]

@mallenexpensify though task was for completing the bug fix, I did a lot more than that following up on other bugs and PRs in the related area. However, I am fine with the suggestion from you and @jayeshmangwani .

Sad that my changes couldn't hit production. Looking forward to that in next proposals.

[mallenexpensify]

I did a lot more than that following up on other bugs and PRs in the related area

@kpadmanabhan if you want to provide links and details to the additional work, it's possible that could influence the compensation amount. We always appreciate contributors monitoring other issues/PRs and chiming in when it's helpful.

[jayeshmangwani]

@mallenexpensify tagged the wrong contributor 🙂 ; the message was meant for you, @kpadmanabhan.

[kpadmanabhan]

@kpadmanabhan if you want to provide links and details to the additional work, it's possible that could influence the compensation amount. We always appreciate contributors monitoring other issues/PRs and chiming in when it's helpful.

thanks @mallenexpensify and @jayeshmangwani.

I am fine with any compensation that Expensify considers fair.
anyhow noting down my contribution for this issue and the issues that I was keeping track of.

addition of unit tests in my PR for this issue, which i do not see covered in any of the merged PRs from others for this issue.

• [HOLD PR #42892][$250] Text pasted from Slack won't send or disappears in NewDot. #39971 (comment)
• https://github.com/Expensify/App/pull/41265/files

other related issues that i kept track of.

• Web - Composer - Cursor positioned at the start if pasting text which contains a new line #42892 (comment)
• Web - Composer - Cursor positioned at the start if pasting text which contains a new line #42892 (comment)
• [$250] Markdown - Space in the Code Block is removed after Manually copying and pasting #43331 (comment)
• [Pay meow][$250] Web - Composer - Cursor positioned at the start if pasting text which contains a new line #42216 (comment)
• [$250] Chat - Unable to send manually copied and pasted code block and compose box not expanded #40033 (comment)
• Markdown – Send button is not active when paste text with markdown and Enter from Word #43808 (comment)

not counting the other proposals that i submitted.

[mallenexpensify]

but since the raised PR had one regression found during testing,

and, from CONTRIBUTING.md

If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):

@jayeshmangwani, was the regression found during testing before the code was merged?

Also, @kpadmanabhan , thanks for the breakdown and context.

[kpadmanabhan]

@jayeshmangwani, was the regression found during testing before the code was merged?

@mallenexpensify : jayesh found it when everything looked good during final review.
you may refer to this comment and the surrounding comments in the PR.
#41265 (comment)

correct me if i am wrong @jayeshmangwani

[jayeshmangwani]

was the regression found during testing before the code was merged?

@mallenexpensify Yes, found when testing the PR.

[mallenexpensify]

Since the regression was found before being merged, that would be normal testing. We don't have documentation stating there are penalties for that. Based on that, and @kpadmanabhan 's breakdown above, I think we shoudl compensate 100% here for both @kpadmanabhan and @jayeshmangwani. They were both hired/assigned and started work on the PR.

[mallenexpensify]

Contributor: @kpadmanabhan paid $250 via Upwork
Contributor+: @jayeshmangwani paid $250 via Upwork

Thanks!

[melvin-bot]

@slafortune @roryabraham Be sure to fill out the Contact List!