[HOLD for payment 2024-06-06] [$500] Can't select mention when there is a single item

[rlinoz]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Break down in numbered steps

1. Start trying to mention a user in a room
2. Narrow it down to 1 user only
3. Try to tap on it

Expected Result:

Describe what you think should've happened
User should be selected and auto complete closed

Actual Result:

Describe what actually happened
Nothing happens no tap.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-04-18.at.18.40.18.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e879d520febf1253
• Upwork Job ID: 1781370564759228416
• Last Price Increase: 2024-05-21
• Automatic offers:
• dukenv0307 | Reviewer | 0

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[puneetlath]

@rlinoz should we make this external?

[rlinoz]

Ops, yes we should.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e879d520febf1253

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[melvin-bot]

📣 @jingp-ofload! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jp928]

Contributor details Your Expensify account email: piaojingtai@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01a3ce7f9619e1a922?viewMode=1

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[dukenv0307]

@jp928 We only create PR when we get assigned. Can you pls close the PR? Thanks

[jp928]

Closed. Sry for that

[dukenv0307]

@jingp-ofload @jp928 We should read this guideline to become contributor

[jp928]

@dukenv0307 anybody review my proposal on upwork? I am stuck.

[dukenv0307]

@jp928 Did you read this guideline?

[jp928]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In a workspace, when there is only one mentioned contact in the list, the contact is not clickable.

What is the root cause of that problem?

There is rendering issue inside Flashlist (related hot it calculate the height of each item and render them) so that even though the component is visible but actually it is not interact-able.

What changes do you think we should make in order to solve the problem?

Disable Flashlist auto layout and update the data props after the animation on the modal completed.

What alternative solutions did you explore? (Optional)

Alternatively, use Flatlist instead.

[jp928]

@dukenv0307 Sure. Will do later today.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use flatlist instead of flashlist #42513

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @jp928 requires payment (Needs manual offer from BZ)
• @dukenv0307 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dukenv0307] Determine if we should create a regression test for this bug.
• [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jp928]

• Needs manual offer from BZ

@dukenv0307 I am not sure who would be the best person to ask for the manual offer. I do have a Upwork account proposed on this.

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. N/A
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[dukenv0307]

@jp928 we need to wait for @JmillsExpensify

[JmillsExpensify]

Payment summary:

• Contributor: @jp928 $500
• Contributor+: @dukenv0307 $500

[JmillsExpensify]

@jp928 sent you an offer. Mind accepting. C+ offer is paid out!

[JmillsExpensify]

All contributors paid out. Closing this one. Thanks!