[$250] GRP chat - Invalid group chat name error still persists after clearing group name text

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.63-7
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: ttps://github.com/Expensify/App/pull/39757
Issue reported by: Applause - Internal Team

Action Performed:

Precondition : User [A] created group chat with group name

1. User A - Go the created group chat
2. Tap on header >> Settings option
3. Enter over 255 characters in the Name text input field & tap on Save button (Note : error message appears)
4. Remove all the text & tap on save (Note : Report name becomes a default with emails + first name in alphabetical order , but the error message still displayed)

Expected Result:

When maximum characters entered & later removing all the group name text, error message "Invalid group chat name" should be cleared as well. Only the group name with default with emails + first name in alphabetical order should be shown

Actual Result:

"Invalid group chat name" error message still displayed after clearing group name text

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6455003_1713538443610.Errormessagepersists.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0155d31c13ca9e9680
• Upwork Job ID: 1781375437507940352
• Last Price Increase: 2024-04-19
• Automatic offers:
• dukenv0307 | Reviewer | 0
• neonbhai | Contributor | 0

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invalid group chat name error still persists after clearing group name text

What is the root cause of that problem?

We don't clear the error fields when setting new name optimistically here:

App/src/libs/actions/Report.ts

Lines 572 to 579 in 09ad468

	function updateGroupChatName(reportID: string, reportName: string) {
	const optimisticData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
	value: {reportName},
	},
	];

What changes do you think we should make in order to solve the problem?

We should clear errorFields for reportName when setting it in optimisticData

errorFields: {
    reportName: null,
},

We do the same when updating room names here:

App/src/libs/actions/Report.ts

Lines 2030 to 2032 in 09ad468

	errorFields: {
	reportName: null,
	},

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0155d31c13ca9e9680

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[saifelance]

@MelvinBot
To solve this issue, you should clear the error field for the report name when setting it optimistically. Ensures that any previous error state related to the report name is cleared when a new name is set optimistically.

In the function updateGroupChatName:

const optimisticData: OnyxUpdate[] = [
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
        value: { reportName },
        errorFields: {
            reportName: null,
        },
    },
];

when updating room names:

errorFields: {
    reportName: null,
},

[dukenv0307]

Let's go with @neonbhai's solution. I think we should call updateGroupChatName when the name is actually changed.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @yuwenmemon is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[saifelance]

Let's go with @neonbhai's solution. I think we should call updateGroupChatName when the name is actually changed.

🎀👀🎀 C+ reviewed

@dukenv0307 Ofcourse

[saifelance]

@dukenv0307 @neonbhai Ensure that any previous error state is reset when setting a new name optimistically.

[dukenv0307]

@yuwenmemon what do you think about my decision?

[yuwenmemon]

SGTM!

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

Bump @neonbhai on slack

[neonbhai]

Apologies for the delay. Raising final PR shortly!

[neonbhai]

PR ready for review!

[melvin-bot]

This issue has not been updated in over 15 days. @yuwenmemon, @neonbhai, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[neonbhai]

PR was merged in May, seems like the automation failed here. Bump to finish payments and close the issue!

cc: @yuwenmemon

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@yuwenmemon the AutoAssignerTriage label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.

[yuwenmemon]

@JmillsExpensify Looks like we need to do payment on this one

[dukenv0307]

@JmillsExpensify @yuwenmemon Should we process the payment? Thanks

[dukenv0307]

@JmillsExpensify any updates?

[dukenv0307]

@JmillsExpensify friendly bump

[JmillsExpensify]

Payment summary:

• Contributor: $250 @neonbhai
• Contributor+: @dukenv0307

[JmillsExpensify]

@dukenv0307 do we need to add a regression test for this issue?

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. No
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[JmillsExpensify]

Thanks! Everyone has been paid via Upwork and checklist complete, so closing this one out.