[HOLD for payment 2024-06-13] [$250] Does not show the chat room in the results when searching for the rooms user is a part of

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-11
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713480493902799

Action Performed:

1. Join any public room
2. Search for the room using search icon

Expected Result:

Search results should display the result in which the user is a part of

Actual Result:

No results found error message appears
For @davidcardoza Shows the results for any room which are pinned

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.3009.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015b0a0277b5ad4344
• Upwork Job ID: 1782705413299757056
• Last Price Increase: 2024-04-30
• Automatic offers:
• akinwale | Reviewer | 0

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[saifelance]

@m-natarajan The current behaviour looks ok

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

when searching for the rooms user is a part of, the room doesn't appear on the serach result

What is the root cause of that problem?

on ChatFinderPage, the useOptionsList does not turn the rooms where the user is invited to.

https://github.com/Expensify/App/blob/aa6e8c6182935acd79cc78356342f3cc61bbe6db/src/pages/ChatFinderPage/index.tsx#L59C46-L59C60

The two functions from OptionsListUtils used to create the optiosn list createOptionList and getOptions had this tine of code:

App/src/libs/OptionsListUtils.ts

Lines 1478 to 1480 in aa6e8c6

	if (!accountIDs || accountIDs.length === 0) {
	return;
	}

The invited user to a public room is not allowed to check the list and details of the room users, where accountIDs.length === 0 is true.

What changes do you think we should make in order to solve the problem?

We need to check if the report is a chat room if accountIDs.length === 0

update here and here to

if ((!accountIDs  ||  accountIDs.length  ===  0) &&  !isChatRoom) {
  return;
}

POC:

20240421_222833.mp4

We can discuss more throw the PR how to make sure it's an invited chat room report.

[saifelance]

@dragnoir

This issue stems from a condition in the createOptionList and getOptions functions in OptionsListUtils.ts.

To address this issue, you proposed modifying the condition to also check if the report is a chat room before returning if accountIDs.length === 0. Here's how you could implement this change:

if ((!accountIDs || accountIDs.length === 0) && !isChatRoom) { return; }

[saifelance]

@dragnoir Correct
users should indeed be able to search for and find public chat rooms that they have joined.

You can modify the condition to ensure that public chat rooms are included in the search results.

if ((!accountIDs || accountIDs.length === 0) && !isChatRoom && !isPublic) { return; }

By adding !isPublic to the condition, you ensure that public chat rooms are not excluded from the search results. This change allows users to search for and find public chat rooms they have joined.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015b0a0277b5ad4344

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

@akinwale, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@akinwale, @anmurali Still overdue 6 days?! Let's take care of this!

[anmurali]

@akinwale have you had a chance to review proposals above?

[davidcardoza]

@anmurali should we find someone else to review proposals? It's been over a week now since there has been activity in this GH.

[akinwale]

I missed the notifications on this one. Reviewing the proposal now.

[akinwale]

We can move forward with @dragnoir's proposal here.

@dragnoir You need to add another condition to check that the chat room is a public room, otherwise, the workspace rooms like #announce and #admins will show up in the search results, which I reckon we don't want.

🎀👀🎀 C+ reviewed.

[melvin-bot]

This issue has not been updated in over 15 days. @akinwale, @dragnoir, @anmurali, @luacmartins eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: display joined public rooms in search results #41865

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @dragnoir requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[akinwale]

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression.

• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Launch the Expensify App.
2. Join a new public chat room.
3. Click or tap on the search icon and try to search for the chat room.
4. Verify that the chat room appears in the search results.

Do we agree 👍 or 👎?

[akinwale]

@anmurali bump for payment. Thanks.

[melvin-bot]

@akinwale, @dragnoir, @anmurali, @luacmartins Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@akinwale, @dragnoir, @anmurali, @luacmartins Still overdue 6 days?! Let's take care of this!

[anmurali]

@akinwale is paid
@dragnoir - offer is here

[melvin-bot]

@akinwale, @dragnoir, @anmurali, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[anmurali]

Everyone is paid!