Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Task - Confirmation page not skipped for assign task flow when accessed from QAB #40719

Closed
1 of 6 tasks
kbecciv opened this issue Apr 22, 2024 · 6 comments
Closed
1 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Apr 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Issue found when executing PR: #39413

Action Performed:

Precondition: User A has created task skipping the assignee field. User has selected share somewhere option

  1. Navigate to staging ND site
  2. Tap FAB button
  3. Select shortcut assign task
  4. Enter task title & description

Expected Result:

Assign Task flow skips the confirmation page when task flow accessed from QAB

Actual Result:

Confirmation page not skipped for assign task flow when accessed from QAB

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6457588_1713801924958.Recording__151.mp4

image

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv kbecciv changed the title Task - Confirmation page not skipped for assign task flow when accessed from QAB Web - Task - Confirmation page not skipped for assign task flow when accessed from QAB Apr 22, 2024
@kbecciv
Copy link
Author

kbecciv commented Apr 22, 2024

We think that this bug might be related to #vip-vsb

@chiragsalian
Copy link
Contributor

Not really a blocker. Looks like #39413 is not working as expected and doesn't feel blocker worthy imo. Removing blocker label and reassigning issue to @Gonals since it's an issue with his PR. Feel free to let me know if you need any assistance with this.

@chiragsalian chiragsalian added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 22, 2024
@chiragsalian chiragsalian assigned Gonals and unassigned chiragsalian Apr 22, 2024
@c3024
Copy link
Contributor

c3024 commented Apr 23, 2024

I think this is expected behaviour. Only when both assignee and share destination are selected does the QAB skip confirmation for tasks. In this case only share destination is selected.

cc: @Gonals

@Gonals
Copy link
Contributor

Gonals commented Apr 23, 2024

I think this is expected behaviour. Only when both assignee and share destination are selected does the QAB skip confirmation for tasks. In this case only share destination is selected.

Yep. I think that's fine for now. We can revisit this behavior down the line 🤷

@Gonals Gonals closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants