[HOLD for payment 2024-06-06] 2FA - Web - Infinite loading spinner on 2FA authentication page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4500402&group_by=cases:section_id&group_order=asc&group_id=229043
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to New dot and enter expensifail account with 2FA enabled
2. Navigate to email and locate the magic link - change to staging
3. Open an new tab and navigate to the staging link

Expected Result:

2FA required page should be displayed and no loading spinner should appear

Actual Result:

Infinite loading spinner when user navigates to 2FA authentication page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6457876_1713814267237.Recording__2924.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

@MonilBhavsar FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[MonilBhavsar]

Commented on the suspected PR #40177

[parasharrajat]

Let me check.

[mountiny]

@MonilBhavsar Cn you please try to revert that PR and test on it? We should CP the revert if that is the case, thanks!

[bernhardoj]

I already have the fix, going to open up the PR in a moment.

[MonilBhavsar]

Okay thanks! I'll put revert PR on hold then

[mountiny]

Thanks for help Monil

[parasharrajat]

Ping me when ready.

[bernhardoj]

PR is up

cc: @parasharrajat

[parasharrajat]

@MonilBhavsar Please close this issue when confirmed that it is fixed.

[parasharrajat]

@bernhardoj Can you please update the PR to include changes from old PR?

[MonilBhavsar]

Fixed on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix here is your magic code shows briefly when login with magic link #40766

If no regressions arise, payment will be issued on 2024-06-06. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MonilBhavsar] Determine if we should create a regression test for this bug.
• [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: