Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Revert "Fix here is your magic code shows briefly when login with magic link" #40760

Merged

Conversation

MonilBhavsar
Copy link
Contributor

@MonilBhavsar MonilBhavsar commented Apr 23, 2024

Reverts #40177

Fixes a deploy blocker #40742

  1. Go to New dot and enter expensifail account with 2FA enabled
  2. Navigate to email and locate the magic link - change to staging
  3. Open an new tab and navigate to the staging link or build link
  4. 2FA required page should be displayed without infinite loader

Copy link
Contributor

@MonilBhavsar
Copy link
Contributor Author

Issue seems fixed

Screenshot 2024-04-23 at 3 30 31 PM

@MonilBhavsar MonilBhavsar marked this pull request as ready for review April 23, 2024 10:03
@MonilBhavsar MonilBhavsar requested a review from a team as a code owner April 23, 2024 10:03
@melvin-bot melvin-bot bot requested review from arosiclair and removed request for a team April 23, 2024 10:04
Copy link

melvin-bot bot commented Apr 23, 2024

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MonilBhavsar MonilBhavsar removed the request for review from arosiclair April 23, 2024 10:04
@MonilBhavsar MonilBhavsar changed the title Revert "Fix here is your magic code shows briefly when login with magic link" [HOLD] Revert "Fix here is your magic code shows briefly when login with magic link" Apr 23, 2024
@MonilBhavsar
Copy link
Contributor Author

We're probably fixing it #40742 (comment)
We can revert if it is really blocking the deploy

@MonilBhavsar MonilBhavsar changed the title [HOLD] Revert "Fix here is your magic code shows briefly when login with magic link" Revert "Fix here is your magic code shows briefly when login with magic link" Apr 23, 2024
@mountiny mountiny changed the title Revert "Fix here is your magic code shows briefly when login with magic link" [CP Staging] Revert "Fix here is your magic code shows briefly when login with magic link" Apr 23, 2024
@mountiny
Copy link
Contributor

Thanks, straight revert so checklists are not required

@mountiny mountiny merged commit 767367b into main Apr 23, 2024
13 of 20 checks passed
@mountiny mountiny deleted the revert-40177-fix/39904-here-is-ur-magic-code-shows-briefly branch April 23, 2024 13:27
Copy link

melvin-bot bot commented Apr 23, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

not emergency, see above, only checklists missing

OSBotify pushed a commit that referenced this pull request Apr 23, 2024
…is-ur-magic-code-shows-briefly

[CP Staging] Revert "Fix here is your magic code shows briefly when login with magic link"

(cherry picked from commit 767367b)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.64-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants