-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Revert "Fix here is your magic code shows briefly when login with magic link" #40760
[CP Staging] Revert "Fix here is your magic code shows briefly when login with magic link" #40760
Conversation
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
We're probably fixing it #40742 (comment) |
Thanks, straight revert so checklists are not required |
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
not emergency, see above, only checklists missing |
…is-ur-magic-code-shows-briefly [CP Staging] Revert "Fix here is your magic code shows briefly when login with magic link" (cherry picked from commit 767367b)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.64-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀
|
Reverts #40177
Fixes a deploy blocker #40742