Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold on #40708] Web - Composer - Navigating to an invalid merchant edit URL makes composer active while RHP is open #40795

Closed
1 of 6 tasks
kbecciv opened this issue Apr 23, 2024 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: y
Issue found when executing PR: #39413
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create an expense request
  3. Open the expense report
  4. Click on Merchant to open the merchant edit RHP
  5. Change the URL to an invalid one by replacing the ID to text and navigate to it (e.g https://staging.new.expensify.com/edit/submit/merchant/INVALID_TEXT/3276255813405397)
  6. Press any key on the keyboard

Expected Result:

Compose box should not be active while not found RHP is open

Actual Result:

Compose box is active and user can type anything while not found RHP is open

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6458539_1713862433266.bandicam_2024-04-23_11-46-15-151.mp4

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@kbecciv
Copy link
Author

kbecciv commented Apr 23, 2024

We think that this bug might be related to #wave-collect - Release 1

@kbecciv
Copy link
Author

kbecciv commented Apr 23, 2024

@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@bernhardoj
Copy link
Contributor

Should be fixed in this PR. It's a live markdown issue where the auto focus doesn't work even when we set it to false.

@laurenreidexpensify laurenreidexpensify changed the title Web - Composer - Navigating to an invalid merchant edit URL makes composer active while RHP is open [Hold on #40708] Web - Composer - Navigating to an invalid merchant edit URL makes composer active while RHP is open Apr 24, 2024
@laurenreidexpensify laurenreidexpensify added Weekly KSv2 and removed Daily KSv2 labels Apr 25, 2024
@laurenreidexpensify
Copy link
Contributor

#40708 is on staging, so adding to weekly KI resting

@laurenreidexpensify laurenreidexpensify added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Apr 29, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants