[$250] Create automated tests for Workspace Tags page

[luacmartins]

Problem

New API commands introduced as part of the Simplified Collect project don't have automated tests, which can lead to bugs and unexpected behavior when these commands are updated.

Solution

Add automated tests for the commands below:

• Test SetPolicyRequiresTag
• Test RenamePolicyTaglist
• Test CreatePolicyTag
• Test SetPolicyTagsEnabled
• Test RenamePolicyTag
• Test DeletePolicyTags

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aeec6fe63684bff5
• Upwork Job ID: 1783143522597269504
• Last Price Increase: 2024-04-24
• Automatic offers:
• eh2077 | Reviewer | 0
• nkdengineer | Contributor | 0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Nodebrute]

dibs

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Create automated tests for Workspace Tags page

What is the root cause of that problem?

We don't have automation test for commands in Workspace Tags page

What changes do you think we should make in order to solve the problem?

1. We can create a test in tests/actions for commands test like WorkspaceTagsTest
2. When we write the test for each command

• Call the function of the command with the necessary param. i.e. for SetPolicyRequiresTag we will call Policy.setPolicyRequiresTag function

• Build the test case based on all possible cases the input param of the function that will call the API command can have. After calling the API, get the updated data in Onyx and check if it's correct or not based on the expected output data with the given input param of the test case that we pass to the command function.

• To write the test for API commands, we can do the same way in other tests like IOUTest

What alternative solutions did you explore? (Optional)

NA

[nkdengineer]

Updated proposal to detail how can we define the test case.

[eh2077]

@nkdengineer 's plan to add tests looks good to me.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aeec6fe63684bff5

[melvin-bot]

Current assignee @eh2077 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@eh2077 The PR is here.

[eh2077]

@MitchExpensify This is due for payment. I don't think we'll need checklist for this issue because we just added tests.

[MitchExpensify]

Payment summary:

• $250 @nkdengineer Contributor (Upwork)
• $250 @eh2077 Contributor+ (Upwork)

[MitchExpensify]

Paid and contracts ended