-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Distance rate - Unable to proceed with empty name via Enter key, while it works with green CTA #40945
Comments
Triggered auto assignment to @kevinksullivan ( |
@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Unable to proceed with empty name via Enter key in Distance rate modal What is the root cause of that problem?The problem originates from how the Enter key event is managed across multiple interactive components within the Here's what's happening:
The core of the issue is that the This overlap in how the Enter key is handled between nested components causes confusion and incorrect behavior. What changes do you think we should make in order to solve the problem?we can use the
enterKeyEventListenerPriority = 0,
enterKeyEventListenerPriority={enterKeyEventListenerPriority}
enterKeyEventListenerPriority={1} POCScreen.Recording.2024-04-25.at.4.32.16.AM.mov |
@kevinksullivan Eep! 4 days overdue now. Issues have feelings too... |
Hm it's only for a brand new field but I was able to reproduce. |
Going to add to Collect wave and make external, but I'd consider this a low priority. |
Job added to Upwork: https://www.upwork.com/jobs/~018c1c78753474f238 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale ( |
@abzokhattab's proposal makes sense here. 🎀👀🎀 C+ reviewed. |
Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
This issue has not been updated in over 15 days. @akinwale, @blimpich, @kevinksullivan, @abzokhattab eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
This was deployed to production on 2023-05-23 which makes payment due 2023-05-30. |
I think we can close this? @kevinksullivan @akinwale @abzokhattab is payment complete? |
Closing, if this is wrong then please feel free to ping me in Slack. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.65-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
In Step 6, Enter key should save the empty name (because it works by clicking on the Save button)
Actual Result:
In Step 6, Enter key does not save the empty name
When returning to previous page in Step 7, error appears below the empty fields, which means Enter key is working elsewhere instead
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6460735_1713988573289.20240425_035123.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: