[HOLD for payment 2024-06-13] [$250] [QBO] "Last synced just now" text doesn't update

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.66-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714057390428649?thread_ts=1714057353.559839&cid=C036QM0SLJK

Action Performed:

1. Connect to QBO
2. Observe the "Last synced just now" text
3. Go have a coffee for 10mins
4. Come back
5. Observe the text still reads "Last synced just now"

Expected Result:

On OldDot the way we handle it is by checking the lastSync timestamp from the policy on page load, and then compute a human-friendly time difference with it. Every time you/auto-sync syncs the connection it's updated here.

Actual Result:

Despite hours elapsing the text still reads: "Last synced just now" even after a page refresh, suggesting this is just a static value currently.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

CC: @hayata-suenaga @aldo-expensify @teneeto @narefyev91 @zanyrenney

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016f30631fa560635c
• Upwork Job ID: 1783647518731452416
• Last Price Increase: 2024-04-26
• Automatic offers:
• Ollyws | Reviewer | 0
• tienifr | Contributor | 0

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[trjExpensify]

Haven't moved this on yet, as I think we might need to hold on:

https://github.com/Expensify/Web-Expensify/pull/41822
#41044

[trjExpensify]

Confirmed we don't need a hold on those PRs, moving it on.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016f30631fa560635c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Despite hours elapsing the text still reads: "Last synced just now" even after a page refresh, suggesting this is just a static value currently.

What is the root cause of that problem?

We're showing Last synced just now in

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Lines 98 to 100 in 42d4ed7

	description: isSyncInProgress
	? translate('workspace.accounting.connections.syncStageName', connectionSyncProgress.stageInProgress)
	: translate('workspace.accounting.lastSync'),

and it's just a static value

What changes do you think we should make in order to solve the problem?

1. BE should return new value to indicate the lastSync timestamp (SyncPolicyToQuickbooksOnline command). We need to update it optimistically too
2. Use it value to calculate the difference in time from lastSync to the current time

We can update this value every 10 mins (5 mins, ...)

What alternative solutions did you explore? (Optional)

NA

[tienifr]

The logic to calculate the difference in time is quite simple (use setInterval), so I will add the detail implementation in PR phase

[aldo-expensify]

BE should return new value to indicate the lastSync timestamp (SyncPolicyToQuickbooksOnline command). We need to update it optimistically too

@tienifr you can get the value from policy.connections.quickbooksOnline.lastSync.successfulDate

[tienifr]

@aldo-expensify Ah I see, thank you! I'll use it in PR phase. @Ollyws Wdyt about my proposal?

[teneeto]

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.

[trjExpensify]

@tienifr, can we use DateUtils.datetimeToRelative( ) (like here) and add "Last synced" before that string for the human readable message to display?

[tienifr]

@trjExpensify Can you assign me on this issue so I'll raise the PR?

[trjExpensify]

Let's have the proposal reviewed.

CC: @mountiny for vis as I was just talking to yah about this one

[Ollyws]

Having a look now....

[Ollyws]

@tienifr's proposal LGTM.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

@mountiny you happy with this proposal? Let's get a PR up for it.

[mountiny]

@tienifr please go ahead and raise the PR

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @Ollyws, @trjExpensify, @mountiny, @tienifr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

Commented in the PR that's held, I think we can switch the base and merge it into the QBO branch

[mountiny]

Done

[trjExpensify]

Solid, thank yah!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Last synced just now does not update #41310

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

We won't need a regression test for this, as they'll be added centrally with the QBO project.

Payment summary as follows:

• $250 to @tienifr for the fix
• $250 to @Ollyws for the C+ review

@Ollyws feel free to send a request, @tienifr I've paid you in Upwork. Closing!

[Ollyws]

Requested in ND.

[JmillsExpensify]

$250 approved for @Ollyws