Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Expensify icon is not centered in the about page #4119

Closed
isagoico opened this issue Jul 16, 2021 · 14 comments · Fixed by #4180
Closed

New Expensify icon is not centered in the about page #4119

isagoico opened this issue Jul 16, 2021 · 14 comments · Fixed by #4180
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@isagoico
Copy link

isagoico commented Jul 16, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to e.cash
  2. Navigate to Settings>About page

Expected Result:

New Expensify icon should be centered

Actual Result:

New Expensify icon is left justified.

Workaround:

No need for workaround, visual issue.

Platform:

Where is this issue occurring?

Web ✔️
iOS✔️
Android✔️
Desktop App✔️
Mobile Web✔️

Version Number: 1.0.79-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image
image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @Beamanator https://expensify.slack.com/archives/C01GTK53T8Q/p1626342434313600

The e.cash icon position & size changed recently on the About page (was centered, now left justified) - does it look ok to everyone? I think it looks a bit out of place now - maybe the version number should not be centered anymore or the icon should still be centered

view this job on upwork

@isagoico isagoico added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 16, 2021
@MelvinBot
Copy link

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 16, 2021
@isagoico
Copy link
Author

@mallenexpensify My bad, I mistakenly created the issue with the incorrect label, fixing it.

@MelvinBot
Copy link

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@AndrewGable AndrewGable added the External Added to denote the issue can be worked on by a contributor label Jul 21, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@AndrewGable
Copy link
Contributor

Looks like a great external issue 🤙

@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 21, 2021
@MelvinBot
Copy link

Triggered auto assignment to @Julesssss (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@helaoutar
Copy link
Contributor

This would be fixed by adding a align-items: center to settingsPageBody within src/styles/styles.js.

@aliabbasmalik8
Copy link
Contributor

aliabbasmalik8 commented Jul 21, 2021

PROPOSAL

position can fix by adding alignItems: 'center', at this position.

<View style={[styles.settingsPageBody, styles.mb6]}>

and also a minor update <Logo /> from <Logo height={100} />

<Logo height={100} />

and for size, if we want to increase logo size then we need big size logo svg because the current logo svg has size 52px width and height or we can update height/width in new-expensify.svg.

Thanks

after applied styling on the web

image

@Julesssss
Copy link
Contributor

Hi @helaoutar. As you submitted the first proposal would you like to take the issue?

@jboniface
Copy link

@helaoutar I went ahead and hired you for this.

@roryabraham
Copy link
Contributor

The PR to fix this caused a minor regression, reverting it here.

@roryabraham roryabraham reopened this Jul 27, 2021
@arielgreen arielgreen removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 27, 2021
@helaoutar
Copy link
Contributor

The regression was fixed about a week ago in this PR: #4243

@roryabraham
Copy link
Contributor

Yep, that's correct! @jboniface let's make sure @helaoutar is paid for the Upwork job.

@jboniface
Copy link

ok paid and closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants