-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Expensify icon is not centered in the about page #4119
Comments
Triggered auto assignment to @mallenexpensify ( |
@mallenexpensify My bad, I mistakenly created the issue with the incorrect label, fixing it. |
Triggered auto assignment to @AndrewGable ( |
Triggered auto assignment to @jboniface ( |
Looks like a great external issue 🤙 |
Triggered auto assignment to @Julesssss ( |
This would be fixed by adding a |
PROPOSAL position can fix by adding App/src/pages/settings/AboutPage.js Line 91 in 2d673cc
and also a minor update App/src/pages/settings/AboutPage.js Line 92 in 2d673cc
and for size, if we want to increase logo size then we need big size logo svg because the current logo svg has size 52px width and height or we can update height/width in Thanks after applied styling on the web |
Hi @helaoutar. As you submitted the first proposal would you like to take the issue? |
@helaoutar I went ahead and hired you for this. |
The PR to fix this caused a minor regression, reverting it here. |
The regression was fixed about a week ago in this PR: #4243 |
Yep, that's correct! @jboniface let's make sure @helaoutar is paid for the Upwork job. |
ok paid and closing |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
New Expensify icon should be centered
Actual Result:
New Expensify icon is left justified.
Workaround:
No need for workaround, visual issue.
Platform:
Where is this issue occurring?
Web ✔️
iOS✔️
Android✔️
Desktop App✔️
Mobile Web✔️
Version Number: 1.0.79-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork
From @Beamanator https://expensify.slack.com/archives/C01GTK53T8Q/p1626342434313600
view this job on upwork
The text was updated successfully, but these errors were encountered: