Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center new expensify icon in about page #4180

Conversation

helaoutar
Copy link
Contributor

@helaoutar helaoutar commented Jul 22, 2021

Details

The PR aims to center the Expensify icon in about page

Fixed Issues

Fixes #4119

Tests

QA Steps

Simply make sure that the icon is centered in about page, on Web/Mobile Web/ Desktop/ iOS and Android.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Mobile Web

Screenshot 2021-07-23 at 01 22 52

Web

Screenshot 2021-07-23 at 01 22 44

Desktop

Screenshot 2021-07-23 at 01 24 46

iOS

Screenshot 2021-07-23 at 12 46 21

Android

Screenshot_20210723-012317_Expensifycash

@helaoutar helaoutar requested a review from a team as a code owner July 22, 2021 22:53
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team July 22, 2021 22:53
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@helaoutar
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@shawnborton
Copy link
Contributor

shawnborton commented Jul 22, 2021

The icon needs to be quite larger too. Ideally this looks just like the Profile view looks (without the pencil icon though):

image

@helaoutar
Copy link
Contributor Author

helaoutar commented Jul 23, 2021

The icon needs to be quite larger too. Ideally this looks just like the Profile view looks (without the pencil icon though):

image

Done! I updated the screenshots.

Copy link
Contributor

@jasperhuangg jasperhuangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! I'm going to wait on the tests to run and approval from @shawnborton on the new screenshots you've posted before merging 👍

@shawnborton
Copy link
Contributor

Looks good to me!

@jasperhuangg jasperhuangg merged commit 5c36490 into Expensify:main Jul 23, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham
Copy link
Contributor

roryabraham commented Jul 26, 2021

I believe this PR caused a regression, reverting...

@roryabraham
Copy link
Contributor

JK, I didn't revert this. @helaoutar fixed the regression in this PR

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Expensify icon is not centered in the about page
5 participants