-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Center new expensify icon in about page #4180
Center new expensify icon in about page #4180
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! I'm going to wait on the tests to run and approval from @shawnborton on the new screenshots you've posted before merging 👍
Looks good to me! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.79-5🚀
|
I believe this PR caused a regression, reverting... |
JK, I didn't revert this. @helaoutar fixed the regression in this PR |
🚀 Deployed to production in version: 1.0.80-2🚀
|
Details
The PR aims to center the Expensify icon in about page
Fixed Issues
Fixes #4119
Tests
QA Steps
Simply make sure that the icon is centered in about page, on Web/Mobile Web/ Desktop/ iOS and Android.
Tested On
Screenshots
Mobile Web
Web
Desktop
iOS
Android