[$250] Thread – Reply is present when create a second level thread and delete comment

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4530392
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in.
3. Go to any chat and send a message.
4. Create a thread and send a comment.
5. Create a second level thread and don’t send messages
6. Go back and delete the comment from step 4
7. Observe that there are no comments in the thread
8. Go back to parent chat

Expected Result:

There is no reply under the message when create a second level thread and delete comment

Actual Result:

Reply is present under the message when create a second level thread and delete comment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6467602_1714552068810.Threas_2_lev.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011780584d68800980
• Upwork Job ID: 1785737118212800512
• Last Price Increase: 2024-05-08

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The count message within the thread becomes inaccurate when a comment is deleted.

What is the root cause of that problem?

Even after deleting the last comment, the DeleteComment API continues to return childVisibleActionCount is 1, which is used to display the count message in the child thread.

What changes do you think we should make in order to solve the problem?

We need to address this issue from the backend. How can I gain access to the backend codebase?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dragnoir]

BE issue, wrong "childCommenterCount" value

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011780584d68800980

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[ikevin127]

This looks BE related based on findings from proposal and #41399 (comment) -> therefore I think it should be fixed internally.

[melvin-bot]

@garrettmknight, @ikevin127 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@garrettmknight, @ikevin127 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[garrettmknight]

Thanks @ikevin127 - moving to Internal.

[melvin-bot]

Current assignee @ikevin127 is eligible for the Internal assigner, not assigning anyone new.

[garrettmknight]

Waiting for volunteer.

[melvin-bot]

@garrettmknight @ikevin127 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[garrettmknight]

Still looking for a volunteer!

[ikevin127]

Looking for a volunteer 🎲

[ikevin127]

Looking for a volunteer 🎲

[garrettmknight]

Still waiting for a volunteer.

[garrettmknight]

Still waiting for a volunteer.

[garrettmknight]

Still waiting for a volunteer.

[garrettmknight]

Still waiting for a volunteer.

[garrettmknight]

Still waiting for a volunteer.

[garrettmknight]

Still waiting for a volunteer.

[garrettmknight]

Still waiting for a volunteer.

[garrettmknight]

Closing since VSB is closed, will wait on real reporting to reopen.