Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search v1] Create Finished canned search #41624

Closed
luacmartins opened this issue May 3, 2024 · 25 comments
Closed

[Search v1] Create Finished canned search #41624

luacmartins opened this issue May 3, 2024 · 25 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented May 3, 2024

Section from design doc - https://docs.google.com/document/d/1ldZ85fyQO4662hLZRNFfm0_IxaP7-PWvaqc8Z33jsLQ/edit#bookmark=kix.wqeob2z58zqn

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011cdb0e0c8bbdb964
  • Upwork Job ID: 1790718775554523136
  • Last Price Increase: 2024-05-15
Issue OwnerCurrent Issue Owner: @chiragsalian
@luacmartins luacmartins added the Daily KSv2 label May 3, 2024
@luacmartins luacmartins self-assigned this May 3, 2024
@luacmartins luacmartins changed the title [HOLD][Search v1] Create Finished canned search [Search v1] Create Finished canned search May 6, 2024
Copy link

melvin-bot bot commented May 7, 2024

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented May 7, 2024

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@luacmartins
Copy link
Contributor Author

Taking off hold, we'll start implementation shortly.

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. Hot Pick Ready for an engineer to pick up and run with labels May 10, 2024
Copy link

melvin-bot bot commented May 10, 2024

Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 10, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels May 10, 2024
@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@sakluger
Copy link
Contributor

@luacmartins this isn't overdue, right?

Also, I'm guessing I'll mainly be here to pay out the C+ who reviews the PR, right? Let me know if there's anything else I can do to help.

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
@luacmartins
Copy link
Contributor Author

Not overdue. Correct, we'll just need to pay out C+ once the PR is reviewed.

@jnowakow
Copy link
Contributor

I'm from SoftwareMansion and I'll work on this issue.

@luacmartins luacmartins added the Internal Requires API changes or must be handled by Expensify staff label May 15, 2024
Copy link

melvin-bot bot commented May 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011cdb0e0c8bbdb964

Copy link

melvin-bot bot commented May 15, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

@trjExpensify
Copy link
Contributor

@trjExpensify trjExpensify removed the Hot Pick Ready for an engineer to pick up and run with label May 15, 2024
@sakluger sakluger removed the NewFeature Something to build that is a new item. label May 16, 2024
@sakluger sakluger removed their assignment May 16, 2024
@sakluger sakluger added the Bug Something is broken. Auto assigns a BugZero manager. label May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sakluger sakluger assigned sakluger and unassigned CortneyOfstad May 16, 2024
@sakluger
Copy link
Contributor

I'm going OOO through May 31, @CortneyOfstad please watch over this while I'm gone. Thanks!

@CortneyOfstad
Copy link
Contributor

Sounds good @sakluger!

Copy link

melvin-bot bot commented May 17, 2024

@sakluger @CortneyOfstad @chiragsalian @luacmartins @fedirjh this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
Copy link

melvin-bot bot commented May 20, 2024

@sakluger, @CortneyOfstad, @chiragsalian, @luacmartins, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented May 22, 2024

@sakluger, @CortneyOfstad, @chiragsalian, @luacmartins, @fedirjh Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented May 24, 2024

@sakluger, @CortneyOfstad, @chiragsalian, @luacmartins, @fedirjh Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented May 28, 2024

@sakluger, @CortneyOfstad, @chiragsalian, @luacmartins, @fedirjh 10 days overdue. I'm getting more depressed than Marvin.

Copy link

melvin-bot bot commented May 29, 2024

@sakluger, @CortneyOfstad, @chiragsalian, @luacmartins, @fedirjh 12 days overdue now... This issue's end is nigh!

1 similar comment
Copy link

melvin-bot bot commented May 30, 2024

@sakluger, @CortneyOfstad, @chiragsalian, @luacmartins, @fedirjh 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot removed the Daily KSv2 label Jun 3, 2024
Copy link

melvin-bot bot commented Jun 3, 2024

This issue has not been updated in over 14 days. @sakluger, @CortneyOfstad, @chiragsalian, @luacmartins, @fedirjh eroding to Weekly issue.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jun 3, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 3, 2024
@sakluger
Copy link
Contributor

sakluger commented Jun 3, 2024

Unassigning @CortneyOfstad since I'm back from OOO.

@sakluger
Copy link
Contributor

sakluger commented Jun 3, 2024

Looks like the latest is that there is a draft PR: https://github.com/Expensify/Auth/pull/11115

@luacmartins
Copy link
Contributor Author

The original PR was approved/merged into our merge slush branch. We'll request a merge of the Slush branch once the queries are timed.

@luacmartins
Copy link
Contributor Author

PR deployed to prod. This is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

7 participants