Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payment Request] [$250] [Search v1] Add canned searches to SearchFilters #41625

Closed
luacmartins opened this issue May 3, 2024 · 24 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Hot Pick Ready for an engineer to pick up and run with NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented May 3, 2024

Section from design doc - https://docs.google.com/document/d/1ldZ85fyQO4662hLZRNFfm0_IxaP7-PWvaqc8Z33jsLQ/edit#bookmark=id.17106yfpjaun

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013c617a911681a508
  • Upwork Job ID: 1790718907539705856
  • Last Price Increase: 2024-05-15
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@luacmartins luacmartins added the Daily KSv2 label May 3, 2024
@luacmartins luacmartins self-assigned this May 3, 2024
@luacmartins luacmartins changed the title [HOLD][Search v1] Add canned searches to SearchFilters [Search v1] Add canned searches to SearchFilters May 6, 2024
Copy link

melvin-bot bot commented May 7, 2024

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

1 similar comment
Copy link

melvin-bot bot commented May 7, 2024

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@luacmartins
Copy link
Contributor Author

Taking off hold, we'll start implementation shortly.

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@Kicu
Copy link
Contributor

Kicu commented May 9, 2024

hey I can take this and start working today

@luacmartins
Copy link
Contributor Author

@Kicu let's focus on the issues I shared in Slack first, since the backend for this is still not ready:

@luacmartins luacmartins changed the title [Search v1] Add canned searches to SearchFilters [HOLD #41620 #416243 #41624] [Search v1] Add canned searches to SearchFilters May 10, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. Hot Pick Ready for an engineer to pick up and run with labels May 10, 2024
Copy link

melvin-bot bot commented May 10, 2024

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 10, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels May 10, 2024
@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

@strepanier03, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@luacmartins
Copy link
Contributor Author

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2024
@jnowakow
Copy link
Contributor

I'll do it as part of work on canned searches (#41624, #41623, #41620)

@trjExpensify
Copy link
Contributor

Assigning @jnowakow for the frontend, will remove Hot picks once confirmed there isn't backend for this issue specifically and these issues are for backend: #41624, #41623, #41620

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label May 15, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels May 20, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 3, 2024
@melvin-bot melvin-bot bot changed the title [$250] [HOLD #41620 #416243 #41624] [Search v1] Add canned searches to SearchFilters [HOLD for payment 2024-06-13] [$250] [HOLD #41620 #416243 #41624] [Search v1] Add canned searches to SearchFilters Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@parasharrajat
Copy link
Member

Regression Test Steps

  1. Go to new Search Page. Use Profile > Troubleshoot > New search page if page is not active.
  2. There should be 4 options to pick on the left sidebar.
  3. Make sure clicking on those changes the search list on the right. (Only Expenses is supported till today).

Do you agree 👍 or 👎 ?

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 12, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Payment Summary

Upwork Job

  • Reviewer: @parasharrajat owed $250 via NewDot
  • Contributor: @jnowakow is from an agency-contributor and not due payment

BugZero Checklist (@strepanier03)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1790718907539705856/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@luacmartins luacmartins changed the title [HOLD for payment 2024-06-13] [$250] [HOLD #41620 #416243 #41624] [Search v1] Add canned searches to SearchFilters [HOLD for payment 2024-06-13] [$250] [Search v1] Add canned searches to SearchFilters Jun 13, 2024
@strepanier03
Copy link
Contributor

Payment summary

@JmillsExpensify request incoming.

@strepanier03 strepanier03 changed the title [HOLD for payment 2024-06-13] [$250] [Search v1] Add canned searches to SearchFilters [Payment Request] [$250] [Search v1] Add canned searches to SearchFilters Jun 14, 2024
@parasharrajat
Copy link
Member

@strepanier03 Feel free to close this issue if nothing is left on it. I will request it later.

@melvin-bot melvin-bot bot added the Overdue label Jun 17, 2024
@luacmartins
Copy link
Contributor Author

Closing as per the comment above.

@melvin-bot melvin-bot bot removed the Overdue label Jun 17, 2024
@parasharrajat
Copy link
Member

Payment requested as per #41625 (comment)

@JmillsExpensify
Copy link

$250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Hot Pick Ready for an engineer to pick up and run with NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

7 participants