Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave Collect][Xero] Fix the Tags menu item not showing in the LHN #41831

Closed
lakchote opened this issue May 8, 2024 · 12 comments
Closed

[Wave Collect][Xero] Fix the Tags menu item not showing in the LHN #41831

lakchote opened this issue May 8, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lakchote
Copy link
Contributor

lakchote commented May 8, 2024

Problem

Tags menu item are not showing in the LHN

Solution

Let's implement it so they show in the LHN when customers or tracking categories are imported as tags

The end result should look like this below:

image
@lakchote lakchote self-assigned this May 8, 2024
@trjExpensify trjExpensify moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 8, 2024
@trjExpensify
Copy link
Contributor

Just a heads up on that mock that it's got some outdated UI. Please use the page that exists in product already for tags.

@lakchote
Copy link
Contributor Author

lakchote commented May 8, 2024

Just a heads up on that mock that it's got some outdated UI. Please use the page that exists in product already for tags.

Thank you Tom. I've updated the mock image.

@cdOut
Copy link
Contributor

cdOut commented May 9, 2024

Hi, I’m Tymoteusz from Software Mansion, the expert agency, and I’d like to work on this task.

@trjExpensify trjExpensify added the Bug Something is broken. Auto assigns a BugZero manager. label May 9, 2024
Copy link

melvin-bot bot commented May 9, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mananjadhav
Copy link
Collaborator

I can help with the review once this is ready.

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@lakchote
Copy link
Contributor Author

@cdOut how is it going, do you need anything? If you hit any blockers don't hesitate to ping me. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
@mananjadhav
Copy link
Collaborator

@lakchote Can you assign this to me for the review so that I can track this.

@cdOut
Copy link
Contributor

cdOut commented May 13, 2024

Hi, I'm going to put a PR for this tonight or early tomorrow, I'm currently working on finishing it up.

@lakchote
Copy link
Contributor Author

lakchote commented May 15, 2024

Tags menu is showing on the LHN (Slack), so a PR might not be needed. We need to wait for #41562 to be merged and deployed to staging though, so everyone can test it.

@melvin-bot melvin-bot bot added the Overdue label May 17, 2024
@mananjadhav
Copy link
Collaborator

@lakchote Do we need this issue?

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2024
@lakchote
Copy link
Contributor Author

@lakchote Do we need this issue?

Yes, as @trjExpensify experienced the problem here. We need to investigate.

@lakchote
Copy link
Contributor Author

@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants