Add sync functionality in Xero connection #41562

ShridharGoel · 2024-05-03T09:10:19Z

Details

Add sync functionality in Xero connection.

Fixed Issues

$ #41320
PROPOSAL: #41320 (comment)

Tests

Enable accounting.
Go to accounting page.
Connect Xero.
Use the sync connection option.
Check that "Other integrations" doesn't show Xero while sync is happening.
As of now, no API call should happen when sync is done for Xero.
Do the same for Quickbooks, API call should happen.

QA Steps

Enable accounting.
Go to accounting page.
Connect Xero.
Use the sync connection option.
Check that "Other integrations" doesn't show Xero while sync is happening.
As of now, no API call should happen when sync is done for Xero.
Do the same for Quickbooks, API call should happen.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screenrecording_20240503_154025.mp4

iOS: Native

Screen.Recording.2024-05-03.at.2.44.39.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-05-03.at.3.43.14.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-03.at.2.41.27.PM.mov

MacOS: Desktop

Screen.Recording.2024-05-03.at.3.33.37.PM.mov

melvin-bot · 2024-05-03T09:10:24Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-05-06T05:32:27Z

@ShridharGoel Can you fix the lint issues?

mananjadhav · 2024-05-06T06:23:57Z

src/libs/actions/connections/index.ts

@@ -124,4 +124,34 @@ function updatePolicyConnectionConfig<TConnectionName extends ConnectionName, TS
    API.write(WRITE_COMMANDS.UPDATE_POLICY_CONNECTION_CONFIG, parameters, {optimisticData, failureData, successData});
 }

-export {removePolicyConnection, updatePolicyConnectionConfig};
+function syncConnection(policyID: string, connectionName: PolicyConnectionName | undefined) {


Can we add jsdocs here?

mananjadhav · 2024-05-08T09:00:15Z

@ShridharGoel The PR for the Sync command on the backend is on staging. Can you please add the code for sync and finish the PR?

Let me know once it's done and ready for review.

…into 41320

src/libs/actions/connections/index.ts

mananjadhav · 2024-05-09T20:03:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-xero-sync-now.mov

Android: mWeb Chrome

mweb-chrome-xero-sync-now.mov

iOS: Native

ios-xero-sync-now.mov

iOS: mWeb Safari

mweb-safari-xero-sync-now.mov

MacOS: Chrome / Safari

web-xero-sync-now.mov

MacOS: Desktop

desktop-xero-sync-now.mov

mananjadhav

@ShridharGoel Can you please sync the xero-merge-freeze in this branch.

…into 41320

hayata-suenaga · 2024-05-09T22:54:34Z

just double checking, have Spanish translations been approved, right?

hayata-suenaga · 2024-05-09T22:59:33Z

src/libs/API/parameters/SyncPolicyToIntegratedConnectionParams.ts

+    idempotencyKey: string;
+};
+
+export default SyncPolicyToIntegratedConnectionParams;


I'm a little bit confused about this because this is not a command that exists on the backend.

I see that we use this as the parameter type for both of the following commands

READ_COMMANDS.SYNC_POLICY_TO_QUICKBOOKS_ONLINE

READ_COMMANDS.SYNC_POLICY_TO_XERO

Are there other param types defined in the parameters directly that is not part of the APIs?

This is a common file for both since both would use the same list of parameters.

should we create a separate file for each command? I think the pattern we use is a one type definition for each command. It's possible that the parameters for these commands to diverge in the future 😄

cc @ShridharGoel

Updating this.

hungvu193 · 2024-05-15T13:57:17Z

Reviewing shortly 👀

hayata-suenaga · 2024-05-15T17:42:31Z

@hungvu193, I think this PR has been already been reviewed by another C+ 🤔

hayata-suenaga

🟢

hungvu193

LGTM!

Screen.Recording.2024-05-16.at.06.33.24.mov

Screen.Recording.2024-05-16.at.06.32.51.mov

hungvu193 · 2024-05-15T23:35:56Z

@hungvu193, I think this PR has been already been reviewed by another C+ 🤔

ah yeah, I only re-verify while Manan was out as we discuss here

lakchote · 2024-05-16T06:44:13Z

@ShridharGoel there are conflicts, please solve them when you can. Thanks.

ShridharGoel · 2024-05-16T08:23:18Z

@lakchote Will update in a few hours.

lakchote · 2024-05-16T14:42:20Z

@lakchote Will update in a few hours.

Any update? Thanks!

mananjadhav · 2024-05-16T19:52:15Z

@ShridharGoel I can see lint errors. Can you please fix them? Also while we might have the merge freeze? Can you check this thread on priority for potential merge conflicts? We're aiming to merge this asap as it is blocking some of our testing flows.

ShridharGoel · 2024-05-16T19:59:49Z

@mananjadhav Sure.

OSBotify · 2024-05-30T21:53:44Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:30:14Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-04T13:56:16Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add sync functionality in Xero connection

189c4f4

ShridharGoel requested a review from a team as a code owner May 3, 2024 09:10

melvin-bot bot requested review from mananjadhav and removed request for a team May 3, 2024 09:10

ShridharGoel mentioned this pull request May 3, 2024

[HOLD for payment 2024-06-11] [$250] [Xero] Xero appears under "Other integrations" when it is manually synced #41320

Closed

6 tasks

Update

a362c38

ShridharGoel force-pushed the 41320 branch from 635b904 to a362c38 Compare May 3, 2024 12:06

ShridharGoel added 2 commits May 3, 2024 17:54

Update PolicyAccountingPage.tsx

d7fc0c3

Update PolicyAccountingPage.tsx

ff31b53

mananjadhav reviewed May 6, 2024

View reviewed changes

trjExpensify mentioned this pull request May 8, 2024

[$250] [HOLD for payment 2024-06-11] [Wave Collect] [Xero] [Imported Features and Taxes] Make Categories, Tags, and Taxes read-only when the user is connected to Xero #39911

Closed

ShridharGoel added 2 commits May 8, 2024 18:37

Add new command and JSdoc

1ddad04

Merge branch '41320' of https://github.com/ShridharGoel/ExpensifyApp …

e04f688

…into 41320

hayata-suenaga reviewed May 8, 2024

View reviewed changes

src/libs/actions/connections/index.ts Show resolved Hide resolved

mananjadhav approved these changes May 9, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote May 9, 2024 20:05

ShridharGoel added 2 commits May 10, 2024 01:50

Merge branch 'xero-merge-freeze' of https://github.com/Expensify/App …

a73430f

…into 41320

Update

b6fa193

hayata-suenaga reviewed May 9, 2024

View reviewed changes

ShridharGoel added 2 commits May 14, 2024 20:06

Update

f19f3ed

Updates

1a4bb31

lakchote previously approved these changes May 15, 2024

View reviewed changes

lakchote mentioned this pull request May 15, 2024

[Wave Collect][Xero] Fix the Tags menu item not showing in the LHN #41831

Closed

SzymczakJ mentioned this pull request May 15, 2024

Make taxes read-only when connected to accounting integration #42192

Merged

48 tasks

hayata-suenaga previously approved these changes May 15, 2024

View reviewed changes

hungvu193 approved these changes May 15, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote May 15, 2024 23:34

Merge branch 'main' into 41320

33aeffc

ShridharGoel dismissed stale reviews from hayata-suenaga and lakchote via 33aeffc May 16, 2024 17:49

Fix lint

e2f0a62

lakchote approved these changes May 17, 2024

View reviewed changes

lakchote changed the base branch from main to xero-merge-freeze May 17, 2024 09:56

lakchote merged commit c88c564 into Expensify:xero-merge-freeze May 17, 2024
16 checks passed

github-actions bot mentioned this pull request May 30, 2024

Deploy Checklist: New Expensify 2024-05-30 #42872

Closed

95 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sync functionality in Xero connection #41562

Add sync functionality in Xero connection #41562

ShridharGoel commented May 3, 2024 •

edited

Loading

melvin-bot bot commented May 3, 2024

mananjadhav commented May 6, 2024

mananjadhav May 6, 2024

mananjadhav commented May 8, 2024

mananjadhav commented May 9, 2024 •

edited

Loading

mananjadhav left a comment

hayata-suenaga commented May 9, 2024

hayata-suenaga May 9, 2024

ShridharGoel May 10, 2024

hayata-suenaga May 10, 2024

lakchote May 14, 2024

ShridharGoel May 14, 2024

hungvu193 commented May 15, 2024

hayata-suenaga commented May 15, 2024

hayata-suenaga left a comment

hungvu193 left a comment

hungvu193 commented May 15, 2024 •

edited

Loading

lakchote commented May 16, 2024

ShridharGoel commented May 16, 2024

lakchote commented May 16, 2024

mananjadhav commented May 16, 2024

ShridharGoel commented May 16, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

OSBotify commented Jun 4, 2024

Add sync functionality in Xero connection #41562

Add sync functionality in Xero connection #41562

Conversation

ShridharGoel commented May 3, 2024 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 3, 2024

mananjadhav commented May 6, 2024

mananjadhav May 6, 2024

Choose a reason for hiding this comment

mananjadhav commented May 8, 2024

mananjadhav commented May 9, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav left a comment

Choose a reason for hiding this comment

hayata-suenaga commented May 9, 2024

hayata-suenaga May 9, 2024

Choose a reason for hiding this comment

ShridharGoel May 10, 2024

Choose a reason for hiding this comment

hayata-suenaga May 10, 2024

Choose a reason for hiding this comment

lakchote May 14, 2024

Choose a reason for hiding this comment

ShridharGoel May 14, 2024

Choose a reason for hiding this comment

hungvu193 commented May 15, 2024

hayata-suenaga commented May 15, 2024

hayata-suenaga left a comment

Choose a reason for hiding this comment

hungvu193 left a comment

Choose a reason for hiding this comment

hungvu193 commented May 15, 2024 • edited Loading

lakchote commented May 16, 2024

ShridharGoel commented May 16, 2024

lakchote commented May 16, 2024

mananjadhav commented May 16, 2024

ShridharGoel commented May 16, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

OSBotify commented Jun 4, 2024

ShridharGoel commented May 3, 2024 •

edited

Loading

mananjadhav commented May 9, 2024 •

edited

Loading

hungvu193 commented May 15, 2024 •

edited

Loading