[HOLD for payment 2024-06-13] [$250] Web - Workspace - Unable to navigate the invite list by using the arrow keys

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.72-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

1. Create workspace
2. Go to Members> Invite member
3. In the invite members use the keyboard arrow keys
4. Go back to Members page
5. Go to Invite member
6. Try to use the keyboard arrow keys

Expected Result:

User should navigate the list by using the arrow keys every time Invite new members page open

Actual Result:

User is not able to navigate the invite list by using the arrow keys when open Invite new members page

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6475664_1715246000978.Recording__3003.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015abf6304380bd09f
• Upwork Job ID: 1790448510304206848
• Last Price Increase: 2024-05-21
• Automatic offers:
• abdulrahuman5196 | Reviewer | 102482440

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

on Workspace unable to navigate the invite list by using the arrow keys

What is the root cause of that problem?

When Members page is open, the members list is using the BaseSelectionList component.
On it, the useArrowKeyFocusManager is set to always active isActive: true

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 230 to 239 in 974f6b5

	const [focusedIndex, setFocusedIndex] = useArrowKeyFocusManager({
	initialFocusedIndex: flattenedSections.allOptions.findIndex((option) => option.keyForList === initiallyFocusedOptionKey),
	maxIndex: Math.min(flattenedSections.allOptions.length - 1, CONST.MAX_OPTIONS_SELECTOR_PAGE_LENGTH * currentPage - 1),
	disabledIndexes: flattenedSections.disabledOptionsIndexes,
	isActive: true,
	onFocusedIndexChange: (index: number) => {
	scrollToIndex(index, true);
	},
	isFocused,
	});

Then we open the Invite members page, we use again the useArrowKeyFocusManager but the 1st one is still active.

This is why all key events trigger on the Members page not on the Invite members page.

What changes do you think we should make in order to solve the problem?

on BaseSelectionList component, we need to set the useArrowKeyFocusManager to active only when component is focused here

const [focusedIndex, setFocusedIndex] =  useArrowKeyFocusManager({
	initialFocusedIndex:  flattenedSections.allOptions.findIndex((option) =>  option.keyForList  ===  initiallyFocusedOptionKey),
	maxIndex:  Math.min(flattenedSections.allOptions.length  -  1, CONST.MAX_OPTIONS_SELECTOR_PAGE_LENGTH  *  currentPage  -  1),
	disabledIndexes:  flattenedSections.disabledOptionsIndexes,
-	isActive:  true,
+	isActive:  isFocused,
	onFocusedIndexChange: (index:  number) => {
	scrollToIndex(index, true);
	},
	isFocused,
});

POC:

20240509_201004.mp4

[alexpensify]

On my testing list, I'll get to it soon.

[alexpensify]

I wasn't able to get to this one over the weekend, still on my radar.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015abf6304380bd09f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[alexpensify]

I confirmed that this is an issue and couldn't find another duplicate of this issue. We need proposals here.

[alexpensify]

@abdulrahuman5196 - can you please confirm if the proposal above will fix this issue? Thanks!

[abdulrahuman5196]

Hi I will check on this in my morning.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[alexpensify]

Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.

@Christinadobrzyn - I need help here to ensure that we get proposals and they are reviewed. I'm trying to avoid this one going stale. Thanks!

[melvin-bot]

@alexpensify, @abdulrahuman5196, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

@abdulrahuman5196 can you take a peek at the above proposal? or let me know if should reach out to SWM to see if someone might be able to grab this! TY!

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@alexpensify @luacmartins @abdulrahuman5196 @Christinadobrzyn this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Christinadobrzyn]

@luacmartins can you take a peek at this review? #41906 (comment)

Thank you!

[luacmartins]

Sorry, was ooo for the last few days. I agree that @dragnoir's proposal looks good.

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dragnoir You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[alexpensify]

Thanks, @Christinadobrzyn, for the help here. I'm back online and taking over again as the BZ member here.

[alexpensify]

Update: The PR is ready for review

[alexpensify]

Weekly Update: The PR is waiting to go to Production

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: navigate to invite list by arrow keys #42713

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @dragnoir requires payment (Needs manual offer from BZ)
• @abdulrahuman5196 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

Okay, we are ready to pay via Upwork tomorrow. @dragnoir, I had to manually send an Upwork offer. Please accept, and I can complete the process tomorrow. Thanks!

[alexpensify]

Paid via Upwork!

Payouts due: 2024-06-13

• Contributor: $250 @dragnoir
• Contributor+: $250 @abdulrahuman5196

Upwork job is here.