-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MEDIUM] Sequential menu when paying an invoice #41976
Comments
Triggered auto assignment to @miljakljajic ( |
Hello, Im Artem from Callstack and taking this issue! |
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah ( |
@cristipaval, @miljakljajic, @waterim, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@waterim - Did you ended up adding the sequential menu in this PR as I see in #41859 (comment) ? Let me know if the PR needs my C+ review |
Yes, its there and I need a C+ review there too Cc @cristipaval |
@cristipaval, @miljakljajic, @waterim, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@waterim - Let me know when it's ready for review |
Main pr is ready |
@ikevin127 Do you want to take over #41859 review as you were auto assigned? |
@rayane-djouah You can go ahead and take over since I'm not assigned as C+ to #40437, and also I was not noticed based on my #41859 (comment) from the PR in order to let me know when PR is ready for review. Therefore I'm happy to pass the whole thing to you if you want it, go ahead! |
@ikevin127 - Actually, I'm low on bandwidth. Please go ahead if you can take it, otherwise I will ask for another C+ to take it. |
Cool, then I'll take over this one as well as reviewer! @waterim Let me know what's the status of PR #40437 and also the status of this issue and whether or not you're including the fix for this issue in the mentioned PR. |
Thank you! |
@cristipaval, @miljakljajic, @waterim Eep! 4 days overdue now. Issues have feelings too... |
Closing this one given that it is implemented in the PR with the GBR button |
Held on #40437
Instead of the built in dropdown list from the Payment button, we want to display the bottom modal as in the above screenshot when the user hits the payment button for an invoice.
Issue Owner
Current Issue Owner: @waterimThe text was updated successfully, but these errors were encountered: