Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEDIUM] Sequential menu when paying an invoice #41976

Closed
cristipaval opened this issue May 10, 2024 · 17 comments
Closed

[MEDIUM] Sequential menu when paying an invoice #41976

cristipaval opened this issue May 10, 2024 · 17 comments
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@cristipaval
Copy link
Contributor

cristipaval commented May 10, 2024

Held on #40437

image

Instead of the built in dropdown list from the Payment button, we want to display the bottom modal as in the above screenshot when the user hits the payment button for an invoice.

Issue OwnerCurrent Issue Owner: @waterim
@cristipaval cristipaval added the NewFeature Something to build that is a new item. label May 10, 2024
Copy link

melvin-bot bot commented May 10, 2024

Triggered auto assignment to @miljakljajic (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Weekly KSv2 label May 10, 2024
@cristipaval cristipaval changed the title [MEDIUM] Sequential menu when paying an invoice [HOLD][MEDIUM] Sequential menu when paying an invoice May 10, 2024
@waterim
Copy link
Contributor

waterim commented May 14, 2024

Hello, Im Artem from Callstack and taking this issue!

@cristipaval cristipaval added the External Added to denote the issue can be worked on by a contributor label May 14, 2024
Copy link

melvin-bot bot commented May 14, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 14, 2024
Copy link

melvin-bot bot commented May 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 14, 2024
@cristipaval cristipaval removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 14, 2024
@cristipaval cristipaval changed the title [HOLD][MEDIUM] Sequential menu when paying an invoice [MEDIUM] Sequential menu when paying an invoice May 14, 2024
Copy link

melvin-bot bot commented May 17, 2024

@cristipaval, @miljakljajic, @waterim, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label May 17, 2024
@rayane-djouah
Copy link
Contributor

@waterim - Did you ended up adding the sequential menu in this PR as I see in #41859 (comment) ? Let me know if the PR needs my C+ review

@waterim
Copy link
Contributor

waterim commented May 17, 2024

Yes, its there and I need a C+ review there too
There will be few changes, cause Im still investigating the bug with hover effect on the subMenus in ReportPreview component

Cc @cristipaval

@melvin-bot melvin-bot bot removed the Overdue label May 17, 2024
Copy link

melvin-bot bot commented May 21, 2024

@cristipaval, @miljakljajic, @waterim, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label May 21, 2024
@rayane-djouah
Copy link
Contributor

@waterim - Let me know when it's ready for review

@waterim
Copy link
Contributor

waterim commented May 21, 2024

Main pr is ready

@melvin-bot melvin-bot bot removed the Overdue label May 21, 2024
@rayane-djouah
Copy link
Contributor

@ikevin127 Do you want to take over #41859 review as you were auto assigned?

@ikevin127
Copy link
Contributor

@rayane-djouah You can go ahead and take over since I'm not assigned as C+ to #40437, and also I was not noticed based on my #41859 (comment) from the PR in order to let me know when PR is ready for review.

Therefore I'm happy to pass the whole thing to you if you want it, go ahead!

@rayane-djouah
Copy link
Contributor

@ikevin127 - Actually, I'm low on bandwidth. Please go ahead if you can take it, otherwise I will ask for another C+ to take it.

@ikevin127
Copy link
Contributor

Cool, then I'll take over this one as well as reviewer!
cc @cristipaval @miljakljajic

@waterim Let me know what's the status of PR #40437 and also the status of this issue and whether or not you're including the fix for this issue in the mentioned PR.

@rayane-djouah
Copy link
Contributor

Thank you!
Unassigning myself as @ikevin127 will be taking this one.

@rayane-djouah rayane-djouah removed their assignment May 21, 2024
Copy link

melvin-bot bot commented May 27, 2024

@cristipaval, @miljakljajic, @waterim Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
@cristipaval
Copy link
Contributor Author

Closing this one given that it is implemented in the PR with the GBR button

@melvin-bot melvin-bot bot removed the Overdue label May 30, 2024
@github-project-automation github-project-automation bot moved this from Medium to Done in [#whatsnext] #billpay May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

5 participants