[HOLD for payment 2024-06-13] CRITICAL: GBR and Settlement button for the receiver on the invoice report preview

[cristipaval]

Part of the Invoicing V0.2 project

Main issue: https://github.com/Expensify/Expensify/issues/341717
Doc section: Invoicing V1
Project: #vip-billpay

Feature Description

Implement the Settlement button on the invoice report preview in the invoice room, when the user is the individual receiver.

Manual Test Steps

Automated Tests

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[trjExpensify]

Feature Description

Implement the Settlement button on the

😅 Heads up, man! I think you forgot to finish your sen

[cristipaval]

DANG! Sorry

[trjExpensify]

👋 @cristipaval what issue is this on hold for? We should update the title to make that dependency clear.

[cristipaval]

this is part of the V0.2 which is held until the v0.1 is launched

[waterim]

@cristipaval Should I take this asap as v1 was merged?

[cristipaval]

@waterim yes please start working on this when the critical issues on the V0.1 are cleared

[cristipaval]

^Auth PR is ready for review. It enables the GBR to the receiver on the invoice room in the LHN.

[cristipaval]

We have a draft App PR^ 🙌

[VickyStash]

Updates:

• addressed designers' feedback
• waiting for C+ review

[melvin-bot]

This issue has not been updated in over 15 days. @trjExpensify, @cristipaval, @waterim eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

PR is in active review, Melv.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• GBR and Settlement button for the receiver on the invoice report preview #41859

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@waterim] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[ikevin127]

The regression message from here is false alarm and sorted out in #43145 (comment).

Regarding #40437 (comment), I reviewed PR as C+ and require compensation.

Note: Given the status of the issue is Critical, the bounty should be $500.

cc @trjExpensify

[trjExpensify]

Assigned you to the issue to not lose track of that.

[trjExpensify]

@ikevin127 offer sent for $500 for the C+ review.

[ikevin127]

@trjExpensify Offer accepted (awaiting payment), thank you!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @waterim is from an agency-contributor and not due payment
• ROLE: @ikevin127 paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/102717721)

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct