[HOLD for payment 2024-06-11] [$250] Workspace - User is already a member of the Workspace message is missing

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Create Workspace
2. Go to Members> Invite> Invite any user
3. Go to Members> Invite> Enter the same user email

Expected Result:

There should be a message that this user is already a member of the workspace

Actual Result:

Infinite loading spinner appear and there is no system message that this user is already a member of the workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6482004_1715803784548.Recording__3023.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0164162f457c6f5060
• Upwork Job ID: 1793040367583154176
• Last Price Increase: 2024-05-21
• Automatic offers:
• nkdengineer | Contributor | 102437557

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Infinite loading spinner appear and there is no system message that this user is already a member of the workspace

What is the root cause of that problem?

While we're loading new option from server we don't show the header message

App/src/components/SelectionList/BaseSelectionList.tsx

Line 560 in 94d3a5c

{!isLoadingNewOptions && !!headerMessage && (

What changes do you think we should make in order to solve the problem?

As the description here, I think we only need to hide the header message while the new option loading if the header message says no there are no option.

{(!isLoadingNewOptions || headerMessage !== translate('common.noResultsFound')) && (

App/src/components/SelectionList/BaseSelectionList.tsx

Line 558 in 94d3a5c

{/* If we are loading new options we will avoid showing any header message. This is mostly because one of the header messages says there are no options. */}

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[kevinksullivan]

Agree this is a collect issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0164162f457c6f5060

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Ollyws]

@nkdengineer's proposal LGTM.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@Ollyws this PR is ready for preview

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: User is already a member of the Workspace message is missing #42569

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kevinksullivan]

Hey @Ollyws can you finish out the steps above? It feels like we may want this to be a regression test.

[kevinksullivan]

Payment summary

• @nkdengineer $250 (already paid in upwork)
• @Ollyws $250 (Newdot)

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

#38994

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/38994/files#r1638805506

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

Yes

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to Members > Invite > Invite any user
2. Go to Members > Invite > Enter the same user email
3. Verify that: There should be a message that this user is already a member of the workspace

Do we agree 👍 or 👎

[Ollyws]

Requested in ND.

[JmillsExpensify]

$250 approved for @Ollyws

[kevinksullivan]

all set