[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$125] [TS migration] Configure TS & Migrate CONST, fastMerge, Device, Logger to Typescript (expensify-common)

[blazejkustra]

Typescript migration (expensify-common)

Make sure you read through our TypeScript's style guide before you start working on this migration issue.

Files

lib/CONST.jsx
lib/fastMerge.js
lib/Device.jsx
lib/Logger.jsx

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5172255327c6e67
• Upwork Job ID: 1791118677164871680
• Last Price Increase: 2024-05-16

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[blazejkustra]

I got approval from @roryabraham to create this issue on #typescript-new-expensify channel here. Let's add it to Typescript project and change labels as this is not a bug, thanks!

[blazejkustra]

I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue 😄

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5172255327c6e67

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[joekaufmanexpensify]

@blazejkustra sounds good! Is the next step for you to raise a PR here?

[roryabraham]

yes, I think so

[melvin-bot]

Upwork job price has been updated to $125

[ghost]

Dibs

[joekaufmanexpensify]

@godofoutcasts94 this issue is already assigned. Only issues with the help wanted label are available. LMK if you have questions.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Update expensify-common usage in NewDot #42387

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @abdulrahuman5196 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Update expensify-common usage in NewDot #42387

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @abdulrahuman5196 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[joekaufmanexpensify]

No regression test needed for TS migration

[joekaufmanexpensify]

Only payment here is $125 to @abdulrahuman5196 for C+ review via Upwork.

[joekaufmanexpensify]

@abdulrahuman5196 just sent you an offer for $125!

[joekaufmanexpensify]

There may be a possible regression here too. @roryabraham @abdulrahuman5196 could you please confirm if this was indeed a regression?

[joekaufmanexpensify]

I'm about to go OOO until 2024-06-25. Adding another BZ assignee to handle payment next week. We just need to:

• Determine whether this was a regression.
• Issue payment after the waiting period.

I'll take this back once I return (if it's still open)!

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[bfitzexpensify]

Bump on #42245 (comment) @roryabraham @abdulrahuman5196 - thank you!

[abdulrahuman5196]

@bfitzexpensify I don't think this is a direct regression but a combined issue due to efforts from different PR.
But feel free to correct me if wrong.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @blazejkustra is from an agency-contributor and not due payment
• ROLE: @abdulrahuman5196 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1791118677164871680/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[bfitzexpensify]

Thanks for confirming @abdulrahuman5196. Paid out, we're all done here.