[LOW] [Performance] [$250] Investigate why unfocused screens are updated by onyx

[mountiny]

Coming from onyx bump #42057 (comment)

Investigate how to fix an issue where unfocused screen is being updated by onyx. There was a solution put in place to unblock the onyx update, however, we should explore if there are better ways to solve it. Slack discussion here

To fix #42057 (comment), this commit was used e7e73c8

cc @chrispader

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f294fb9fd27db9de
• Upwork Job ID: 1793569593909895168
• Last Price Increase: 2024-05-23

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[chrispader]

commenting for assignment 👋🏼

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f294fb9fd27db9de

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[mountiny]

thanks Chris

[melvin-bot]

@chrispader, @isabelastisser, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

[mountiny]

@chrispader can you look into this once the deploy blocker is resolved?

[chrispader]

@chrispader can you look into this once the deploy blocker is resolved?

yes, gonna do!

[melvin-bot]

@chrispader, @isabelastisser, @DylanDylann Still overdue 6 days?! Let's take care of this!

[isabelastisser]

Any updates? @DylanDylann @chrispader Thanks!

[mountiny]

I believe Chris is now focusing on fixing latest onyx version which is higher priority so no updates still

[melvin-bot]

@chrispader @isabelastisser @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[isabelastisser]

@mountiny should I put this on hold?

[chrispader]

i might start working on this tmrw, depends how much there is to do in #42772

[isabelastisser]

@mountiny, which wave and release should I add this to? thanks!

[mountiny]

Added as low to the newdot quality as this is performance related

[isabelastisser]

Thanks, Vit!

[isabelastisser]

@chrispader @DylanDylann, any progress?

[DylanDylann]

Waiting for @chrispader to implement PR

[chrispader]

Going to work on this now and over the weekend!

[chrispader]

I now finished profiling and investigating some (navigation) flows in E/App and it seems this issue was fixed by the recent Onyx bump PR.

I think the reason for old screen props being updated before, was that Onyx was in a weird intermediate state of some transitions, that are now finished by version 2.0.48.

The following issues are still fixed without the need for any changes:

• Bump Onyx to 2.0.41 #42057 (comment)
• Fix: navigate to invite list by arrow keys #42713

Therefore i think we can close this out!

[isabelastisser]

Thanks for the update, @chrispader! Closing this.