Bump Onyx to 2.0.41 #42057

chrispader · 2024-05-13T13:14:53Z

@roryabraham @francoisl @tgolen

Details

Bumps Onyx to 2.0.41 and fixes #41531

Fixed Issues

$ #41531
$ #41895
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Address page country selection

Go to Settings -> Profile -> Address
Either set or change the address to some address in the US.
Save the address
Edit the address again
Start typing a UK address (e.g. "226 Baker Street").
Select the UK address from the list
Make sure the country changes to UK and validation of the zip code works.

Offline tests

None needed.

QA Steps

Verify that no errors appear in the JS console

Same as in Tests.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-05-13.at.16.56.07.mov

MacOS: Desktop

Added a screen recording for Desktop web

melvin-bot · 2024-05-13T13:15:22Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…onyx-to-2-0-40

chrispader · 2024-05-13T14:55:18Z

Included @fabioh8010 's changes from #40367 in this PR

chrispader · 2024-05-22T19:43:36Z

@mountiny all bugs/regressions from the Onyx bump mentioned by @ikevin127 should now be resolved.

I added a fix for #42057 (comment), but i don't think this is the perfect solution to this problem. The issue was caused by Onyx now (somehow) updating a screen, that is not in focus, and this unfocused screen would then cause to update the keyboard shortcut subscriptions.

I asked about this in #expensify-open-source and would like to create a follow-up PR to improve this, if wanted. For now, this fix is working reliably.

ikevin127 · 2024-05-22T20:44:05Z

Re-tested previously triaged ⚠️ issues from #42057 (comment):

✅ Web - Chat - URL is not hyperlinked on chat composer

Fixed.

✅ Web - Receipt - Delete receipt is not displayed

Fixed.

✅ Web - Receipt - Its not here page is displayed when trying to replace a receipt

Fixed.

✅ Web - Distance - Distance receipt only shows the map

Fixed.

✅ Category - Keyboard navigation in category list is blocked when there is Recent section

Fixed by commit e7e73c8.

cc @chrispader @mountiny

I'll start working on the reviewer checklist and approve if everything looks good.

ikevin127

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

mountiny

Thanks for fixing it all. I have created an issue to follow up and investigate if there i a better solution to the last bug mentioned #42505. If you want to take it on @chrispader, can you comment on it please?

@ikevin127 thank you for thorough testing!

mountiny · 2024-05-23T09:09:09Z

Currently, we still have a merge freeze in place such that we only selectively merge changes based on their importance. I have made a request internally to get this merged as we have other onyx changes lined up

OSBotify · 2024-05-27T14:25:20Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

puneetlath · 2024-05-28T19:44:30Z

Did we need to do the onyx bump and all the other changes that were made here in the same PR? If not, in the future, let's separate those into separate PRs so that it's easier to revert.

mountiny · 2024-05-28T20:49:22Z

Did we need to do the onyx bump and all the other changes that were made here in the same PR? If not, in the future, let's separate those into separate PRs so that it's easier to revert.

It had to be done as the onyx bump included changes to types so most of the changes were required to make the typecheck pass.

…to-2-0-40" This reverts commit 6fd7fbb, reversing changes made to 4bd72e4.

mountiny · 2024-05-28T21:03:58Z

I have tried to resolve the conflicts and running a build here #42725

[CP Staging] Revert "Merge pull request #42057 from margelo/@chrispader/bump-onyx-…

[CP Staging] Revert "Merge pull request #42057 from margelo/@chrispader/bump-onyx-… (cherry picked from commit c956751)

…margelo/@chrispader/bump-onyx-…"

Beamanator · 2024-05-29T07:56:07Z

Reverted in #42725

OSBotify · 2024-05-29T09:18:01Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-29T09:42:48Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

…chrispader/bump-onyx-…"

OSBotify · 2024-05-30T21:25:37Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:37:35Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fabioh8010 and others added 10 commits April 17, 2024 18:32

Fix typings across the project

5fda1d1

Merge branch 'main' into feature/useOnyx-undefined-value

bf0fca1

Bump TS version to match Onyx's one

3500732

Typing fixes

90b78a6

Merge branch 'main' into feature/useOnyx-undefined-value

a097e87

lint fix

6d3d918

Merge branch 'main' into feature/useOnyx-undefined-value

9b1e2b2

bump onyx

d64780f

fix: country not updated in address form

657be97

fix: improve naming and casting of variables

307b300

chrispader requested a review from a team as a code owner May 13, 2024 13:14

melvin-bot bot requested review from arosiclair and removed request for a team May 13, 2024 13:15

chrispader added 3 commits May 13, 2024 15:25

set strict version

9325262

fix: IOUTest types

408e0b0

fix: more type errors

883e3e1

mountiny assigned chrispader May 13, 2024

mountiny added the Ready To Build label May 13, 2024

fix: personal details list typings

f2d293b

This was referenced May 13, 2024

Profile - Address - Zip code verification does not work correctly #41531

Closed

Fix inconsistencies between single key operations (merge, set) and multi key operations (mergeCollection, multiSet) Expensify/react-native-onyx#519

Merged

chrispader changed the title ~~Bump Onyx to 2.0.40~~ Bump Onyx to 2.0.41 May 13, 2024

chrispader added 6 commits May 13, 2024 16:33

update onyx

10e3ab0

fix: more ts errors

692c071

fix: more ts issues

d722f27

Merge branch 'main' into @chrispader/bump-onyx-to-2-0-40

874dc1d

Merge branch 'main' into feature/useOnyx-undefined-value

6029747

Merge branch 'feature/useOnyx-undefined-value' into @chrispader/bump-…

67ca37e

…onyx-to-2-0-40

ikevin127 approved these changes May 22, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny May 22, 2024 21:49

mountiny mentioned this pull request May 23, 2024

[LOW] [Performance] [$250] Investigate why unfocused screens are updated by onyx #42505

Closed

mountiny approved these changes May 23, 2024

View reviewed changes

chiragsalian merged commit 6fd7fbb into Expensify:main May 23, 2024
18 checks passed

github-actions bot mentioned this pull request May 27, 2024

Deploy Checklist: New Expensify 2024-05-27 #42636

Closed

69 tasks

mountiny added a commit that referenced this pull request May 28, 2024

Revert "Merge pull request #42057 from margelo/@chrispader/bump-onyx-…

a51a245

…to-2-0-40" This reverts commit 6fd7fbb, reversing changes made to 4bd72e4.

mountiny mentioned this pull request May 28, 2024

[CP Staging] Revert "Merge pull request #42057 from margelo/@chrispader/bump-onyx-… #42725

Merged

50 tasks

Beamanator added a commit that referenced this pull request May 29, 2024

Merge pull request #42725 from Expensify/vit-revert42057

c956751

[CP Staging] Revert "Merge pull request #42057 from margelo/@chrispader/bump-onyx-…

OSBotify pushed a commit that referenced this pull request May 29, 2024

Merge pull request #42725 from Expensify/vit-revert42057

14289e6

[CP Staging] Revert "Merge pull request #42057 from margelo/@chrispader/bump-onyx-… (cherry picked from commit c956751)

kosmydel added a commit to kosmydel/ExpensifyApp that referenced this pull request May 29, 2024

Revert "[CP Staging] Revert "Merge pull request Expensify#42057 from …

91ce8d7

…margelo/@chrispader/bump-onyx-…"

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

This was referenced May 29, 2024

Remove null values from cache to improve Onyx read speed Expensify/react-native-onyx#554

Merged

Bump onyx to 2.0.48 (after revert) #42772

Merged

aldo-expensify added a commit that referenced this pull request May 29, 2024

Revert "[CP Staging] Revert "Merge pull request #42057 from margelo/@…

bf0da56

…chrispader/bump-onyx-…"

ikevin127 mentioned this pull request Jun 5, 2024

Onyx Bump 2.0.48: null -> undefined changes margelo/expensify-app-fork#20

Merged

50 tasks

This was referenced Aug 19, 2024

[HOLD for Payment 2024-09-06] [$500] [Performance] Create Onyx connection Manager #47143

Closed

Bump Onyx to v2.0.65 #44987

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Onyx to 2.0.41 #42057

Bump Onyx to 2.0.41 #42057

chrispader commented May 13, 2024 •

edited

Loading

melvin-bot bot commented May 13, 2024

chrispader commented May 13, 2024

chrispader commented May 22, 2024

ikevin127 commented May 22, 2024 •

edited

Loading

ikevin127 left a comment

mountiny left a comment

mountiny commented May 23, 2024

OSBotify commented May 27, 2024

puneetlath commented May 28, 2024

mountiny commented May 28, 2024

mountiny commented May 28, 2024

Beamanator commented May 29, 2024

OSBotify commented May 29, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

Bump Onyx to 2.0.41 #42057

Bump Onyx to 2.0.41 #42057

Conversation

chrispader commented May 13, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 13, 2024

chrispader commented May 13, 2024

chrispader commented May 22, 2024

ikevin127 commented May 22, 2024 • edited Loading

ikevin127 left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented May 23, 2024

OSBotify commented May 27, 2024

puneetlath commented May 28, 2024

mountiny commented May 28, 2024

mountiny commented May 28, 2024

Beamanator commented May 29, 2024

OSBotify commented May 29, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

chrispader commented May 13, 2024 •

edited

Loading

ikevin127 commented May 22, 2024 •

edited

Loading