Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-20] [Payment card / Subscription] Polish "Subscription details" section with useThemeIllustrations #43306

Closed
amyevans opened this issue Jun 7, 2024 · 6 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@amyevans
Copy link
Contributor

amyevans commented Jun 7, 2024

Per this comment on the PR for #38623, we should refactor to use themed illustrations and the useThemeIllustrations hook for the ExpensifyApproved logo. See https://github.com/Expensify/App/tree/32f176fe7734c27ee0b8e0256e8a8fd5a6ac237d/src/styles/theme/illustrations.

@roryabraham
Copy link
Contributor

@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

@JKobrynski
Copy link
Contributor

The PR is ready for review!

@roryabraham
Copy link
Contributor

PR merged, no C+ services used. Closing this out.

@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect Jun 11, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 13, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Polish "Subscription details" section with useThemeIllustrations [HOLD for payment 2024-06-20] [Payment card / Subscription] Polish "Subscription details" section with useThemeIllustrations Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants