[HOLD for payment 2024-06-20] [$250] LHN - Most recent priority mode displayed as #focus and the other way around on secondary device

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.80-11
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4605078
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to New Expensify with the same account on two devices/two separate browsers
2. [Device 1] Navigate to Account Settings > Preferences
3. [Device 1] Change Priority mode to "#focus"
4. Verify the change on [Device 2]
5. [Device 1] Change Priority mode to "Most recent"
6. Verify the change on [Device 2]

Expected Result:

Priority mode should change on secondary device and the LHN should be displayed in the same style on both devices

Actual Result:

Priority mode changes on the secondary device accordingly to the changes made on the [Device 1] but it is displayed in the style of the other priority mode in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6505198_1717774687450.2024-06-07_17-15-30.mp4

Bug6505198_1717774687450.2024-06-06_20-50-49.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01761ff40a6e4283bd
• Upwork Job ID: 1799172422521172555
• Last Price Increase: 2024-06-07
• Automatic offers:
• c3024 | Reviewer | 102666669
• bernhardoj | Contributor | 102666670

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01761ff40a6e4283bd

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The most recent/focus mode view doesn't update correctly when it's updated from secondary device.

What is the root cause of that problem?

The most recent/focus mode view depends on optionMode.

App/src/components/LHNOptionsList/LHNOptionsList.tsx

Line 139 in 4176e95

viewMode={optionMode}

However, the list doesn't re-render correctly when optionMode is updated because it's missing from the extraData.

App/src/components/LHNOptionsList/LHNOptionsList.tsx

Lines 167 to 170 in 4176e95

	const extraData = useMemo(
	() => [reportActions, reports, policy, personalDetails, data.length, draftComments],
	[reportActions, reports, policy, personalDetails, data.length, draftComments],
	);

Any external dependency should be included on the extraData.

What changes do you think we should make in order to solve the problem?

Add optionMode to the extraData.

and any other data if needed

[c3024]

I assumed FlashList rerenders when renderItem changes. Apparently, anything that renderItem depends on that is not in data needs to be passed in extraData.

So, adding viewMode to extraData makes sense.

@bernhardoj 's proposal here looks good to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @c3024

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix most recent priority mode displayed as #focus and the other way around #43355

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[c3024]

The PR that introduced the bug has been identified. Link to the PR:

#33108

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

e205c9d#r143337922

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1718879530091549

Determine if we should create a regression test for this bug.

Yes

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Login with a same account from two devices/browsers
2. On Device 1, go to Settings > Preferences > Priority Mode
3. Change the mode from Most Recent to focus or vice versa
4. On Device 2, verify that LHN shows the correct view for the mode changed in step 3

👍 or 👎

[slafortune]

@bernhardoj Paid via Upworks ✅
@c3024 Paid via Upworks ✅